From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 84D154596C for ; Thu, 12 Sep 2024 10:31:49 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7F3BE40E4A; Thu, 12 Sep 2024 10:31:49 +0200 (CEST) Received: from dpdk.org (dpdk.org [92.243.24.197]) by mails.dpdk.org (Postfix) with ESMTP id 0EEE340E41 for ; Thu, 12 Sep 2024 10:31:48 +0200 (CEST) Received: by dpdk.org (Postfix, from userid 65534) id F1D11121D10; Thu, 12 Sep 2024 10:31:47 +0200 (CEST) Subject: |WARNING| pw143994 [PATCH v2 14/14] drivers: use per line logging in helpers In-Reply-To: <20240912082643.1532679-15-david.marchand@redhat.com> References: <20240912082643.1532679-15-david.marchand@redhat.com> To: test-report@dpdk.org From: checkpatch@dpdk.org Cc: David Marchand Message-Id: <20240912083147.F1D11121D10@dpdk.org> Date: Thu, 12 Sep 2024 10:31:47 +0200 (CEST) X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/143994 _coding style issues_ WARNING:TYPO_SPELLING: 'tim' may be misspelled - perhaps 'time'? #765: FILE: drivers/common/cnxk/roc_platform.h:279: +#define RTE_LOGTYPE_tim cnxk_logtype_tim WARNING:TYPO_SPELLING: 'tim' may be misspelled - perhaps 'time'? #765: FILE: drivers/common/cnxk/roc_platform.h:279: +#define RTE_LOGTYPE_tim cnxk_logtype_tim CHECK:MACRO_ARG_REUSE: Macro argument reuse 'sc' - possible side-effects? #2177: FILE: drivers/net/bnx2x/bnx2x_logs.h:21: +#define PMD_DRV_LOG(level, sc, ...) \ + RTE_LOG_LINE_PREFIX(level, BNX2X_DRIVER, "[%s:%d(%s)] ", \ + __func__ RTE_LOG_COMMA __LINE__ RTE_LOG_COMMA \ + (sc)->devinfo.name ? (sc)->devinfo.name : "", __VA_ARGS__) ERROR:SPACING: space required before the open parenthesis '(' #2190: FILE: drivers/net/bnx2x/bnx2x_logs.h:30: +#define PMD_RX_LOG(...) do { } while(0) ERROR:SPACING: space required before the open parenthesis '(' #2201: FILE: drivers/net/bnx2x/bnx2x_logs.h:37: +#define PMD_TX_LOG(...) do { } while(0) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'sc' - possible side-effects? #2209: FILE: drivers/net/bnx2x/bnx2x_logs.h:41: +#define PMD_DEBUG_PERIODIC_LOG(level, sc, ...) \ + RTE_LOG_LINE_PREFIX(level, BNX2X_DRIVER, "%s(%s): ", \ + __func__ RTE_LOG_COMMA (sc)->devinfo.name ? (sc)->devinfo.name : "", __VA_ARGS__) WARNING:SPACING: space prohibited between function name and open parenthesis '(' #2211: FILE: drivers/net/bnx2x/bnx2x_logs.h:43: + __func__ RTE_LOG_COMMA (sc)->devinfo.name ? (sc)->devinfo.name : "", __VA_ARGS__) CHECK:CAMELCASE: Avoid CamelCase: #2434: FILE: drivers/net/dpaa2/dpaa2_rxtx.c:402: + "fd_off=%d fd =%" PRIx64 ", meta = %d bpid =%d, len=%d", CHECK:CAMELCASE: Avoid CamelCase: #3774: FILE: drivers/net/octeon_ep/otx_ep_rxtx.c:921: + "last_pkt_count %" PRIu64 "new_pkts %d.", ERROR:SPACING: space required before the open parenthesis '(' #4085: FILE: drivers/net/virtio/virtio_logs.h:21: +#define PMD_RX_LOG(...) do { } while(0) ERROR:SPACING: space required before the open parenthesis '(' #4095: FILE: drivers/net/virtio/virtio_logs.h:28: +#define PMD_TX_LOG(...) do { } while(0) ERROR:SPACING: space required before the open parenthesis '(' #4130: FILE: drivers/net/vmxnet3/vmxnet3_logs.h:18: +#define PMD_RX_LOG(...) do { } while(0) ERROR:SPACING: space required before the open parenthesis '(' #4140: FILE: drivers/net/vmxnet3/vmxnet3_logs.h:25: +#define PMD_TX_LOG(...) do { } while(0) ERROR:SPACING: space required before the open parenthesis '(' #4150: FILE: drivers/net/vmxnet3/vmxnet3_logs.h:32: +#define PMD_TX_FREE_LOG(...) do { } while(0) total: 7 errors, 3 warnings, 3347 lines checked