automatic DPDK test reports
 help / color / mirror / Atom feed
From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Jie Liu <liujie5@linkdatatechnology.com>
Subject: |WARNING| pw144073 [PATCH v2] net/sxe: add net driver sxe again
Date: Mon, 16 Sep 2024 11:55:08 +0200 (CEST)	[thread overview]
Message-ID: <20240916095508.EF341121D10@dpdk.org> (raw)
In-Reply-To: <20240916095426.1206-1-liujie5@linkdatatechnology.com>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/144073

_coding style issues_


CHECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements
#158: FILE: drivers/net/sxe/pf/sxe_filter.c:85:
+	LOG_DEBUG("default mac addr = "MAC_FMT"
", addr[0], addr[1], addr[2],

ERROR:SPACING: space required after that ',' (ctx:VxV)
#230: FILE: drivers/net/sxe/pf/sxe_filter.c:408:
+			addr[3],addr[4], addr[5]);
 			       ^

WARNING:BRACES: braces {} are not necessary for any arm of this statement
#521: FILE: drivers/net/sxe/sxe_testpmd.c:163:
+	if (strcmp(res->action, "on") == 0) {
[...]
+	} else {
[...]

CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
#527: FILE: drivers/net/sxe/sxe_testpmd.c:169:
+
+}

total: 1 errors, 1 warnings, 2 checks, 509 lines checked
Warning in drivers/net/sxe/sxe_testpmd.c:
Writing to stdout or stderr

  parent reply	other threads:[~2024-09-16  9:55 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20240916095426.1206-1-liujie5@linkdatatechnology.com>
2024-09-16  9:26 ` qemudev
2024-09-16  9:55 ` checkpatch [this message]
2024-09-16 10:13 ` |WARNING| pw144073 [PATCH] [v2] " dpdklab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240916095508.EF341121D10@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=liujie5@linkdatatechnology.com \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).