From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: "Mattias Rönnblom" <mattias.ronnblom@ericsson.com>
Subject: |WARNING| pw144321 [PATCH v10 5/7] eal: add atomic bit operations
Date: Thu, 19 Sep 2024 21:43:58 +0200 (CEST) [thread overview]
Message-ID: <20240919194358.5B80C121D9E@dpdk.org> (raw)
In-Reply-To: <20240919193124.737943-6-mattias.ronnblom@ericsson.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/144321
_coding style issues_
ERROR:SPACING: need consistent spacing around '*' (ctx:WxO)
#257: FILE: lib/eal/include/rte_bitops.h:251:
+ uint32_t *: __rte_bit_atomic_test32, \
^
ERROR:SPACING: spaces required around that ':' (ctx:OxW)
#257: FILE: lib/eal/include/rte_bitops.h:251:
+ uint32_t *: __rte_bit_atomic_test32, \
^
ERROR:SPACING: need consistent spacing around '*' (ctx:WxO)
#258: FILE: lib/eal/include/rte_bitops.h:252:
+ const uint32_t *: __rte_bit_atomic_test32, \
^
ERROR:SPACING: spaces required around that ':' (ctx:OxW)
#258: FILE: lib/eal/include/rte_bitops.h:252:
+ const uint32_t *: __rte_bit_atomic_test32, \
^
ERROR:SPACING: need consistent spacing around '*' (ctx:WxO)
#259: FILE: lib/eal/include/rte_bitops.h:253:
+ uint64_t *: __rte_bit_atomic_test64, \
^
ERROR:SPACING: spaces required around that ':' (ctx:OxW)
#259: FILE: lib/eal/include/rte_bitops.h:253:
+ uint64_t *: __rte_bit_atomic_test64, \
^
ERROR:SPACING: need consistent spacing around '*' (ctx:WxO)
#260: FILE: lib/eal/include/rte_bitops.h:254:
+ const uint64_t *: __rte_bit_atomic_test64)(addr, nr, \
^
ERROR:SPACING: spaces required around that ':' (ctx:OxW)
#260: FILE: lib/eal/include/rte_bitops.h:254:
+ const uint64_t *: __rte_bit_atomic_test64)(addr, nr, \
^
ERROR:SPACING: need consistent spacing around '*' (ctx:WxO)
#282: FILE: lib/eal/include/rte_bitops.h:276:
+ uint32_t *: __rte_bit_atomic_set32, \
^
ERROR:SPACING: spaces required around that ':' (ctx:OxW)
#282: FILE: lib/eal/include/rte_bitops.h:276:
+ uint32_t *: __rte_bit_atomic_set32, \
^
ERROR:SPACING: need consistent spacing around '*' (ctx:WxO)
#283: FILE: lib/eal/include/rte_bitops.h:277:
+ uint64_t *: __rte_bit_atomic_set64)(addr, nr, memory_order)
^
ERROR:SPACING: spaces required around that ':' (ctx:OxW)
#283: FILE: lib/eal/include/rte_bitops.h:277:
+ uint64_t *: __rte_bit_atomic_set64)(addr, nr, memory_order)
^
ERROR:SPACING: need consistent spacing around '*' (ctx:WxO)
#304: FILE: lib/eal/include/rte_bitops.h:298:
+ uint32_t *: __rte_bit_atomic_clear32, \
^
ERROR:SPACING: spaces required around that ':' (ctx:OxW)
#304: FILE: lib/eal/include/rte_bitops.h:298:
+ uint32_t *: __rte_bit_atomic_clear32, \
^
ERROR:SPACING: need consistent spacing around '*' (ctx:WxO)
#305: FILE: lib/eal/include/rte_bitops.h:299:
+ uint64_t *: __rte_bit_atomic_clear64)(addr, nr, memory_order)
^
ERROR:SPACING: spaces required around that ':' (ctx:OxW)
#305: FILE: lib/eal/include/rte_bitops.h:299:
+ uint64_t *: __rte_bit_atomic_clear64)(addr, nr, memory_order)
^
ERROR:SPACING: need consistent spacing around '*' (ctx:WxO)
#328: FILE: lib/eal/include/rte_bitops.h:322:
+ uint32_t *: __rte_bit_atomic_assign32, \
^
ERROR:SPACING: spaces required around that ':' (ctx:OxW)
#328: FILE: lib/eal/include/rte_bitops.h:322:
+ uint32_t *: __rte_bit_atomic_assign32, \
^
ERROR:SPACING: need consistent spacing around '*' (ctx:WxO)
#329: FILE: lib/eal/include/rte_bitops.h:323:
+ uint64_t *: __rte_bit_atomic_assign64)(addr, nr, value, \
^
ERROR:SPACING: spaces required around that ':' (ctx:OxW)
#329: FILE: lib/eal/include/rte_bitops.h:323:
+ uint64_t *: __rte_bit_atomic_assign64)(addr, nr, value, \
^
ERROR:SPACING: need consistent spacing around '*' (ctx:WxO)
#352: FILE: lib/eal/include/rte_bitops.h:346:
+ uint32_t *: __rte_bit_atomic_flip32, \
^
ERROR:SPACING: spaces required around that ':' (ctx:OxW)
#352: FILE: lib/eal/include/rte_bitops.h:346:
+ uint32_t *: __rte_bit_atomic_flip32, \
^
ERROR:SPACING: need consistent spacing around '*' (ctx:WxO)
#353: FILE: lib/eal/include/rte_bitops.h:347:
+ uint64_t *: __rte_bit_atomic_flip64)(addr, nr, memory_order)
^
ERROR:SPACING: spaces required around that ':' (ctx:OxW)
#353: FILE: lib/eal/include/rte_bitops.h:347:
+ uint64_t *: __rte_bit_atomic_flip64)(addr, nr, memory_order)
^
ERROR:SPACING: need consistent spacing around '*' (ctx:WxO)
#376: FILE: lib/eal/include/rte_bitops.h:370:
+ uint32_t *: __rte_bit_atomic_test_and_set32, \
^
ERROR:SPACING: spaces required around that ':' (ctx:OxW)
#376: FILE: lib/eal/include/rte_bitops.h:370:
+ uint32_t *: __rte_bit_atomic_test_and_set32, \
^
ERROR:SPACING: need consistent spacing around '*' (ctx:WxO)
#377: FILE: lib/eal/include/rte_bitops.h:371:
+ uint64_t *: __rte_bit_atomic_test_and_set64)(addr, nr, \
^
ERROR:SPACING: spaces required around that ':' (ctx:OxW)
#377: FILE: lib/eal/include/rte_bitops.h:371:
+ uint64_t *: __rte_bit_atomic_test_and_set64)(addr, nr, \
^
ERROR:SPACING: need consistent spacing around '*' (ctx:WxO)
#401: FILE: lib/eal/include/rte_bitops.h:395:
+ uint32_t *: __rte_bit_atomic_test_and_clear32, \
^
ERROR:SPACING: spaces required around that ':' (ctx:OxW)
#401: FILE: lib/eal/include/rte_bitops.h:395:
+ uint32_t *: __rte_bit_atomic_test_and_clear32, \
^
ERROR:SPACING: need consistent spacing around '*' (ctx:WxO)
#402: FILE: lib/eal/include/rte_bitops.h:396:
+ uint64_t *: __rte_bit_atomic_test_and_clear64)(addr, nr, \
^
ERROR:SPACING: spaces required around that ':' (ctx:OxW)
#402: FILE: lib/eal/include/rte_bitops.h:396:
+ uint64_t *: __rte_bit_atomic_test_and_clear64)(addr, nr, \
^
ERROR:SPACING: need consistent spacing around '*' (ctx:WxO)
#429: FILE: lib/eal/include/rte_bitops.h:423:
+ uint32_t *: __rte_bit_atomic_test_and_assign32, \
^
ERROR:SPACING: spaces required around that ':' (ctx:OxW)
#429: FILE: lib/eal/include/rte_bitops.h:423:
+ uint32_t *: __rte_bit_atomic_test_and_assign32, \
^
ERROR:SPACING: need consistent spacing around '*' (ctx:WxO)
#430: FILE: lib/eal/include/rte_bitops.h:424:
+ uint64_t *: __rte_bit_atomic_test_and_assign64)(addr, nr, \
^
ERROR:SPACING: spaces required around that ':' (ctx:OxW)
#430: FILE: lib/eal/include/rte_bitops.h:424:
+ uint64_t *: __rte_bit_atomic_test_and_assign64)(addr, nr, \
^
ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#444: FILE: lib/eal/include/rte_bitops.h:504:
+ __rte_bit_atomic_ ## variant ## test ## size(const qualifier uint ## size ## _t *addr, \
^
ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#449: FILE: lib/eal/include/rte_bitops.h:509:
+ const qualifier RTE_ATOMIC(uint ## size ## _t) *a_addr = \
^
ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#458: FILE: lib/eal/include/rte_bitops.h:518:
+ __rte_bit_atomic_ ## variant ## set ## size(qualifier uint ## size ## _t *addr, \
^
ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#463: FILE: lib/eal/include/rte_bitops.h:523:
+ qualifier RTE_ATOMIC(uint ## size ## _t) *a_addr = \
^
ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#472: FILE: lib/eal/include/rte_bitops.h:532:
+ __rte_bit_atomic_ ## variant ## clear ## size(qualifier uint ## size ## _t *addr, \
^
ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#477: FILE: lib/eal/include/rte_bitops.h:537:
+ qualifier RTE_ATOMIC(uint ## size ## _t) *a_addr = \
^
ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#486: FILE: lib/eal/include/rte_bitops.h:546:
+ __rte_bit_atomic_ ## variant ## flip ## size(qualifier uint ## size ## _t *addr, \
^
ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#491: FILE: lib/eal/include/rte_bitops.h:551:
+ qualifier RTE_ATOMIC(uint ## size ## _t) *a_addr = \
^
ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#500: FILE: lib/eal/include/rte_bitops.h:560:
+ __rte_bit_atomic_## variant ## assign ## size(qualifier uint ## size ## _t *addr, \
^
ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#514: FILE: lib/eal/include/rte_bitops.h:574:
+ __rte_bit_atomic_ ## variant ## test_and_set ## size(qualifier uint ## size ## _t *addr, \
^
ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#520: FILE: lib/eal/include/rte_bitops.h:580:
+ qualifier RTE_ATOMIC(uint ## size ## _t) *a_addr = \
^
ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#534: FILE: lib/eal/include/rte_bitops.h:594:
+ __rte_bit_atomic_ ## variant ## test_and_clear ## size(qualifier uint ## size ## _t *addr, \
^
ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#540: FILE: lib/eal/include/rte_bitops.h:600:
+ qualifier RTE_ATOMIC(uint ## size ## _t) *a_addr = \
^
ERROR:CODE_INDENT: code indent should use tabs where possible
#545: FILE: lib/eal/include/rte_bitops.h:605:
+^I prev = rte_atomic_fetch_and_explicit(a_addr, ~mask,^I\$
WARNING:LONG_LINE: line length of 101 exceeds 100 columns
#554: FILE: lib/eal/include/rte_bitops.h:614:
+ __rte_bit_atomic_ ## variant ## test_and_assign ## size(qualifier uint ## size ## _t *addr, \
ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#554: FILE: lib/eal/include/rte_bitops.h:614:
+ __rte_bit_atomic_ ## variant ## test_and_assign ## size(qualifier uint ## size ## _t *addr, \
^
WARNING:LONG_LINE: line length of 110 exceeds 100 columns
#560: FILE: lib/eal/include/rte_bitops.h:620:
+ return __rte_bit_atomic_ ## variant ## test_and_set ## size(addr, nr, memory_order); \
WARNING:LONG_LINE: line length of 112 exceeds 100 columns
#562: FILE: lib/eal/include/rte_bitops.h:622:
+ return __rte_bit_atomic_ ## variant ## test_and_clear ## size(addr, nr, memory_order); \
ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#565: FILE: lib/eal/include/rte_bitops.h:625:
+#define __RTE_GEN_BIT_ATOMIC_OPS(variant, qualifier, size) \
+ __RTE_GEN_BIT_ATOMIC_TEST(variant, qualifier, size) \
+ __RTE_GEN_BIT_ATOMIC_SET(variant, qualifier, size) \
+ __RTE_GEN_BIT_ATOMIC_CLEAR(variant, qualifier, size) \
+ __RTE_GEN_BIT_ATOMIC_ASSIGN(variant, qualifier, size) \
+ __RTE_GEN_BIT_ATOMIC_TEST_AND_SET(variant, qualifier, size) \
+ __RTE_GEN_BIT_ATOMIC_TEST_AND_CLEAR(variant, qualifier, size) \
+ __RTE_GEN_BIT_ATOMIC_TEST_AND_ASSIGN(variant, qualifier, size) \
+ __RTE_GEN_BIT_ATOMIC_FLIP(variant, qualifier, size)
ERROR:SPACING: space required after that ',' (ctx:BxO)
#576: FILE: lib/eal/include/rte_bitops.h:636:
+ __RTE_GEN_BIT_ATOMIC_OPS(,, size)
^
ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#604: FILE: lib/eal/include/rte_bitops.h:1388:
+#define __RTE_BIT_OVERLOAD_SZ_3R(fun, qualifier, size, ret_type, arg1_type, \
+ arg1_name, arg2_type, arg2_name) \
+ static inline ret_type \
+ rte_bit_ ## fun(uint ## size ## _t *addr, arg1_type arg1_name, \
+ arg2_type arg2_name) \
+ { \
+ return __rte_bit_ ## fun ## size(addr, arg1_name, arg2_name); \
+ }
ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#607: FILE: lib/eal/include/rte_bitops.h:1391:
+ rte_bit_ ## fun(uint ## size ## _t *addr, arg1_type arg1_name, \
^
ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#613: FILE: lib/eal/include/rte_bitops.h:1397:
+#define __RTE_BIT_OVERLOAD_3R(fun, qualifier, ret_type, arg1_type, arg1_name, \
+ arg2_type, arg2_name) \
+ __RTE_BIT_OVERLOAD_SZ_3R(fun, qualifier, 32, ret_type, arg1_type, \
+ arg1_name, arg2_type, arg2_name) \
+ __RTE_BIT_OVERLOAD_SZ_3R(fun, qualifier, 64, ret_type, arg1_type, \
+ arg1_name, arg2_type, arg2_name)
ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#623: FILE: lib/eal/include/rte_bitops.h:1407:
+ rte_bit_ ## fun(uint ## size ## _t *addr, arg1_type arg1_name, \
^
ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#630: FILE: lib/eal/include/rte_bitops.h:1414:
+#define __RTE_BIT_OVERLOAD_4(fun, qualifier, arg1_type, arg1_name, arg2_type, \
+ arg2_name, arg3_type, arg3_name) \
+ __RTE_BIT_OVERLOAD_SZ_4(fun, qualifier, 32, arg1_type, arg1_name, \
+ arg2_type, arg2_name, arg3_type, arg3_name) \
+ __RTE_BIT_OVERLOAD_SZ_4(fun, qualifier, 64, arg1_type, arg1_name, \
+ arg2_type, arg2_name, arg3_type, arg3_name)
ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#637: FILE: lib/eal/include/rte_bitops.h:1421:
+#define __RTE_BIT_OVERLOAD_SZ_4R(fun, qualifier, size, ret_type, arg1_type, \
+ arg1_name, arg2_type, arg2_name, arg3_type, \
+ arg3_name) \
+ static inline ret_type \
+ rte_bit_ ## fun(uint ## size ## _t *addr, arg1_type arg1_name, \
+ arg2_type arg2_name, arg3_type arg3_name) \
+ { \
+ return __rte_bit_ ## fun ## size(addr, arg1_name, arg2_name, \
+ arg3_name); \
+ }
ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#641: FILE: lib/eal/include/rte_bitops.h:1425:
+ rte_bit_ ## fun(uint ## size ## _t *addr, arg1_type arg1_name, \
^
ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#648: FILE: lib/eal/include/rte_bitops.h:1432:
+#define __RTE_BIT_OVERLOAD_4R(fun, qualifier, ret_type, arg1_type, arg1_name, \
+ arg2_type, arg2_name, arg3_type, arg3_name) \
+ __RTE_BIT_OVERLOAD_SZ_4R(fun, qualifier, 32, ret_type, arg1_type, \
+ arg1_name, arg2_type, arg2_name, arg3_type, \
+ arg3_name) \
+ __RTE_BIT_OVERLOAD_SZ_4R(fun, qualifier, 64, ret_type, arg1_type, \
+ arg1_name, arg2_type, arg2_name, arg3_type, \
+ arg3_name)
ERROR:SPACING: space required after that ',' (ctx:VxO)
#665: FILE: lib/eal/include/rte_bitops.h:1449:
+__RTE_BIT_OVERLOAD_3(atomic_set,, unsigned int, nr, int, memory_order)
^
ERROR:SPACING: space required after that ',' (ctx:VxO)
#666: FILE: lib/eal/include/rte_bitops.h:1450:
+__RTE_BIT_OVERLOAD_3(atomic_clear,, unsigned int, nr, int, memory_order)
^
ERROR:SPACING: space required after that ',' (ctx:VxO)
#667: FILE: lib/eal/include/rte_bitops.h:1451:
+__RTE_BIT_OVERLOAD_4(atomic_assign,, unsigned int, nr, bool, value,
^
ERROR:SPACING: space required after that ',' (ctx:VxO)
#669: FILE: lib/eal/include/rte_bitops.h:1453:
+__RTE_BIT_OVERLOAD_3(atomic_flip,, unsigned int, nr, int, memory_order)
^
ERROR:SPACING: space required after that ',' (ctx:VxO)
#670: FILE: lib/eal/include/rte_bitops.h:1454:
+__RTE_BIT_OVERLOAD_3R(atomic_test_and_set,, bool, unsigned int, nr,
^
ERROR:SPACING: space required after that ',' (ctx:VxO)
#672: FILE: lib/eal/include/rte_bitops.h:1456:
+__RTE_BIT_OVERLOAD_3R(atomic_test_and_clear,, bool, unsigned int, nr,
^
ERROR:SPACING: space required after that ',' (ctx:VxO)
#674: FILE: lib/eal/include/rte_bitops.h:1458:
+__RTE_BIT_OVERLOAD_4R(atomic_test_and_assign,, bool, unsigned int, nr,
^
total: 68 errors, 3 warnings, 474 lines checked
__rte_experimental must appear alone on the line immediately preceding the return type of a function.
__rte_experimental must appear alone on the line immediately preceding the return type of a function.
__rte_experimental must appear alone on the line immediately preceding the return type of a function.
__rte_experimental must appear alone on the line immediately preceding the return type of a function.
__rte_experimental must appear alone on the line immediately preceding the return type of a function.
__rte_experimental must appear alone on the line immediately preceding the return type of a function.
__rte_experimental must appear alone on the line immediately preceding the return type of a function.
__rte_experimental must appear alone on the line immediately preceding the return type of a function.
parent reply other threads:[~2024-09-19 19:43 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20240919193124.737943-6-mattias.ronnblom@ericsson.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240919194358.5B80C121D9E@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=mattias.ronnblom@ericsson.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).