From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EBECC45A25 for ; Wed, 25 Sep 2024 09:38:15 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BA06E402A7; Wed, 25 Sep 2024 09:38:15 +0200 (CEST) Received: from dpdk.org (dpdk.org [92.243.24.197]) by mails.dpdk.org (Postfix) with ESMTP id 15DC8402A7 for ; Wed, 25 Sep 2024 09:38:14 +0200 (CEST) Received: by dpdk.org (Postfix, from userid 65534) id 049CD121D9E; Wed, 25 Sep 2024 09:38:13 +0200 (CEST) Subject: |WARNING| pw144427 [PATCH] net/r8169: add support for phy configuration In-Reply-To: <20240925073737.37607-1-howard_wang@realsil.com.cn> References: <20240925073737.37607-1-howard_wang@realsil.com.cn> To: test-report@dpdk.org From: checkpatch@dpdk.org Cc: Howard Wang Message-Id: <20240925073814.049CD121D9E@dpdk.org> Date: Wed, 25 Sep 2024 09:38:13 +0200 (CEST) X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/144427 _coding style issues_ CHECK:CAMELCASE: Avoid CamelCase: #117: FILE: drivers/net/r8169/r8169_ethdev.h:42: + u8 HwSuppCheckPhyDisableModeVer; CHECK:CAMELCASE: Avoid CamelCase: #122: FILE: drivers/net/r8169/r8169_ethdev.h:47: + u32 HwSuppMaxPhyLinkSpeed; CHECK:CAMELCASE: Avoid CamelCase: #176: FILE: drivers/net/r8169/r8169_phy.c:374: +rtl_wait_phy_ups_resume(struct rtl_hw *hw, u16 PhyState) ERROR:CODE_INDENT: code indent should use tabs where possible #275: FILE: drivers/net/r8169/r8169_phy.c:473: +^I MII_ADVERTISE) & ~(ADVERTISE_10HALF | ADVERTISE_10FULL | ADVERTISE_100HALF |$ ERROR:CODE_INDENT: code indent should use tabs where possible #276: FILE: drivers/net/r8169/r8169_phy.c:474: +^I ADVERTISE_100FULL));$ ERROR:CODE_INDENT: code indent should use tabs where possible #278: FILE: drivers/net/r8169/r8169_phy.c:476: +^I MII_CTRL1000) & ~(ADVERTISE_1000HALF | ADVERTISE_1000FULL));$ ERROR:CODE_INDENT: code indent should use tabs where possible #280: FILE: drivers/net/r8169/r8169_phy.c:478: +^I 0xA5D4) & ~(RTK_ADVERTISE_2500FULL | RTK_ADVERTISE_5000FULL));$ WARNING:LONG_LINE: line length of 101 exceeds 100 columns #302: FILE: drivers/net/r8169/r8169_phy.c:500: + PMD_INIT_LOG(NOTICE, "PHY watch dog not clear, value = 0x%x", phy_reg_value); ERROR:CODE_INDENT: code indent should use tabs where possible #309: FILE: drivers/net/r8169/r8169_phy.c:507: +^I^I (BIT_10 | BIT_9 | BIT_8));$ CHECK:BRACES: braces {} should be used on all arms of this statement #337: FILE: drivers/net/r8169/r8169_phy.c:535: + if (hw->hw_ram_code_ver == hw->sw_ram_code_ver) { [...] + } else [...] CHECK:CAMELCASE: Avoid CamelCase: #339: FILE: drivers/net/r8169/r8169_phy.c:537: + hw->HwHasWrRamCodeToMicroP = TRUE; CHECK:BRACES: Unbalanced braces around else statement #340: FILE: drivers/net/r8169/r8169_phy.c:538: + } else CHECK:CAMELCASE: Avoid CamelCase: #386: FILE: drivers/net/r8169/r8169_phy.c:584: + if (hw->NotWrRamCodeToMicroP == TRUE) CHECK:BOOL_COMPARISON: Using comparison to TRUE is error prone #386: FILE: drivers/net/r8169/r8169_phy.c:584: + if (hw->NotWrRamCodeToMicroP == TRUE) CHECK:USLEEP_RANGE: usleep_range is preferred over udelay; see Documentation/timers/timers-howto.rst #423: FILE: drivers/net/r8169/r8169_phy.c:621: + udelay(100); WARNING:SPACE_BEFORE_TAB: please, no space before tabs #594: FILE: drivers/net/r8169/r8169_phy.h:23: +#define MII_LPA ^I^I0x05^I/* Link partner ability reg */$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #604: FILE: drivers/net/r8169/r8169_phy.h:33: +#define MII_RERRCOUNTER ^I0x15^I/* Receive error counter */$ WARNING:TYPO_SPELLING: 'asymetric' may be misspelled - perhaps 'asymmetric'? #657: FILE: drivers/net/r8169/r8169_phy.h:86: +#define ADVERTISE_PAUSE_ASYM 0x0800 /* Try for asymetric pause */ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #660: FILE: drivers/net/r8169/r8169_phy.h:89: +#define ADVERTISE_LPACK ^I0x4000^I/* Ack link partners response */$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #661: FILE: drivers/net/r8169/r8169_phy.h:90: +#define ADVERTISE_NPAGE ^I0x8000^I/* Next page bit */$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #669: FILE: drivers/net/r8169/r8169_phy.h:98: +#define RTK_ADVERTISE_10000FULL ^I0x1000$ total: 5 errors, 7 warnings, 9 checks, 600 lines checked