|WARNING| pw144528 [PATCH v2 38/47] net/bnxt: tf_ulp: inline utility functions and use likely/unlikely

automatic DPDK test reports
 help / color / mirror / Atom feed

From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Sriharsha Basavapatna <sriharsha.basavapatna@broadcom.com>
Subject: |WARNING| pw144528 [PATCH v2 38/47] net/bnxt: tf_ulp: inline utility functions and use likely/unlikely
Date: Sat, 28 Sep 2024 00:23:51 +0200 (CEST)	[thread overview]
Message-ID: <20240927222351.9BE64121D9E@dpdk.org> (raw)
In-Reply-To: <20240927180829.525350-39-sriharsha.basavapatna@broadcom.com>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/144528

_coding style issues_


WARNING:TYPO_SPELLING: 'hsi' may be misspelled - perhaps 'his'?
#2632: FILE: drivers/net/bnxt/tf_ulp/bnxt_ulp_utils.h:20:
+#include "hsi_struct_def_dpdk.h"

WARNING:TYPO_SPELLING: 'firmwware' may be misspelled - perhaps 'firmware'?
#3545: FILE: drivers/net/bnxt/tf_ulp/bnxt_ulp_utils.h:933:
+ * the firmwware.

WARNING:TYPO_SPELLING: 'appplication' may be misspelled - perhaps 'application'?
#3565: FILE: drivers/net/bnxt/tf_ulp/bnxt_ulp_utils.h:953:
+ * Application to poll to get the appplication hot upgrade state from

WARNING:TYPO_SPELLING: 'firmwware' may be misspelled - perhaps 'firmware'?
#3566: FILE: drivers/net/bnxt/tf_ulp/bnxt_ulp_utils.h:954:
+ * the firmwware.

WARNING:TYPO_SPELLING: 'appplication' may be misspelled - perhaps 'application'?
#3578: FILE: drivers/net/bnxt/tf_ulp/bnxt_ulp_utils.h:966:
+ * Application to poll to get the appplication count from

WARNING:TYPO_SPELLING: 'firmwware' may be misspelled - perhaps 'firmware'?
#3579: FILE: drivers/net/bnxt/tf_ulp/bnxt_ulp_utils.h:967:
+ * the firmwware.

WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'?
#3984: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper.c:640:
+		if (unlikely(ulp_regfile_read(parms->regfile, tbl->pri_operand,

WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'?
#4025: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper.c:722:
+		if (unlikely(ulp_regfile_write(parms->regfile,

WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'?
#4043: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper.c:768:
+	if (unlikely(ulp_regfile_write(parms->regfile, idx, tfp_cpu_to_be_64(id)))) {

WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'?
#4062: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper.c:806:
+		if (unlikely(ulp_port_db_parent_mac_addr_get(parms->ulp_ctx, port_id,

WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'?
#4071: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper.c:813:
+		if (unlikely(ulp_port_db_drv_mac_addr_get(parms->ulp_ctx, port_id,

WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'?
#4080: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper.c:820:
+		if (unlikely(ulp_port_db_parent_vnic_get(parms->ulp_ctx, port_id,

WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'?
#4089: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper.c:827:
+		if (unlikely(ulp_port_db_port_is_pf_get(parms->ulp_ctx, port_id,

WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'?
#4098: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper.c:834:
+		if (unlikely(ulp_port_db_port_meta_data_get(parms->ulp_ctx, port_id,

WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'?
#4107: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper.c:841:
+		if (unlikely(ulp_port_db_port_table_scope_get(parms->ulp_ctx,

WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'?
#4115: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper.c:848:
+		if (unlikely(ulp_port_db_port_vf_fid_get(parms->ulp_ctx, port_id, val))) {

WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'?
#4151: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper.c:922:
+		if (unlikely(ulp_regfile_read(parms->regfile, idx, &lregval)) ||

WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'?
#4228: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper.c:994:
+		if (unlikely(ulp_mapper_glb_resource_read(parms->mapper_data,

WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'?
#4248: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper.c:1015:
+		if (unlikely(ulp_mapper_glb_field_tbl_get(parms, idx, &bit))) {

WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'?
#4293: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper.c:1061:
+		if (unlikely(ULP_BITMAP_ISSET(parms->hdr_bitmap->bits, lregval))) {

WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'?
#4310: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper.c:1075:
+		if (unlikely(ULP_BITMAP_ISSET(parms->act_bitmap->bits, lregval))) {

WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'?
#4328: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper.c:1090:
+		if (unlikely(ulp_mapper_glb_field_tbl_get(parms, idx, &bit))) {

WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'?
#4334: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper.c:1095:
+		if (unlikely(ULP_INDEX_BITMAP_GET(parms->fld_bitmap->bits, bit))) {

WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'?
#4369: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper.c:1124:
+		if (unlikely(ulp_mapper_field_port_db_process(parms, port_id, idx,

WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'?
#4434: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper.c:1197:
+		if (unlikely(ulp_mapper_cond_opc_list_process(parms, &info, &cond_res))) {

WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'?
#4451: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper.c:1216:
+		if (unlikely(ULP_BITMAP_ISSET(parms->cf_bitmap, lregval))) {

WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'?
#4619: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper.c:1656:
+		if (unlikely(ulp_mapper_field_src_process(parms, fld->field_src1,

WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'?
#4632: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper.c:1681:
+				if (unlikely(ulp_mapper_key_recipe_field_opc_next(parms,

WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'?
#4648: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper.c:1704:
+				if (unlikely(ulp_mapper_key_recipe_field_opc_next(parms,

WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'?
#4666: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper.c:1781:
+		if (unlikely(ulp_regfile_read(parms->regfile,

WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'?
#4764: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper.c:1977:
+		if (unlikely(ulp_mapper_field_src_process(parms, fld->field_src1,

WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'?
#4787: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper.c:2004:
+				if (unlikely(ulp_mapper_field_opc_next(parms, dir,

WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'?
#4802: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper.c:2021:
+				if (unlikely(ulp_mapper_field_opc_next(parms, dir,

WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'?
#4817: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper.c:2039:
+		if (unlikely(ulp_mapper_field_src_process(parms, fld->field_src2,

WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'?
#4840: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper.c:2057:
+		if (unlikely(ulp_mapper_field_src_process(parms, fld->field_src3,

WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'?
#4931: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper.c:2196:
+					   parms->device_params->encap_byte_order))) {

WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'?
#4996: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper.c:2308:
+	if (unlikely(ulp_regfile_read(parms->regfile,

WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'?
#5036: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper.c:2353:
+	if (unlikely(ulp_regfile_read(parms->regfile,

WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'?
#5066: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper.c:2394:
+		if (unlikely(ulp_mapper_ident_process(parms, tbl,

WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'?
#5153: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper.c:2594:
+				   parms->device_params->key_byte_order))) {

WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'?
#5536: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper.c:3206:
+		if (unlikely(ulp_regfile_read(parms->regfile, operand, &regval))) {

WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'?
#5545: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper.c:3220:
+		if (unlikely(bnxt_ulp_cntxt_mem_type_get(parms->ulp_ctx, &mtype))) {

WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'?
#5553: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper.c:3227:
+		if (unlikely(bnxt_ulp_cntxt_mem_type_get(parms->ulp_ctx, &mtype))) {

WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'?
#5631: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper.c:3353:
+		if (unlikely(ulp_regfile_read(parms->regfile, func_opr, &regval))) {

WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'?
#5641: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper.c:3361:
+		if (unlikely(ulp_mapper_glb_resource_read(parms->mapper_data, dir,

WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'?
#5672: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper.c:3453:
+	if (unlikely(ulp_mapper_field_src_process(parms, fld->field_src1,

WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'?
#5701: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper.c:3477:
+			if (unlikely(ulp_mapper_field_src_process(parms, fld->field_src2,

WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'?
#5731: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper.c:3504:
+			if (unlikely(ulp_mapper_field_src_process(parms, fld->field_src3,

WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'?
#5763: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper.c:3687:
+	if (unlikely(ulp_regfile_write(parms->regfile, func_info->func_dst_opr,

WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'?
#5811: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper.c:3927:
+			if (unlikely(ulp_regfile_read(parms->regfile,

WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'?
#5824: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper.c:3941:
+		if (unlikely(ulp_regfile_read(parms->regfile,

WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'?
#5885: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper.c:4054:
+		if (unlikely(ulp_mapper_func_info_process(parms, tbl))) {

WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'?
#5935: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper.c:4165:
+			if (unlikely(ulp_regfile_read(parms->regfile, rf_idx,

WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'?
#5981: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper.c:4392:
+	if (unlikely(!ulp_ctx || !parms))

WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'?
#5990: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper.c:4401:
+	if (unlikely(bnxt_ulp_cntxt_dev_id_get(ulp_ctx, &parms->dev_id))) {

WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'?
#5995: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper.c:4405:
+	if (unlikely(bnxt_ulp_cntxt_fid_get(ulp_ctx, &parms->fw_fid))) {

WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'?
#6003: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper.c:4412:
+	if (unlikely(!parms->device_params)) {

WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'?
#6012: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper.c:4424:
+	if (unlikely(!parms->mapper_data)) {

WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'?
#6019: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper.c:4430:
+	if (unlikely(ulp_regfile_init(parms->regfile))) {

WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'?
#6266: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper_tfc.c:204:
+	if (unlikely(bnxt_ulp_cntxt_fid_get(parms->ulp_ctx, &fw_fid))) {

WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'?
#6374: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper_tfc.c:321:
+		if (unlikely(ulp_regfile_write(parms->regfile, tbl->tbl_operand,

WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'?
#6532: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper_tfc.c:775:
+	if (unlikely(bnxt_ulp_cntxt_fid_get(parms->ulp_ctx, &fw_fid))) {

WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'?
#6543: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper_tfc.c:785:
+				   parms->device_params->result_byte_order))) {

WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'?
#6564: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper_tfc.c:830:
+		if (unlikely(ulp_mapper_glb_resource_read(parms->mapper_data,

WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'?
#6577: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper_tfc.c:850:
+		if (unlikely(ulp_regfile_read(parms->regfile,

WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'?
#6607: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper_tfc.c:898:
+		if (unlikely(ulp_regfile_read(parms->regfile,

WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'?
#6709: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper_tfc.c:1098:
+				   parms->device_params->result_byte_order))) {

WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'?
#6730: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper_tfc.c:1143:
+		if (unlikely(ulp_mapper_glb_resource_read(parms->mapper_data,

WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'?
#6743: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper_tfc.c:1163:
+		if (unlikely(ulp_regfile_read(parms->regfile,

WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'?
#6753: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper_tfc.c:1184:
+		if (unlikely(ulp_regfile_read(parms->regfile,

WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'?
#6878: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper_tfc.c:1441:
+	if (unlikely(bnxt_ulp_cntxt_fid_get(parms->ulp_ctx, &fw_fid))) {

WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'?
#6894: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper_tfc.c:1454:
+				   parms->device_params->result_byte_order))) {

WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'?
#6911: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper_tfc.c:1472:
+		if (unlikely(ulp_regfile_read(parms->regfile, tbl->tbl_operand, &idx))) {

WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'?
#6922: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper_tfc.c:1485:
+					   parms->device_params->result_byte_order))) {

total: 0 errors, 74 warnings, 0 checks, 7687 lines checked

          parent reply	other threads:[~2024-09-27 22:23 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <20240927180829.525350-39-sriharsha.basavapatna@broadcom.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240927222351.9BE64121D9E@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=sriharsha.basavapatna@broadcom.com \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).