automatic DPDK test reports
 help / color / mirror / Atom feed
From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Nithin Dabilpuram <ndabilpuram@marvell.com>
Subject: |WARNING| pw144851 [PATCH v3 14/18] net/cnxk: support Rx burst vector for cn20k
Date: Tue,  1 Oct 2024 14:45:42 +0200 (CEST)	[thread overview]
Message-ID: <20241001124542.6B7CA121D9E@dpdk.org> (raw)
In-Reply-To: <20241001124053.3774325-15-ndabilpuram@marvell.com>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/144851

_coding style issues_


CHECK:MACRO_ARG_REUSE: Macro argument reuse '_mbuf' - possible side-effects?
#123: FILE: drivers/net/cnxk/cn20k_rx.h:447:
+#define NIX_PUSH_META_TO_FREE(_mbuf, _laddr, _loff_p)                                              \
+	do {                                                                                       \
+		*(uint64_t *)((_laddr) + (*(_loff_p) << 3)) = (uint64_t)_mbuf;                     \
+		*(_loff_p) = *(_loff_p) + 1;                                                       \
+		/* Mark meta mbuf as put */                                                        \
+		RTE_MEMPOOL_CHECK_COOKIES(_mbuf->pool, (void **)&_mbuf, 1, 0);                     \
+	} while (0)

CHECK:MACRO_ARG_REUSE: Macro argument reuse '_loff_p' - possible side-effects?
#123: FILE: drivers/net/cnxk/cn20k_rx.h:447:
+#define NIX_PUSH_META_TO_FREE(_mbuf, _laddr, _loff_p)                                              \
+	do {                                                                                       \
+		*(uint64_t *)((_laddr) + (*(_loff_p) << 3)) = (uint64_t)_mbuf;                     \
+		*(_loff_p) = *(_loff_p) + 1;                                                       \
+		/* Mark meta mbuf as put */                                                        \
+		RTE_MEMPOOL_CHECK_COOKIES(_mbuf->pool, (void **)&_mbuf, 1, 0);                     \
+	} while (0)

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#223: FILE: drivers/net/cnxk/cn20k_rx.h:547:
+					rte_prefetch0(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#225: FILE: drivers/net/cnxk/cn20k_rx.h:549:
+					rte_prefetch0(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#227: FILE: drivers/net/cnxk/cn20k_rx.h:551:
+					rte_prefetch0(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#229: FILE: drivers/net/cnxk/cn20k_rx.h:553:
+					rte_prefetch0(

total: 0 errors, 0 warnings, 6 checks, 475 lines checked

           reply	other threads:[~2024-10-01 12:45 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <20241001124053.3774325-15-ndabilpuram@marvell.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241001124542.6B7CA121D9E@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=ndabilpuram@marvell.com \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).