From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: David Marchand <david.marchand@redhat.com>
Subject: |WARNING| pw144933 [PATCH 2/2] ethdev: fix race on ports for telemetry commands
Date: Wed, 2 Oct 2024 17:58:24 +0200 (CEST) [thread overview]
Message-ID: <20241002155824.4267212074B@dpdk.org> (raw)
In-Reply-To: <20241002155709.2522273-3-david.marchand@redhat.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/144933
_coding style issues_
ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#109: FILE: lib/ethdev/rte_ethdev_telemetry.c:1407:
+#define ETHDEV_TELEMETRY_HANDLERS \
+ ETHDEV_TELEMETRY_HANDLER("/ethdev/list", eth_dev_handle_port_list, \
+ "Returns list of available ethdev ports. Takes no parameters") \
+ ETHDEV_TELEMETRY_HANDLER("/ethdev/stats", eth_dev_handle_port_stats, \
+ "Returns the common stats for a port. Parameters: int port_id") \
+ ETHDEV_TELEMETRY_HANDLER("/ethdev/xstats", eth_dev_handle_port_xstats, \
+ "Returns the extended stats for a port. Parameters: int port_id,hide_zero=true|false(Optional for indicates hide zero xstats)") \
+ ETHDEV_TELEMETRY_HANDLER("/ethdev/dump_priv", eth_dev_handle_port_dump_priv, \
+ "Returns dump private information for a port. Parameters: int port_id") \
+ ETHDEV_TELEMETRY_HANDLER("/ethdev/link_status", eth_dev_handle_port_link_status, \
+ "Returns the link status for a port. Parameters: int port_id") \
+ ETHDEV_TELEMETRY_HANDLER("/ethdev/info", eth_dev_handle_port_info, \
+ "Returns the device info for a port. Parameters: int port_id") \
+ ETHDEV_TELEMETRY_HANDLER("/ethdev/module_eeprom", eth_dev_handle_port_module_eeprom, \
+ "Returns module EEPROM info with SFF specs. Parameters: int port_id") \
+ ETHDEV_TELEMETRY_HANDLER("/ethdev/macs", eth_dev_handle_port_macs, \
+ "Returns the MAC addresses for a port. Parameters: int port_id") \
+ ETHDEV_TELEMETRY_HANDLER("/ethdev/flow_ctrl", eth_dev_handle_port_flow_ctrl, \
+ "Returns flow ctrl info for a port. Parameters: int port_id") \
+ ETHDEV_TELEMETRY_HANDLER("/ethdev/rx_queue", eth_dev_handle_port_rxq, \
+ "Returns Rx queue info for a port. Parameters: int port_id, int queue_id (Optional if only one queue)") \
+ ETHDEV_TELEMETRY_HANDLER("/ethdev/tx_queue", eth_dev_handle_port_txq, \
+ "Returns Tx queue info for a port. Parameters: int port_id, int queue_id (Optional if only one queue)") \
+ ETHDEV_TELEMETRY_HANDLER("/ethdev/dcb", eth_dev_handle_port_dcb, \
+ "Returns DCB info for a port. Parameters: int port_id") \
+ ETHDEV_TELEMETRY_HANDLER("/ethdev/rss_info", eth_dev_handle_port_rss_info, \
+ "Returns RSS info for a port. Parameters: int port_id") \
+ ETHDEV_TELEMETRY_HANDLER("/ethdev/fec", eth_dev_handle_port_fec, \
+ "Returns FEC info for a port. Parameters: int port_id") \
+ ETHDEV_TELEMETRY_HANDLER("/ethdev/vlan", eth_dev_handle_port_vlan, \
+ "Returns VLAN info for a port. Parameters: int port_id") \
+ ETHDEV_TELEMETRY_HANDLER("/ethdev/tm_capability", eth_dev_handle_port_tm_caps, \
+ "Returns TM Capabilities info for a port. Parameters: int port_id") \
+ ETHDEV_TELEMETRY_HANDLER("/ethdev/tm_level_capability", eth_dev_handle_port_tm_level_caps, \
+ "Returns TM Level Capabilities info for a port. Parameters: int port_id, int level_id (see tm_capability for the max)") \
+ ETHDEV_TELEMETRY_HANDLER("/ethdev/tm_node_capability", eth_dev_handle_port_tm_node_caps, \
+ "Returns TM Node Capabilities info for a port. Parameters: int port_id, int node_id (see tm_capability for the max)")
WARNING:LONG_LINE: line length of 145 exceeds 100 columns
#115: FILE: lib/ethdev/rte_ethdev_telemetry.c:1413:
+ "Returns the extended stats for a port. Parameters: int port_id,hide_zero=true|false(Optional for indicates hide zero xstats)") \
WARNING:LONG_LINE: line length of 121 exceeds 100 columns
#129: FILE: lib/ethdev/rte_ethdev_telemetry.c:1427:
+ "Returns Rx queue info for a port. Parameters: int port_id, int queue_id (Optional if only one queue)") \
WARNING:LONG_LINE: line length of 121 exceeds 100 columns
#131: FILE: lib/ethdev/rte_ethdev_telemetry.c:1429:
+ "Returns Tx queue info for a port. Parameters: int port_id, int queue_id (Optional if only one queue)") \
WARNING:LONG_LINE: line length of 137 exceeds 100 columns
#143: FILE: lib/ethdev/rte_ethdev_telemetry.c:1441:
+ "Returns TM Level Capabilities info for a port. Parameters: int port_id, int level_id (see tm_capability for the max)") \
WARNING:LONG_LINE: line length of 133 exceeds 100 columns
#145: FILE: lib/ethdev/rte_ethdev_telemetry.c:1443:
+ "Returns TM Node Capabilities info for a port. Parameters: int port_id, int node_id (see tm_capability for the max)")
WARNING:TRAILING_SEMICOLON: macros should not use a trailing semicolon
#199: FILE: lib/ethdev/rte_ethdev_telemetry.c:1460:
+#define ETHDEV_TELEMETRY_HANDLER(command, func, usage) \
+ rte_telemetry_register_cmd(command, func ## _locked, usage);
total: 1 errors, 6 warnings, 105 lines checked
next prev parent reply other threads:[~2024-10-02 15:58 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20241002155709.2522273-3-david.marchand@redhat.com>
2024-10-02 15:34 ` |SUCCESS| pw144932-144933 " qemudev
2024-10-02 15:38 ` qemudev
2024-10-02 15:58 ` checkpatch [this message]
2024-10-02 16:45 ` |SUCCESS| pw144933 " 0-day Robot
2024-10-02 17:48 ` |PENDING| pw144932-144933 [PATCH] [2/2] ethdev: fix race on ports fo dpdklab
2024-10-02 17:58 ` |SUCCESS| " dpdklab
2024-10-02 18:09 ` dpdklab
2024-10-02 18:10 ` dpdklab
2024-10-02 18:11 ` |PENDING| " dpdklab
2024-10-02 18:14 ` |SUCCESS| " dpdklab
2024-10-02 18:15 ` dpdklab
2024-10-02 18:21 ` dpdklab
2024-10-02 18:34 ` dpdklab
2024-10-02 18:41 ` dpdklab
2024-10-02 18:58 ` dpdklab
2024-10-02 18:59 ` |PENDING| " dpdklab
2024-10-02 19:02 ` |SUCCESS| " dpdklab
2024-10-02 19:07 ` dpdklab
2024-10-02 19:29 ` dpdklab
2024-10-02 20:36 ` dpdklab
2024-10-02 20:39 ` dpdklab
2024-10-02 20:51 ` dpdklab
2024-10-02 22:33 ` dpdklab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241002155824.4267212074B@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=david.marchand@redhat.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).