From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 129EC45A9D for ; Wed, 2 Oct 2024 17:58:25 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0C7454027C; Wed, 2 Oct 2024 17:58:25 +0200 (CEST) Received: from dpdk.org (dpdk.org [92.243.24.197]) by mails.dpdk.org (Postfix) with ESMTP id 55BF340268 for ; Wed, 2 Oct 2024 17:58:24 +0200 (CEST) Received: by dpdk.org (Postfix, from userid 65534) id 4267212074B; Wed, 2 Oct 2024 17:58:24 +0200 (CEST) Subject: |WARNING| pw144933 [PATCH 2/2] ethdev: fix race on ports for telemetry commands In-Reply-To: <20241002155709.2522273-3-david.marchand@redhat.com> References: <20241002155709.2522273-3-david.marchand@redhat.com> To: test-report@dpdk.org From: checkpatch@dpdk.org Cc: David Marchand Message-Id: <20241002155824.4267212074B@dpdk.org> Date: Wed, 2 Oct 2024 17:58:24 +0200 (CEST) X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/144933 _coding style issues_ ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #109: FILE: lib/ethdev/rte_ethdev_telemetry.c:1407: +#define ETHDEV_TELEMETRY_HANDLERS \ + ETHDEV_TELEMETRY_HANDLER("/ethdev/list", eth_dev_handle_port_list, \ + "Returns list of available ethdev ports. Takes no parameters") \ + ETHDEV_TELEMETRY_HANDLER("/ethdev/stats", eth_dev_handle_port_stats, \ + "Returns the common stats for a port. Parameters: int port_id") \ + ETHDEV_TELEMETRY_HANDLER("/ethdev/xstats", eth_dev_handle_port_xstats, \ + "Returns the extended stats for a port. Parameters: int port_id,hide_zero=true|false(Optional for indicates hide zero xstats)") \ + ETHDEV_TELEMETRY_HANDLER("/ethdev/dump_priv", eth_dev_handle_port_dump_priv, \ + "Returns dump private information for a port. Parameters: int port_id") \ + ETHDEV_TELEMETRY_HANDLER("/ethdev/link_status", eth_dev_handle_port_link_status, \ + "Returns the link status for a port. Parameters: int port_id") \ + ETHDEV_TELEMETRY_HANDLER("/ethdev/info", eth_dev_handle_port_info, \ + "Returns the device info for a port. Parameters: int port_id") \ + ETHDEV_TELEMETRY_HANDLER("/ethdev/module_eeprom", eth_dev_handle_port_module_eeprom, \ + "Returns module EEPROM info with SFF specs. Parameters: int port_id") \ + ETHDEV_TELEMETRY_HANDLER("/ethdev/macs", eth_dev_handle_port_macs, \ + "Returns the MAC addresses for a port. Parameters: int port_id") \ + ETHDEV_TELEMETRY_HANDLER("/ethdev/flow_ctrl", eth_dev_handle_port_flow_ctrl, \ + "Returns flow ctrl info for a port. Parameters: int port_id") \ + ETHDEV_TELEMETRY_HANDLER("/ethdev/rx_queue", eth_dev_handle_port_rxq, \ + "Returns Rx queue info for a port. Parameters: int port_id, int queue_id (Optional if only one queue)") \ + ETHDEV_TELEMETRY_HANDLER("/ethdev/tx_queue", eth_dev_handle_port_txq, \ + "Returns Tx queue info for a port. Parameters: int port_id, int queue_id (Optional if only one queue)") \ + ETHDEV_TELEMETRY_HANDLER("/ethdev/dcb", eth_dev_handle_port_dcb, \ + "Returns DCB info for a port. Parameters: int port_id") \ + ETHDEV_TELEMETRY_HANDLER("/ethdev/rss_info", eth_dev_handle_port_rss_info, \ + "Returns RSS info for a port. Parameters: int port_id") \ + ETHDEV_TELEMETRY_HANDLER("/ethdev/fec", eth_dev_handle_port_fec, \ + "Returns FEC info for a port. Parameters: int port_id") \ + ETHDEV_TELEMETRY_HANDLER("/ethdev/vlan", eth_dev_handle_port_vlan, \ + "Returns VLAN info for a port. Parameters: int port_id") \ + ETHDEV_TELEMETRY_HANDLER("/ethdev/tm_capability", eth_dev_handle_port_tm_caps, \ + "Returns TM Capabilities info for a port. Parameters: int port_id") \ + ETHDEV_TELEMETRY_HANDLER("/ethdev/tm_level_capability", eth_dev_handle_port_tm_level_caps, \ + "Returns TM Level Capabilities info for a port. Parameters: int port_id, int level_id (see tm_capability for the max)") \ + ETHDEV_TELEMETRY_HANDLER("/ethdev/tm_node_capability", eth_dev_handle_port_tm_node_caps, \ + "Returns TM Node Capabilities info for a port. Parameters: int port_id, int node_id (see tm_capability for the max)") WARNING:LONG_LINE: line length of 145 exceeds 100 columns #115: FILE: lib/ethdev/rte_ethdev_telemetry.c:1413: + "Returns the extended stats for a port. Parameters: int port_id,hide_zero=true|false(Optional for indicates hide zero xstats)") \ WARNING:LONG_LINE: line length of 121 exceeds 100 columns #129: FILE: lib/ethdev/rte_ethdev_telemetry.c:1427: + "Returns Rx queue info for a port. Parameters: int port_id, int queue_id (Optional if only one queue)") \ WARNING:LONG_LINE: line length of 121 exceeds 100 columns #131: FILE: lib/ethdev/rte_ethdev_telemetry.c:1429: + "Returns Tx queue info for a port. Parameters: int port_id, int queue_id (Optional if only one queue)") \ WARNING:LONG_LINE: line length of 137 exceeds 100 columns #143: FILE: lib/ethdev/rte_ethdev_telemetry.c:1441: + "Returns TM Level Capabilities info for a port. Parameters: int port_id, int level_id (see tm_capability for the max)") \ WARNING:LONG_LINE: line length of 133 exceeds 100 columns #145: FILE: lib/ethdev/rte_ethdev_telemetry.c:1443: + "Returns TM Node Capabilities info for a port. Parameters: int port_id, int node_id (see tm_capability for the max)") WARNING:TRAILING_SEMICOLON: macros should not use a trailing semicolon #199: FILE: lib/ethdev/rte_ethdev_telemetry.c:1460: +#define ETHDEV_TELEMETRY_HANDLER(command, func, usage) \ + rte_telemetry_register_cmd(command, func ## _locked, usage); total: 1 errors, 6 warnings, 105 lines checked