From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: <pbhagavatula@marvell.com>
Subject: |WARNING| pw144978 [PATCH 16/20] event/cnxk: support CN20K Tx adapter fast path
Date: Thu, 3 Oct 2024 15:24:48 +0200 (CEST) [thread overview]
Message-ID: <20241003132448.07E2812074B@dpdk.org> (raw)
In-Reply-To: <20241003132237.20193-16-pbhagavatula@marvell.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/144978
_coding style issues_
ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#131: FILE: drivers/event/cnxk/cn20k_eventdev.c:18:
+#define CN20K_SET_EVDEV_ENQ_OP(dev, enq_op, enq_ops) \
+ enq_op = enq_ops[dev->tx_offloads & (NIX_TX_OFFLOAD_MAX - 1)]
ERROR:BRACKET_SPACE: space prohibited before open square bracket '['
#143: FILE: drivers/event/cnxk/cn20k_eventdev.c:308:
+#define T(name, sz, flags) [flags] = cn20k_sso_hws_tx_adptr_enq_##name,
ERROR:BRACKET_SPACE: space prohibited before open square bracket '['
#149: FILE: drivers/event/cnxk/cn20k_eventdev.c:314:
+#define T(name, sz, flags) [flags] = cn20k_sso_hws_tx_adptr_enq_seg_##name,
WARNING:QUOTED_WHITESPACE_BEFORE_NEWLINE: unnecessary whitespace before a quoted newline
#211: FILE: drivers/event/cnxk/cn20k_tx_worker.h:35:
+ " ldxr %[val], [%[addr]]
"
WARNING:QUOTED_WHITESPACE_BEFORE_NEWLINE: unnecessary whitespace before a quoted newline
#212: FILE: drivers/event/cnxk/cn20k_tx_worker.h:36:
+ " sub %[val], %[adj], %[val]
"
WARNING:QUOTED_WHITESPACE_BEFORE_NEWLINE: unnecessary whitespace before a quoted newline
#213: FILE: drivers/event/cnxk/cn20k_tx_worker.h:37:
+ " lsl %[refill], %[val], %[shft]
"
WARNING:QUOTED_WHITESPACE_BEFORE_NEWLINE: unnecessary whitespace before a quoted newline
#214: FILE: drivers/event/cnxk/cn20k_tx_worker.h:38:
+ " sub %[refill], %[refill], %[val]
"
WARNING:QUOTED_WHITESPACE_BEFORE_NEWLINE: unnecessary whitespace before a quoted newline
#215: FILE: drivers/event/cnxk/cn20k_tx_worker.h:39:
+ " cmp %[refill], #0x0
"
WARNING:QUOTED_WHITESPACE_BEFORE_NEWLINE: unnecessary whitespace before a quoted newline
#216: FILE: drivers/event/cnxk/cn20k_tx_worker.h:40:
+ " b.gt .Ldne%=
"
WARNING:QUOTED_WHITESPACE_BEFORE_NEWLINE: unnecessary whitespace before a quoted newline
#217: FILE: drivers/event/cnxk/cn20k_tx_worker.h:41:
+ " sevl
"
WARNING:QUOTED_WHITESPACE_BEFORE_NEWLINE: unnecessary whitespace before a quoted newline
#218: FILE: drivers/event/cnxk/cn20k_tx_worker.h:42:
+ ".Lrty%=: wfe
"
WARNING:QUOTED_WHITESPACE_BEFORE_NEWLINE: unnecessary whitespace before a quoted newline
#219: FILE: drivers/event/cnxk/cn20k_tx_worker.h:43:
+ " ldxr %[val], [%[addr]]
"
WARNING:QUOTED_WHITESPACE_BEFORE_NEWLINE: unnecessary whitespace before a quoted newline
#220: FILE: drivers/event/cnxk/cn20k_tx_worker.h:44:
+ " sub %[val], %[adj], %[val]
"
WARNING:QUOTED_WHITESPACE_BEFORE_NEWLINE: unnecessary whitespace before a quoted newline
#221: FILE: drivers/event/cnxk/cn20k_tx_worker.h:45:
+ " lsl %[refill], %[val], %[shft]
"
WARNING:QUOTED_WHITESPACE_BEFORE_NEWLINE: unnecessary whitespace before a quoted newline
#222: FILE: drivers/event/cnxk/cn20k_tx_worker.h:46:
+ " sub %[refill], %[refill], %[val]
"
WARNING:QUOTED_WHITESPACE_BEFORE_NEWLINE: unnecessary whitespace before a quoted newline
#223: FILE: drivers/event/cnxk/cn20k_tx_worker.h:47:
+ " cmp %[refill], #0x0
"
WARNING:QUOTED_WHITESPACE_BEFORE_NEWLINE: unnecessary whitespace before a quoted newline
#224: FILE: drivers/event/cnxk/cn20k_tx_worker.h:48:
+ " b.le .Lrty%=
"
WARNING:QUOTED_WHITESPACE_BEFORE_NEWLINE: unnecessary whitespace before a quoted newline
#225: FILE: drivers/event/cnxk/cn20k_tx_worker.h:49:
+ ".Ldne%=:
"
WARNING:TRAILING_SEMICOLON: macros should not use a trailing semicolon
#331: FILE: drivers/event/cnxk/cn20k_tx_worker.h:155:
+#define T(name, sz, flags) \
+ uint16_t __rte_hot cn20k_sso_hws_tx_adptr_enq_##name(void *port, struct rte_event ev[], \
+ uint16_t nb_events); \
+ uint16_t __rte_hot cn20k_sso_hws_tx_adptr_enq_seg_##name( \
+ void *port, struct rte_event ev[], uint16_t nb_events);
WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#340: FILE: drivers/event/cnxk/cn20k_tx_worker.h:164:
+#define SSO_TX(fn, sz, flags) \
+ uint16_t __rte_hot fn(void *port, struct rte_event ev[], uint16_t nb_events) \
+ { \
+ struct cn20k_sso_hws *ws = port; \
+ uint64_t cmd[sz]; \
+ RTE_SET_USED(nb_events); \
+ return cn20k_sso_hws_event_tx(ws, &ev[0], cmd, \
+ (const uint64_t *)ws->tx_adptr_data, flags); \
+ }
WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#350: FILE: drivers/event/cnxk/cn20k_tx_worker.h:174:
+#define SSO_TX_SEG(fn, sz, flags) \
+ uint16_t __rte_hot fn(void *port, struct rte_event ev[], uint16_t nb_events) \
+ { \
+ uint64_t cmd[(sz) + CNXK_NIX_TX_MSEG_SG_DWORDS - 2]; \
+ struct cn20k_sso_hws *ws = port; \
+ RTE_SET_USED(nb_events); \
+ return cn20k_sso_hws_event_tx(ws, &ev[0], cmd, \
+ (const uint64_t *)ws->tx_adptr_data, \
+ (flags) | NIX_TX_MULTI_SEG_F); \
+ }
total: 3 errors, 18 warnings, 596 lines checked
Warning in drivers/event/cnxk/cn20k_tx_worker.h:
Using __atomic_xxx/__ATOMIC_XXX built-ins, prefer rte_atomic_xxx/rte_memory_order_xxx
parent reply other threads:[~2024-10-03 13:24 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20241003132237.20193-16-pbhagavatula@marvell.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241003132448.07E2812074B@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=pbhagavatula@marvell.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).