From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E7BB245AA0 for ; Thu, 3 Oct 2024 15:24:49 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CD85C4065D; Thu, 3 Oct 2024 15:24:49 +0200 (CEST) Received: from dpdk.org (dpdk.org [92.243.24.197]) by mails.dpdk.org (Postfix) with ESMTP id 1F40040656 for ; Thu, 3 Oct 2024 15:24:48 +0200 (CEST) Received: by dpdk.org (Postfix, from userid 65534) id 07E2812074B; Thu, 3 Oct 2024 15:24:48 +0200 (CEST) Subject: |WARNING| pw144978 [PATCH 16/20] event/cnxk: support CN20K Tx adapter fast path In-Reply-To: <20241003132237.20193-16-pbhagavatula@marvell.com> References: <20241003132237.20193-16-pbhagavatula@marvell.com> To: test-report@dpdk.org From: checkpatch@dpdk.org Cc: Message-Id: <20241003132448.07E2812074B@dpdk.org> Date: Thu, 3 Oct 2024 15:24:48 +0200 (CEST) X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/144978 _coding style issues_ ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #131: FILE: drivers/event/cnxk/cn20k_eventdev.c:18: +#define CN20K_SET_EVDEV_ENQ_OP(dev, enq_op, enq_ops) \ + enq_op = enq_ops[dev->tx_offloads & (NIX_TX_OFFLOAD_MAX - 1)] ERROR:BRACKET_SPACE: space prohibited before open square bracket '[' #143: FILE: drivers/event/cnxk/cn20k_eventdev.c:308: +#define T(name, sz, flags) [flags] = cn20k_sso_hws_tx_adptr_enq_##name, ERROR:BRACKET_SPACE: space prohibited before open square bracket '[' #149: FILE: drivers/event/cnxk/cn20k_eventdev.c:314: +#define T(name, sz, flags) [flags] = cn20k_sso_hws_tx_adptr_enq_seg_##name, WARNING:QUOTED_WHITESPACE_BEFORE_NEWLINE: unnecessary whitespace before a quoted newline #211: FILE: drivers/event/cnxk/cn20k_tx_worker.h:35: + " ldxr %[val], [%[addr]] " WARNING:QUOTED_WHITESPACE_BEFORE_NEWLINE: unnecessary whitespace before a quoted newline #212: FILE: drivers/event/cnxk/cn20k_tx_worker.h:36: + " sub %[val], %[adj], %[val] " WARNING:QUOTED_WHITESPACE_BEFORE_NEWLINE: unnecessary whitespace before a quoted newline #213: FILE: drivers/event/cnxk/cn20k_tx_worker.h:37: + " lsl %[refill], %[val], %[shft] " WARNING:QUOTED_WHITESPACE_BEFORE_NEWLINE: unnecessary whitespace before a quoted newline #214: FILE: drivers/event/cnxk/cn20k_tx_worker.h:38: + " sub %[refill], %[refill], %[val] " WARNING:QUOTED_WHITESPACE_BEFORE_NEWLINE: unnecessary whitespace before a quoted newline #215: FILE: drivers/event/cnxk/cn20k_tx_worker.h:39: + " cmp %[refill], #0x0 " WARNING:QUOTED_WHITESPACE_BEFORE_NEWLINE: unnecessary whitespace before a quoted newline #216: FILE: drivers/event/cnxk/cn20k_tx_worker.h:40: + " b.gt .Ldne%= " WARNING:QUOTED_WHITESPACE_BEFORE_NEWLINE: unnecessary whitespace before a quoted newline #217: FILE: drivers/event/cnxk/cn20k_tx_worker.h:41: + " sevl " WARNING:QUOTED_WHITESPACE_BEFORE_NEWLINE: unnecessary whitespace before a quoted newline #218: FILE: drivers/event/cnxk/cn20k_tx_worker.h:42: + ".Lrty%=: wfe " WARNING:QUOTED_WHITESPACE_BEFORE_NEWLINE: unnecessary whitespace before a quoted newline #219: FILE: drivers/event/cnxk/cn20k_tx_worker.h:43: + " ldxr %[val], [%[addr]] " WARNING:QUOTED_WHITESPACE_BEFORE_NEWLINE: unnecessary whitespace before a quoted newline #220: FILE: drivers/event/cnxk/cn20k_tx_worker.h:44: + " sub %[val], %[adj], %[val] " WARNING:QUOTED_WHITESPACE_BEFORE_NEWLINE: unnecessary whitespace before a quoted newline #221: FILE: drivers/event/cnxk/cn20k_tx_worker.h:45: + " lsl %[refill], %[val], %[shft] " WARNING:QUOTED_WHITESPACE_BEFORE_NEWLINE: unnecessary whitespace before a quoted newline #222: FILE: drivers/event/cnxk/cn20k_tx_worker.h:46: + " sub %[refill], %[refill], %[val] " WARNING:QUOTED_WHITESPACE_BEFORE_NEWLINE: unnecessary whitespace before a quoted newline #223: FILE: drivers/event/cnxk/cn20k_tx_worker.h:47: + " cmp %[refill], #0x0 " WARNING:QUOTED_WHITESPACE_BEFORE_NEWLINE: unnecessary whitespace before a quoted newline #224: FILE: drivers/event/cnxk/cn20k_tx_worker.h:48: + " b.le .Lrty%= " WARNING:QUOTED_WHITESPACE_BEFORE_NEWLINE: unnecessary whitespace before a quoted newline #225: FILE: drivers/event/cnxk/cn20k_tx_worker.h:49: + ".Ldne%=: " WARNING:TRAILING_SEMICOLON: macros should not use a trailing semicolon #331: FILE: drivers/event/cnxk/cn20k_tx_worker.h:155: +#define T(name, sz, flags) \ + uint16_t __rte_hot cn20k_sso_hws_tx_adptr_enq_##name(void *port, struct rte_event ev[], \ + uint16_t nb_events); \ + uint16_t __rte_hot cn20k_sso_hws_tx_adptr_enq_seg_##name( \ + void *port, struct rte_event ev[], uint16_t nb_events); WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided #340: FILE: drivers/event/cnxk/cn20k_tx_worker.h:164: +#define SSO_TX(fn, sz, flags) \ + uint16_t __rte_hot fn(void *port, struct rte_event ev[], uint16_t nb_events) \ + { \ + struct cn20k_sso_hws *ws = port; \ + uint64_t cmd[sz]; \ + RTE_SET_USED(nb_events); \ + return cn20k_sso_hws_event_tx(ws, &ev[0], cmd, \ + (const uint64_t *)ws->tx_adptr_data, flags); \ + } WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided #350: FILE: drivers/event/cnxk/cn20k_tx_worker.h:174: +#define SSO_TX_SEG(fn, sz, flags) \ + uint16_t __rte_hot fn(void *port, struct rte_event ev[], uint16_t nb_events) \ + { \ + uint64_t cmd[(sz) + CNXK_NIX_TX_MSEG_SG_DWORDS - 2]; \ + struct cn20k_sso_hws *ws = port; \ + RTE_SET_USED(nb_events); \ + return cn20k_sso_hws_event_tx(ws, &ev[0], cmd, \ + (const uint64_t *)ws->tx_adptr_data, \ + (flags) | NIX_TX_MULTI_SEG_F); \ + } total: 3 errors, 18 warnings, 596 lines checked Warning in drivers/event/cnxk/cn20k_tx_worker.h: Using __atomic_xxx/__ATOMIC_XXX built-ins, prefer rte_atomic_xxx/rte_memory_order_xxx