From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1F63645B3C for ; Tue, 15 Oct 2024 05:10:51 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 085C84068E; Tue, 15 Oct 2024 05:10:51 +0200 (CEST) Received: from dpdk.org (dpdk.org [92.243.24.197]) by mails.dpdk.org (Postfix) with ESMTP id AA4D040662 for ; Tue, 15 Oct 2024 05:10:48 +0200 (CEST) Received: by dpdk.org (Postfix, from userid 65534) id 8D62E120757; Tue, 15 Oct 2024 05:10:48 +0200 (CEST) Subject: |WARNING| pw145936 [PATCH v1 06/18] net/r8169: add phy registers access routines In-Reply-To: <20241015030928.70642-7-howard_wang@realsil.com.cn> References: <20241015030928.70642-7-howard_wang@realsil.com.cn> To: test-report@dpdk.org From: checkpatch@dpdk.org Cc: Howard Wang Message-Id: <20241015031048.8D62E120757@dpdk.org> Date: Tue, 15 Oct 2024 05:10:48 +0200 (CEST) X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/145936 _coding style issues_ WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one CHECK:CAMELCASE: Avoid CamelCase: #94: FILE: drivers/net/r8169/r8169_phy.c:43: +rtl_map_phy_ocp_addr(u16 PageNum, u8 RegNum) CHECK:BRACES: braces {} should be used on all arms of this statement #110: FILE: drivers/net/r8169/r8169_phy.c:59: + if (ocp_reg_num < 16) [...] + else { [...] CHECK:BRACES: Unbalanced braces around else statement #112: FILE: drivers/net/r8169/r8169_phy.c:61: + else { CHECK:CAMELCASE: Avoid CamelCase: #123: FILE: drivers/net/r8169/r8169_phy.c:72: +rtl_mdio_real_read_phy_ocp(struct rtl_hw *hw, u32 RegAddr) CHECK:CAMELCASE: Avoid CamelCase: #129: FILE: drivers/net/r8169/r8169_phy.c:78: + data32 <<= OCPR_Addr_Reg_shift; CHECK:CAMELCASE: Avoid CamelCase: #135: FILE: drivers/net/r8169/r8169_phy.c:84: + if (RTL_R32(hw, PHYOCP) & OCPR_Flag) CHECK:CAMELCASE: Avoid CamelCase: #138: FILE: drivers/net/r8169/r8169_phy.c:87: + value = RTL_R32(hw, PHYOCP) & OCPDR_Data_Mask; CHECK:CAMELCASE: Avoid CamelCase: #173: FILE: drivers/net/r8169/r8169_phy.c:122: + data32 |= OCPR_Write | value; ERROR:CODE_INDENT: code indent should use tabs where possible #222: FILE: drivers/net/r8169/r8169_phy.c:171: + u16 setmask)$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #222: FILE: drivers/net/r8169/r8169_phy.c:171: + u16 setmask)$ CHECK:CAMELCASE: Avoid CamelCase: #249: FILE: drivers/net/r8169/r8169_phy.c:198: + RTL_W32(hw, EPHYAR, EPHYAR_Write | ERROR:CODE_INDENT: code indent should use tabs where possible #250: FILE: drivers/net/r8169/r8169_phy.c:199: +^I (addr & EPHYAR_Reg_Mask_v2) << EPHYAR_Reg_shift |$ CHECK:CAMELCASE: Avoid CamelCase: #250: FILE: drivers/net/r8169/r8169_phy.c:199: + (addr & EPHYAR_Reg_Mask_v2) << EPHYAR_Reg_shift | CHECK:CAMELCASE: Avoid CamelCase: #250: FILE: drivers/net/r8169/r8169_phy.c:199: + (addr & EPHYAR_Reg_Mask_v2) << EPHYAR_Reg_shift | ERROR:CODE_INDENT: code indent should use tabs where possible #251: FILE: drivers/net/r8169/r8169_phy.c:200: +^I (value & EPHYAR_Data_Mask));$ CHECK:CAMELCASE: Avoid CamelCase: #251: FILE: drivers/net/r8169/r8169_phy.c:200: + (value & EPHYAR_Data_Mask)); CHECK:USLEEP_RANGE: usleep_range is preferred over udelay; see Documentation/timers/timers-howto.rst #254: FILE: drivers/net/r8169/r8169_phy.c:203: + udelay(100); CHECK:CAMELCASE: Avoid CamelCase: #257: FILE: drivers/net/r8169/r8169_phy.c:206: + if (!(RTL_R32(hw, EPHYAR) & EPHYAR_Flag)) CHECK:USLEEP_RANGE: usleep_range is preferred over udelay; see Documentation/timers/timers-howto.rst #261: FILE: drivers/net/r8169/r8169_phy.c:210: + udelay(20); CHECK:CAMELCASE: Avoid CamelCase: #270: FILE: drivers/net/r8169/r8169_phy.c:219: + RTL_W32(hw, EPHYAR, EPHYAR_Read | (addr & EPHYAR_Reg_Mask_v2) << ERROR:CODE_INDENT: code indent should use tabs where possible #271: FILE: drivers/net/r8169/r8169_phy.c:220: +^I EPHYAR_Reg_shift);$ CHECK:USLEEP_RANGE: usleep_range is preferred over udelay; see Documentation/timers/timers-howto.rst #274: FILE: drivers/net/r8169/r8169_phy.c:223: + udelay(100); CHECK:USLEEP_RANGE: usleep_range is preferred over udelay; see Documentation/timers/timers-howto.rst #283: FILE: drivers/net/r8169/r8169_phy.c:232: + udelay(20); ERROR:CODE_INDENT: code indent should use tabs where possible #290: FILE: drivers/net/r8169/r8169_phy.c:239: + u16 setmask)$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #290: FILE: drivers/net/r8169/r8169_phy.c:239: + u16 setmask)$ ERROR:CODE_INDENT: code indent should use tabs where possible #327: FILE: drivers/net/r8169/r8169_phy.h:27: + u16 clearmask, u16 setmask);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #327: FILE: drivers/net/r8169/r8169_phy.h:27: + u16 clearmask, u16 setmask);$ ERROR:CODE_INDENT: code indent should use tabs where possible #334: FILE: drivers/net/r8169/r8169_phy.h:34: + u16 setmask);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #334: FILE: drivers/net/r8169/r8169_phy.h:34: + u16 setmask);$ total: 7 errors, 5 warnings, 18 checks, 252 lines checked