From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Howard Wang <howard_wang@realsil.com.cn>
Subject: |WARNING| pw145947 [PATCH v1 17/18] net/r8169: add driver_start and driver_stop
Date: Tue, 15 Oct 2024 05:13:12 +0200 (CEST) [thread overview]
Message-ID: <20241015031312.7FEBF120757@dpdk.org> (raw)
In-Reply-To: <20241015030928.70642-18-howard_wang@realsil.com.cn>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/145947
_coding style issues_
CHECK:USLEEP_RANGE: usleep_range is preferred over udelay; see Documentation/timers/timers-howto.rst
#160: FILE: drivers/net/r8169/r8169_dash.c:111:
+ udelay(50);
ERROR:CODE_INDENT: code indent should use tabs where possible
#166: FILE: drivers/net/r8169/r8169_dash.c:117:
+^I ISRIMR_DASH_TYPE2_TX_DISABLE_IDLE);$
WARNING:CONSTANT_COMPARISON: Comparisons should place the constant on the right side of the test
#208: FILE: drivers/net/r8169/r8169_dash.c:159:
+ if (FALSE == HW_DASH_SUPPORT_TYPE_4(hw))
CHECK:BOOL_COMPARISON: Using comparison to FALSE is error prone
#208: FILE: drivers/net/r8169/r8169_dash.c:159:
+ if (FALSE == HW_DASH_SUPPORT_TYPE_4(hw))
CHECK:CAMELCASE: Avoid CamelCase: <HwSuppDashVer>
#219: FILE: drivers/net/r8169/r8169_dash.c:170:
+ switch (hw->HwSuppDashVer) {
CHECK:CAMELCASE: Avoid CamelCase: <AllowAccessDashOcp>
#258: FILE: drivers/net/r8169/r8169_dash.c:209:
+ if (!hw->AllowAccessDashOcp)
CHECK:MACRO_ARG_REUSE: Macro argument reuse '_M' - possible side-effects?
#289: FILE: drivers/net/r8169/r8169_dash.h:22:
+#define HW_DASH_SUPPORT_CMAC(_M) (HW_DASH_SUPPORT_TYPE_2(_M) || HW_DASH_SUPPORT_TYPE_3(_M))
total: 1 errors, 1 warnings, 5 checks, 248 lines checked
parent reply other threads:[~2024-10-15 3:13 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20241015030928.70642-18-howard_wang@realsil.com.cn>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241015031312.7FEBF120757@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=howard_wang@realsil.com.cn \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).