|WARNING| pw145947 [PATCH v1 17/18] net/r8169: add driver_start and driver_stop

|WARNING| pw145947 [PATCH v1 17/18] net/r8169: add driver_start and driver_stop

[checkpatch]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/145947

_coding style issues_


CHECK:USLEEP_RANGE: usleep_range is preferred over udelay; see Documentation/timers/timers-howto.rst
#160: FILE: drivers/net/r8169/r8169_dash.c:111:
+		udelay(50);

ERROR:CODE_INDENT: code indent should use tabs where possible
#166: FILE: drivers/net/r8169/r8169_dash.c:117:
+^I            ISRIMR_DASH_TYPE2_TX_DISABLE_IDLE);$

WARNING:CONSTANT_COMPARISON: Comparisons should place the constant on the right side of the test
#208: FILE: drivers/net/r8169/r8169_dash.c:159:
+	if (FALSE == HW_DASH_SUPPORT_TYPE_4(hw))

CHECK:BOOL_COMPARISON: Using comparison to FALSE is error prone
#208: FILE: drivers/net/r8169/r8169_dash.c:159:
+	if (FALSE == HW_DASH_SUPPORT_TYPE_4(hw))

CHECK:CAMELCASE: Avoid CamelCase: <HwSuppDashVer>
#219: FILE: drivers/net/r8169/r8169_dash.c:170:
+	switch (hw->HwSuppDashVer) {

CHECK:CAMELCASE: Avoid CamelCase: <AllowAccessDashOcp>
#258: FILE: drivers/net/r8169/r8169_dash.c:209:
+	if (!hw->AllowAccessDashOcp)

CHECK:MACRO_ARG_REUSE: Macro argument reuse '_M' - possible side-effects?
#289: FILE: drivers/net/r8169/r8169_dash.h:22:
+#define HW_DASH_SUPPORT_CMAC(_M)        (HW_DASH_SUPPORT_TYPE_2(_M) || HW_DASH_SUPPORT_TYPE_3(_M))

total: 1 errors, 1 warnings, 5 checks, 248 lines checked