From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 0439045B3C
	for <public@inbox.dpdk.org>; Tue, 15 Oct 2024 05:13:14 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 08BEB40668;
	Tue, 15 Oct 2024 05:13:14 +0200 (CEST)
Received: from dpdk.org (dpdk.org [92.243.24.197])
 by mails.dpdk.org (Postfix) with ESMTP id 90F8A4065A
 for <test-report@dpdk.org>; Tue, 15 Oct 2024 05:13:12 +0200 (CEST)
Received: by dpdk.org (Postfix, from userid 65534)
 id 7FEBF120757; Tue, 15 Oct 2024 05:13:12 +0200 (CEST)
Subject: |WARNING| pw145947 [PATCH v1 17/18] net/r8169: add driver_start and
 driver_stop
In-Reply-To: <20241015030928.70642-18-howard_wang@realsil.com.cn>
References: <20241015030928.70642-18-howard_wang@realsil.com.cn>
To: test-report@dpdk.org
From: checkpatch@dpdk.org
Cc: Howard Wang <howard_wang@realsil.com.cn>
Message-Id: <20241015031312.7FEBF120757@dpdk.org>
Date: Tue, 15 Oct 2024 05:13:12 +0200 (CEST)
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/145947

_coding style issues_


CHECK:USLEEP_RANGE: usleep_range is preferred over udelay; see Documentation/timers/timers-howto.rst
#160: FILE: drivers/net/r8169/r8169_dash.c:111:
+		udelay(50);

ERROR:CODE_INDENT: code indent should use tabs where possible
#166: FILE: drivers/net/r8169/r8169_dash.c:117:
+^I            ISRIMR_DASH_TYPE2_TX_DISABLE_IDLE);$

WARNING:CONSTANT_COMPARISON: Comparisons should place the constant on the right side of the test
#208: FILE: drivers/net/r8169/r8169_dash.c:159:
+	if (FALSE == HW_DASH_SUPPORT_TYPE_4(hw))

CHECK:BOOL_COMPARISON: Using comparison to FALSE is error prone
#208: FILE: drivers/net/r8169/r8169_dash.c:159:
+	if (FALSE == HW_DASH_SUPPORT_TYPE_4(hw))

CHECK:CAMELCASE: Avoid CamelCase: <HwSuppDashVer>
#219: FILE: drivers/net/r8169/r8169_dash.c:170:
+	switch (hw->HwSuppDashVer) {

CHECK:CAMELCASE: Avoid CamelCase: <AllowAccessDashOcp>
#258: FILE: drivers/net/r8169/r8169_dash.c:209:
+	if (!hw->AllowAccessDashOcp)

CHECK:MACRO_ARG_REUSE: Macro argument reuse '_M' - possible side-effects?
#289: FILE: drivers/net/r8169/r8169_dash.h:22:
+#define HW_DASH_SUPPORT_CMAC(_M)        (HW_DASH_SUPPORT_TYPE_2(_M) || HW_DASH_SUPPORT_TYPE_3(_M))

total: 1 errors, 1 warnings, 5 checks, 248 lines checked