From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Howard Wang <howard_wang@realsil.com.cn>
Subject: |WARNING| pw145943 [PATCH v1 13/18] net/r8169: implement device statistics
Date: Tue, 15 Oct 2024 05:13:28 +0200 (CEST) [thread overview]
Message-ID: <20241015031328.D8FA6120757@dpdk.org> (raw)
In-Reply-To: <20241015030928.70642-14-howard_wang@realsil.com.cn>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/145943
_coding style issues_
WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one
WARNING:TYPO_SPELLING: 'underun' may be misspelled - perhaps 'underrun'?
#101: FILE: drivers/net/r8169/r8169_base.h:39:
+ u16 tx_underun;
ERROR:CODE_INDENT: code indent should use tabs where possible
#117: FILE: drivers/net/r8169/r8169_ethdev.c:44:
+ struct rte_eth_stats *rte_stats);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#117: FILE: drivers/net/r8169/r8169_ethdev.c:44:
+ struct rte_eth_stats *rte_stats);$
CHECK:CAMELCASE: Avoid CamelCase: <CounterAddrHigh>
#230: FILE: drivers/net/r8169/r8169_hw.c:1519:
+ RTL_W32(hw, CounterAddrHigh, (u64)paddr >> 32);
CHECK:CAMELCASE: Avoid CamelCase: <CounterAddrLow>
#232: FILE: drivers/net/r8169/r8169_hw.c:1521:
+ RTL_W32(hw, CounterAddrLow, cmd);
CHECK:CAMELCASE: Avoid CamelCase: <CounterDump>
#233: FILE: drivers/net/r8169/r8169_hw.c:1522:
+ RTL_W32(hw, CounterAddrLow, cmd | CounterDump);
CHECK:USLEEP_RANGE: usleep_range is preferred over udelay; see Documentation/timers/timers-howto.rst
#237: FILE: drivers/net/r8169/r8169_hw.c:1526:
+ udelay(10);
ERROR:CODE_INDENT: code indent should use tabs where possible
#263: FILE: drivers/net/r8169/r8169_hw.c:1552:
+^I ((u64)hw->tally_paddr & (DMA_BIT_MASK(32))) | CounterReset);$
CHECK:CAMELCASE: Avoid CamelCase: <CounterReset>
#263: FILE: drivers/net/r8169/r8169_hw.c:1552:
+ ((u64)hw->tally_paddr & (DMA_BIT_MASK(32))) | CounterReset);
ERROR:CODE_INDENT: code indent should use tabs where possible
#274: FILE: drivers/net/r8169/r8169_hw.c:1563:
+^I sizeof(struct rtl_counters), 64, rte_socket_id());$
total: 3 errors, 3 warnings, 5 checks, 205 lines checked
parent reply other threads:[~2024-10-15 3:13 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20241015030928.70642-14-howard_wang@realsil.com.cn>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241015031328.D8FA6120757@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=howard_wang@realsil.com.cn \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).