From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 5673345B3C
	for <public@inbox.dpdk.org>; Tue, 15 Oct 2024 05:13:30 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 594A94065D;
	Tue, 15 Oct 2024 05:13:30 +0200 (CEST)
Received: from dpdk.org (dpdk.org [92.243.24.197])
 by mails.dpdk.org (Postfix) with ESMTP id E912A4065A
 for <test-report@dpdk.org>; Tue, 15 Oct 2024 05:13:28 +0200 (CEST)
Received: by dpdk.org (Postfix, from userid 65534)
 id D8FA6120757; Tue, 15 Oct 2024 05:13:28 +0200 (CEST)
Subject: |WARNING| pw145943 [PATCH v1 13/18] net/r8169: implement device
 statistics
In-Reply-To: <20241015030928.70642-14-howard_wang@realsil.com.cn>
References: <20241015030928.70642-14-howard_wang@realsil.com.cn>
To: test-report@dpdk.org
From: checkpatch@dpdk.org
Cc: Howard Wang <howard_wang@realsil.com.cn>
Message-Id: <20241015031328.D8FA6120757@dpdk.org>
Date: Tue, 15 Oct 2024 05:13:28 +0200 (CEST)
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/145943

_coding style issues_


WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one

WARNING:TYPO_SPELLING: 'underun' may be misspelled - perhaps 'underrun'?
#101: FILE: drivers/net/r8169/r8169_base.h:39:
+	u16 tx_underun;

ERROR:CODE_INDENT: code indent should use tabs where possible
#117: FILE: drivers/net/r8169/r8169_ethdev.c:44:
+                             struct rte_eth_stats *rte_stats);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#117: FILE: drivers/net/r8169/r8169_ethdev.c:44:
+                             struct rte_eth_stats *rte_stats);$

CHECK:CAMELCASE: Avoid CamelCase: <CounterAddrHigh>
#230: FILE: drivers/net/r8169/r8169_hw.c:1519:
+	RTL_W32(hw, CounterAddrHigh, (u64)paddr >> 32);

CHECK:CAMELCASE: Avoid CamelCase: <CounterAddrLow>
#232: FILE: drivers/net/r8169/r8169_hw.c:1521:
+	RTL_W32(hw, CounterAddrLow, cmd);

CHECK:CAMELCASE: Avoid CamelCase: <CounterDump>
#233: FILE: drivers/net/r8169/r8169_hw.c:1522:
+	RTL_W32(hw, CounterAddrLow, cmd | CounterDump);

CHECK:USLEEP_RANGE: usleep_range is preferred over udelay; see Documentation/timers/timers-howto.rst
#237: FILE: drivers/net/r8169/r8169_hw.c:1526:
+		udelay(10);

ERROR:CODE_INDENT: code indent should use tabs where possible
#263: FILE: drivers/net/r8169/r8169_hw.c:1552:
+^I        ((u64)hw->tally_paddr & (DMA_BIT_MASK(32))) | CounterReset);$

CHECK:CAMELCASE: Avoid CamelCase: <CounterReset>
#263: FILE: drivers/net/r8169/r8169_hw.c:1552:
+	        ((u64)hw->tally_paddr & (DMA_BIT_MASK(32))) | CounterReset);

ERROR:CODE_INDENT: code indent should use tabs where possible
#274: FILE: drivers/net/r8169/r8169_hw.c:1563:
+^I                              sizeof(struct rtl_counters), 64, rte_socket_id());$

total: 3 errors, 3 warnings, 5 checks, 205 lines checked