* |WARNING| pw145943 [PATCH v1 13/18] net/r8169: implement device statistics
[not found] <20241015030928.70642-14-howard_wang@realsil.com.cn>
@ 2024-10-15 3:13 ` checkpatch
0 siblings, 0 replies; only message in thread
From: checkpatch @ 2024-10-15 3:13 UTC (permalink / raw)
To: test-report; +Cc: Howard Wang
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/145943
_coding style issues_
WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one
WARNING:TYPO_SPELLING: 'underun' may be misspelled - perhaps 'underrun'?
#101: FILE: drivers/net/r8169/r8169_base.h:39:
+ u16 tx_underun;
ERROR:CODE_INDENT: code indent should use tabs where possible
#117: FILE: drivers/net/r8169/r8169_ethdev.c:44:
+ struct rte_eth_stats *rte_stats);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#117: FILE: drivers/net/r8169/r8169_ethdev.c:44:
+ struct rte_eth_stats *rte_stats);$
CHECK:CAMELCASE: Avoid CamelCase: <CounterAddrHigh>
#230: FILE: drivers/net/r8169/r8169_hw.c:1519:
+ RTL_W32(hw, CounterAddrHigh, (u64)paddr >> 32);
CHECK:CAMELCASE: Avoid CamelCase: <CounterAddrLow>
#232: FILE: drivers/net/r8169/r8169_hw.c:1521:
+ RTL_W32(hw, CounterAddrLow, cmd);
CHECK:CAMELCASE: Avoid CamelCase: <CounterDump>
#233: FILE: drivers/net/r8169/r8169_hw.c:1522:
+ RTL_W32(hw, CounterAddrLow, cmd | CounterDump);
CHECK:USLEEP_RANGE: usleep_range is preferred over udelay; see Documentation/timers/timers-howto.rst
#237: FILE: drivers/net/r8169/r8169_hw.c:1526:
+ udelay(10);
ERROR:CODE_INDENT: code indent should use tabs where possible
#263: FILE: drivers/net/r8169/r8169_hw.c:1552:
+^I ((u64)hw->tally_paddr & (DMA_BIT_MASK(32))) | CounterReset);$
CHECK:CAMELCASE: Avoid CamelCase: <CounterReset>
#263: FILE: drivers/net/r8169/r8169_hw.c:1552:
+ ((u64)hw->tally_paddr & (DMA_BIT_MASK(32))) | CounterReset);
ERROR:CODE_INDENT: code indent should use tabs where possible
#274: FILE: drivers/net/r8169/r8169_hw.c:1563:
+^I sizeof(struct rtl_counters), 64, rte_socket_id());$
total: 3 errors, 3 warnings, 5 checks, 205 lines checked
^ permalink raw reply [flat|nested] only message in thread