From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 71EA545B3C for ; Tue, 15 Oct 2024 05:13:42 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6ABF24065A; Tue, 15 Oct 2024 05:13:42 +0200 (CEST) Received: from dpdk.org (dpdk.org [92.243.24.197]) by mails.dpdk.org (Postfix) with ESMTP id C76BE40156 for ; Tue, 15 Oct 2024 05:13:41 +0200 (CEST) Received: by dpdk.org (Postfix, from userid 65534) id AD06A120757; Tue, 15 Oct 2024 05:13:41 +0200 (CEST) Subject: |WARNING| pw145942 [PATCH v1 12/18] net/r8169: implement Tx path In-Reply-To: <20241015030928.70642-13-howard_wang@realsil.com.cn> References: <20241015030928.70642-13-howard_wang@realsil.com.cn> To: test-report@dpdk.org From: checkpatch@dpdk.org Cc: Howard Wang Message-Id: <20241015031341.AD06A120757@dpdk.org> Date: Tue, 15 Oct 2024 05:13:41 +0200 (CEST) X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/145942 _coding style issues_ CHECK:CAMELCASE: Avoid CamelCase: #131: FILE: drivers/net/r8169/r8169_ethdev.h:80: + u32 NextHwDesCloPtr0; CHECK:CAMELCASE: Avoid CamelCase: #132: FILE: drivers/net/r8169/r8169_ethdev.h:81: + u32 BeginHwDesCloPtr0; ERROR:CODE_INDENT: code indent should use tabs where possible #145: FILE: drivers/net/r8169/r8169_ethdev.h:124: + struct rte_eth_txq_info *qinfo);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #145: FILE: drivers/net/r8169/r8169_ethdev.h:124: + struct rte_eth_txq_info *qinfo);$ ERROR:CODE_INDENT: code indent should use tabs where possible #155: FILE: drivers/net/r8169/r8169_ethdev.h:134: + uint16_t nb_tx_desc, unsigned int socket_id,$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #155: FILE: drivers/net/r8169/r8169_ethdev.h:134: + uint16_t nb_tx_desc, unsigned int socket_id,$ ERROR:CODE_INDENT: code indent should use tabs where possible #156: FILE: drivers/net/r8169/r8169_ethdev.h:135: + const struct rte_eth_txconf *tx_conf);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #156: FILE: drivers/net/r8169/r8169_ethdev.h:135: + const struct rte_eth_txconf *tx_conf);$ ERROR:CODE_INDENT: code indent should use tabs where possible #172: FILE: drivers/net/r8169/r8169_rxtx.c:34: +^I^I RTE_MBUF_F_TX_IPV4 |^I^I\$ ERROR:CODE_INDENT: code indent should use tabs where possible #173: FILE: drivers/net/r8169/r8169_rxtx.c:35: +^I^I RTE_MBUF_F_TX_VLAN |^I^I\$ ERROR:CODE_INDENT: code indent should use tabs where possible #174: FILE: drivers/net/r8169/r8169_rxtx.c:36: +^I^I RTE_MBUF_F_TX_IP_CKSUM |^I \$ ERROR:CODE_INDENT: code indent should use tabs where possible #175: FILE: drivers/net/r8169/r8169_rxtx.c:37: +^I^I RTE_MBUF_F_TX_L4_MASK |^I^I\$ ERROR:CODE_INDENT: code indent should use tabs where possible #176: FILE: drivers/net/r8169/r8169_rxtx.c:38: +^I^I RTE_MBUF_F_TX_TCP_SEG)$ ERROR:CODE_INDENT: code indent should use tabs where possible #312: FILE: drivers/net/r8169/r8169_rxtx.c:888: + struct rte_eth_txq_info *qinfo)$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #312: FILE: drivers/net/r8169/r8169_rxtx.c:888: + struct rte_eth_txq_info *qinfo)$ CHECK:CAMELCASE: Avoid CamelCase: #330: FILE: drivers/net/r8169/r8169_rxtx.c:906: + txq->hw_ring[txq->nb_tx_desc - 1].opts1 = rte_cpu_to_le_32(RingEnd); ERROR:CODE_INDENT: code indent should use tabs where possible #343: FILE: drivers/net/r8169/r8169_rxtx.c:919: +^I RTE_ETH_TX_OFFLOAD_IPV4_CKSUM |$ ERROR:CODE_INDENT: code indent should use tabs where possible #344: FILE: drivers/net/r8169/r8169_rxtx.c:920: +^I RTE_ETH_TX_OFFLOAD_UDP_CKSUM |$ ERROR:CODE_INDENT: code indent should use tabs where possible #345: FILE: drivers/net/r8169/r8169_rxtx.c:921: +^I RTE_ETH_TX_OFFLOAD_TCP_CKSUM |$ ERROR:CODE_INDENT: code indent should use tabs where possible #346: FILE: drivers/net/r8169/r8169_rxtx.c:922: +^I RTE_ETH_TX_OFFLOAD_TCP_TSO |$ ERROR:CODE_INDENT: code indent should use tabs where possible #347: FILE: drivers/net/r8169/r8169_rxtx.c:923: +^I RTE_ETH_TX_OFFLOAD_MULTI_SEGS;$ ERROR:CODE_INDENT: code indent should use tabs where possible #354: FILE: drivers/net/r8169/r8169_rxtx.c:930: + uint16_t nb_tx_desc, unsigned int socket_id,$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #354: FILE: drivers/net/r8169/r8169_rxtx.c:930: + uint16_t nb_tx_desc, unsigned int socket_id,$ ERROR:CODE_INDENT: code indent should use tabs where possible #355: FILE: drivers/net/r8169/r8169_rxtx.c:931: + const struct rte_eth_txconf *tx_conf)$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #355: FILE: drivers/net/r8169/r8169_rxtx.c:931: + const struct rte_eth_txconf *tx_conf)$ ERROR:CODE_INDENT: code indent should use tabs where possible #367: FILE: drivers/net/r8169/r8169_rxtx.c:943: +^I^I "less than or equal to %d "$ ERROR:CODE_INDENT: code indent should use tabs where possible #368: FILE: drivers/net/r8169/r8169_rxtx.c:944: +^I^I "greater than or equal to %d ", RTL_MAX_TX_DESC,$ ERROR:CODE_INDENT: code indent should use tabs where possible #369: FILE: drivers/net/r8169/r8169_rxtx.c:945: +^I^I RTL_MIN_TX_DESC);$ ERROR:CODE_INDENT: code indent should use tabs where possible #384: FILE: drivers/net/r8169/r8169_rxtx.c:960: +^I sizeof(struct rtl_tx_queue),$ ERROR:CODE_INDENT: code indent should use tabs where possible #385: FILE: drivers/net/r8169/r8169_rxtx.c:961: +^I RTE_CACHE_LINE_SIZE, socket_id);$ ERROR:CODE_INDENT: code indent should use tabs where possible #400: FILE: drivers/net/r8169/r8169_rxtx.c:976: +^I nb_tx_desc * sizeof(struct rtl_tx_entry),$ ERROR:CODE_INDENT: code indent should use tabs where possible #401: FILE: drivers/net/r8169/r8169_rxtx.c:977: +^I RTE_CACHE_LINE_SIZE, socket_id);$ ERROR:CODE_INDENT: code indent should use tabs where possible #405: FILE: drivers/net/r8169/r8169_rxtx.c:981: +^I^I "Port %d: Cannot allocate software ring for queue %d",$ ERROR:CODE_INDENT: code indent should use tabs where possible #406: FILE: drivers/net/r8169/r8169_rxtx.c:982: +^I^I txq->port_id, txq->queue_id);$ ERROR:CODE_INDENT: code indent should use tabs where possible #418: FILE: drivers/net/r8169/r8169_rxtx.c:994: +^I RTL_RING_ALIGN, socket_id);$ ERROR:CODE_INDENT: code indent should use tabs where possible #421: FILE: drivers/net/r8169/r8169_rxtx.c:997: +^I^I "Port %d: Cannot allocate hardware ring for queue %d",$ ERROR:CODE_INDENT: code indent should use tabs where possible #422: FILE: drivers/net/r8169/r8169_rxtx.c:998: +^I^I txq->port_id, txq->queue_id);$ CHECK:CAMELCASE: Avoid CamelCase: #451: FILE: drivers/net/r8169/r8169_rxtx.c:1027: + RTL_W32(hw, TxDescStartAddrLow, ERROR:CODE_INDENT: code indent should use tabs where possible #452: FILE: drivers/net/r8169/r8169_rxtx.c:1028: +^I ((u64)txq->hw_ring_phys_addr & DMA_BIT_MASK(32)));$ CHECK:CAMELCASE: Avoid CamelCase: #453: FILE: drivers/net/r8169/r8169_rxtx.c:1029: + RTL_W32(hw, TxDescStartAddrHigh, ((u64)txq->hw_ring_phys_addr >> 32)); CHECK:CAMELCASE: Avoid CamelCase: #467: FILE: drivers/net/r8169/r8169_rxtx.c:1043: + RTL_W8(hw, ChipCmd, RTL_R8(hw, ChipCmd) | CmdTxEnb); CHECK:CAMELCASE: Avoid CamelCase: #467: FILE: drivers/net/r8169/r8169_rxtx.c:1043: + RTL_W8(hw, ChipCmd, RTL_R8(hw, ChipCmd) | CmdTxEnb); CHECK:CAMELCASE: Avoid CamelCase: #480: FILE: drivers/net/r8169/r8169_rxtx.c:1054: + (TxVlanTag | rte_bswap16(tx_pkt->vlan_tci)) : CHECK:CAMELCASE: Avoid CamelCase: #497: FILE: drivers/net/r8169/r8169_rxtx.c:1071: + opts[0] |= GiantSendv4; CHECK:CAMELCASE: Avoid CamelCase: #499: FILE: drivers/net/r8169/r8169_rxtx.c:1073: + opts[0] |= GiantSendv6; ERROR:CODE_INDENT: code indent should use tabs where possible #513: FILE: drivers/net/r8169/r8169_rxtx.c:1087: + uint32_t *opts)$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #513: FILE: drivers/net/r8169/r8169_rxtx.c:1087: + uint32_t *opts)$ CHECK:CAMELCASE: Avoid CamelCase: #519: FILE: drivers/net/r8169/r8169_rxtx.c:1093: + csum_cmd |= TxIPCS_C; CHECK:CAMELCASE: Avoid CamelCase: #523: FILE: drivers/net/r8169/r8169_rxtx.c:1097: + csum_cmd |= TxUDPCS_C; CHECK:CAMELCASE: Avoid CamelCase: #526: FILE: drivers/net/r8169/r8169_rxtx.c:1100: + csum_cmd |= TxTCPCS_C; CHECK:BRACES: braces {} should be used on all arms of this statement #531: FILE: drivers/net/r8169/r8169_rxtx.c:1105: + if (ol_flags & RTE_MBUF_F_TX_IPV6) { [...] + } else [...] CHECK:CAMELCASE: Avoid CamelCase: #533: FILE: drivers/net/r8169/r8169_rxtx.c:1107: + csum_cmd |= TxIPV6F_C; CHECK:BRACES: Unbalanced braces around else statement #535: FILE: drivers/net/r8169/r8169_rxtx.c:1109: + } else CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'tx_pkt->data_len < 175' #549: FILE: drivers/net/r8169/r8169_rxtx.c:1123: + if (!(tx_pkt->l4_len && (tx_pkt->data_len < 175))) ERROR:CODE_INDENT: code indent should use tabs where possible #557: FILE: drivers/net/r8169/r8169_rxtx.c:1131: +^I^I struct rte_ether_hdr *) + l4_offset + 2, 2);$ ERROR:CODE_INDENT: code indent should use tabs where possible #598: FILE: drivers/net/r8169/r8169_rxtx.c:1172: + struct rte_mbuf *tx_pkt)$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #598: FILE: drivers/net/r8169/r8169_rxtx.c:1172: + struct rte_mbuf *tx_pkt)$ CHECK:BRACES: Blank lines aren't necessary after an open brace '{' #600: FILE: drivers/net/r8169/r8169_rxtx.c:1174: +{ + CHECK:CAMELCASE: Avoid CamelCase: #626: FILE: drivers/net/r8169/r8169_rxtx.c:1200: + opts[0] = DescOwn; CHECK:CAMELCASE: Avoid CamelCase: #658: FILE: drivers/net/r8169/r8169_rxtx.c:1232: + opts1 |= FirstFrag; CHECK:CAMELCASE: Avoid CamelCase: #660: FILE: drivers/net/r8169/r8169_rxtx.c:1234: + opts1 |= LastFrag; CHECK:CAMELCASE: Avoid CamelCase: #698: FILE: drivers/net/r8169/r8169_rxtx.c:1272: + switch (hw->HwSuppTxNoCloseVer) { CHECK:CAMELCASE: Avoid CamelCase: #724: FILE: drivers/net/r8169/r8169_rxtx.c:1298: + const uint8_t enable_tx_no_close = hw->EnableTxNoClose; CHECK:BRACES: braces {} should be used on all arms of this statement #734: FILE: drivers/net/r8169/r8169_rxtx.c:1308: + if (enable_tx_no_close) { [...] + } else [...] ERROR:CODE_INDENT: code indent should use tabs where possible #738: FILE: drivers/net/r8169/r8169_rxtx.c:1312: +^I^I hw->BeginHwDesCloPtr0, hw->MaxTxDescPtrMask);$ CHECK:CAMELCASE: Avoid CamelCase: #738: FILE: drivers/net/r8169/r8169_rxtx.c:1312: + hw->BeginHwDesCloPtr0, hw->MaxTxDescPtrMask); ERROR:CODE_INDENT: code indent should use tabs where possible #740: FILE: drivers/net/r8169/r8169_rxtx.c:1314: +^I^I tx_desc_closed);$ CHECK:BRACES: Unbalanced braces around else statement #742: FILE: drivers/net/r8169/r8169_rxtx.c:1316: + } else CHECK:BRACES: braces {} should be used on all arms of this statement #785: FILE: drivers/net/r8169/r8169_rxtx.c:1359: + if (enable_tx_no_close) { [...] + } else [...] ERROR:CODE_INDENT: code indent should use tabs where possible #789: FILE: drivers/net/r8169/r8169_rxtx.c:1363: +^I^I hw->BeginHwDesCloPtr0, hw->MaxTxDescPtrMask);$ ERROR:CODE_INDENT: code indent should use tabs where possible #791: FILE: drivers/net/r8169/r8169_rxtx.c:1365: +^I^I tx_desc_closed);$ CHECK:BRACES: Unbalanced braces around else statement #793: FILE: drivers/net/r8169/r8169_rxtx.c:1367: + } else CHECK:BRACES: Blank lines aren't necessary before a close brace '}' #821: FILE: drivers/net/r8169/r8169_rxtx.c:1395: + + } ERROR:CODE_INDENT: code indent should use tabs where possible #853: FILE: drivers/net/r8169/r8169_rxtx.c:1427: +^I "port %d txq %d pkts: %d tx_free=%d tx_tail=%d tx_head=%d",$ ERROR:CODE_INDENT: code indent should use tabs where possible #854: FILE: drivers/net/r8169/r8169_rxtx.c:1428: +^I txq->port_id, txq->queue_id, nb_pkts, txq->tx_free,$ ERROR:CODE_INDENT: code indent should use tabs where possible #855: FILE: drivers/net/r8169/r8169_rxtx.c:1429: +^I txq->tx_tail, txq->tx_head);$ WARNING:EMBEDDED_FUNCTION_NAME: Prefer using '"%s...", __func__' to using 'rtl_xmit_pkts', this function's name, in a string #876: FILE: drivers/net/r8169/r8169_rxtx.c:1450: + PMD_TX_LOG(DEBUG, "rtl_xmit_pkts %d transmitted", nb_tx); total: 39 errors, 9 warnings, 29 checks, 804 lines checked Warning in drivers/net/r8169/r8169_rxtx.c: Using rte_smp_[r/w]mb