From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A843945B3C for ; Tue, 15 Oct 2024 05:14:09 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AD34C4027F; Tue, 15 Oct 2024 05:14:09 +0200 (CEST) Received: from dpdk.org (dpdk.org [92.243.24.197]) by mails.dpdk.org (Postfix) with ESMTP id 247C440156 for ; Tue, 15 Oct 2024 05:14:08 +0200 (CEST) Received: by dpdk.org (Postfix, from userid 65534) id 10B6B120757; Tue, 15 Oct 2024 05:14:08 +0200 (CEST) Subject: |WARNING| pw145940 [PATCH v1 10/18] net/r8169: add link status and interrupt management In-Reply-To: <20241015030928.70642-11-howard_wang@realsil.com.cn> References: <20241015030928.70642-11-howard_wang@realsil.com.cn> To: test-report@dpdk.org From: checkpatch@dpdk.org Cc: Howard Wang Message-Id: <20241015031408.10B6B120757@dpdk.org> Date: Tue, 15 Oct 2024 05:14:08 +0200 (CEST) X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/145940 _coding style issues_ WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one CHECK:CAMELCASE: Avoid CamelCase: #146: FILE: drivers/net/r8169/r8169_ethdev.c:83: + RTL_W32(hw, IMR0_8125, LinkChg); CHECK:BRACES: braces {} should be used on all arms of this statement #158: FILE: drivers/net/r8169/r8169_ethdev.c:95: + if (*link_speeds == RTE_ETH_LINK_SPEED_AUTONEG) [...] + else if (*link_speeds != 0) { [...] CHECK:BRACES: Blank lines aren't necessary after an open brace '{' #161: FILE: drivers/net/r8169/r8169_ethdev.c:98: + else if (*link_speeds != 0) { + ERROR:CODE_INDENT: code indent should use tabs where possible #163: FILE: drivers/net/r8169/r8169_ethdev.c:100: +^I^I RTE_ETH_LINK_SPEED_100M_HD | RTE_ETH_LINK_SPEED_100M |$ ERROR:CODE_INDENT: code indent should use tabs where possible #164: FILE: drivers/net/r8169/r8169_ethdev.c:101: +^I^I RTE_ETH_LINK_SPEED_1G | RTE_ETH_LINK_SPEED_2_5G |$ ERROR:CODE_INDENT: code indent should use tabs where possible #165: FILE: drivers/net/r8169/r8169_ethdev.c:102: +^I^I RTE_ETH_LINK_SPEED_5G | RTE_ETH_LINK_SPEED_FIXED))$ ERROR:CODE_INDENT: code indent should use tabs where possible #214: FILE: drivers/net/r8169/r8169_ethdev.c:151: +^I dev->data->dev_conf.link_speeds, dev->data->port_id);$ CHECK:CAMELCASE: Avoid CamelCase: #232: FILE: drivers/net/r8169/r8169_ethdev.c:169: + if (!(RTL_R16(hw, PHYstatus) & LinkStatus)) { CHECK:CAMELCASE: Avoid CamelCase: #232: FILE: drivers/net/r8169/r8169_ethdev.c:169: + if (!(RTL_R16(hw, PHYstatus) & LinkStatus)) { CHECK:CAMELCASE: Avoid CamelCase: #363: FILE: drivers/net/r8169/r8169_ethdev.c:327: + if (status & FullDup) { CHECK:CAMELCASE: Avoid CamelCase: #366: FILE: drivers/net/r8169/r8169_ethdev.c:330: + RTL_W32(hw, TxConfig, (RTL_R32(hw, TxConfig) | ERROR:CODE_INDENT: code indent should use tabs where possible #367: FILE: drivers/net/r8169/r8169_ethdev.c:331: +^I^I^I^I (BIT_24 | BIT_25)) & ~BIT_19);$ ERROR:CODE_INDENT: code indent should use tabs where possible #373: FILE: drivers/net/r8169/r8169_ethdev.c:337: +^I^I^I^I ~(BIT_19 | BIT_24));$ ERROR:CODE_INDENT: code indent should use tabs where possible #444: FILE: drivers/net/r8169/r8169_ethdev.c:409: +^I^I dev);$ CHECK:CAMELCASE: Avoid CamelCase: #517: FILE: drivers/net/r8169/r8169_hw.c:1093: + hw->HwSuppMaxPhyLinkSpeed = SPEED_2500; ERROR:CODE_INDENT: code indent should use tabs where possible #538: FILE: drivers/net/r8169/r8169_hw.h:55: + enum rtl_fc_mode fc);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #538: FILE: drivers/net/r8169/r8169_hw.h:55: + enum rtl_fc_mode fc);$ WARNING:TYPO_SPELLING: 'lite' may be misspelled - perhaps 'light'? #592: FILE: drivers/net/r8169/r8169_phy.c:819: + /* Disable giga lite */ ERROR:CODE_INDENT: code indent should use tabs where possible #614: FILE: drivers/net/r8169/r8169_phy.c:841: +^I^I ADVERTISE_100HALF | ADVERTISE_100FULL |$ ERROR:CODE_INDENT: code indent should use tabs where possible #615: FILE: drivers/net/r8169/r8169_phy.c:842: +^I^I ADVERTISE_PAUSE_CAP | ADVERTISE_PAUSE_ASYM);$ ERROR:CODE_INDENT: code indent should use tabs where possible #667: FILE: drivers/net/r8169/r8169_phy.c:894: +^I hw->advertising);$ total: 11 errors, 3 warnings, 8 checks, 556 lines checked