From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Howard Wang <howard_wang@realsil.com.cn>
Subject: |WARNING| pw145939 [PATCH v1 09/18] net/r8169: add support for hw initialization
Date: Tue, 15 Oct 2024 05:14:21 +0200 (CEST) [thread overview]
Message-ID: <20241015031421.D0C8C120757@dpdk.org> (raw)
In-Reply-To: <20241015030928.70642-10-howard_wang@realsil.com.cn>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/145939
_coding style issues_
WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one
ERROR:CODE_INDENT: code indent should use tabs where possible
#158: FILE: drivers/net/r8169/r8169_base.h:563:
+ ADVERTISE_100_HALF | ADVERTISE_100_FULL | ADVERTISE_1000_FULL | \$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#158: FILE: drivers/net/r8169/r8169_base.h:563:
+ ADVERTISE_100_HALF | ADVERTISE_100_FULL | ADVERTISE_1000_FULL | \$
ERROR:CODE_INDENT: code indent should use tabs where possible
#159: FILE: drivers/net/r8169/r8169_base.h:564:
+ ADVERTISE_2500_FULL | ADVERTISE_5000_FULL)$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#159: FILE: drivers/net/r8169/r8169_base.h:564:
+ ADVERTISE_2500_FULL | ADVERTISE_5000_FULL)$
WARNING:TYPO_SPELLING: 'stdio' may be misspelled - perhaps 'studio'?
#177: FILE: drivers/net/r8169/r8169_dash.c:6:
+#include <stdio.h>
WARNING:CONSTANT_COMPARISON: Comparisons should place the constant on the right side of the test
#224: FILE: drivers/net/r8169/r8169_dash.c:53:
+ if (FALSE == HW_DASH_SUPPORT_GET_FIRMWARE_VERSION(hw))
CHECK:BOOL_COMPARISON: Using comparison to FALSE is error prone
#224: FILE: drivers/net/r8169/r8169_dash.c:53:
+ if (FALSE == HW_DASH_SUPPORT_GET_FIRMWARE_VERSION(hw))
CHECK:CAMELCASE: Avoid CamelCase: <AllowAccessDashOcp>
#236: FILE: drivers/net/r8169/r8169_dash.c:65:
+ if (!hw->AllowAccessDashOcp)
CHECK:CAMELCASE: Avoid CamelCase: <HwSuppDashVer>
#283: FILE: drivers/net/r8169/r8169_dash.h:17:
+#define HW_DASH_SUPPORT_DASH(_M) ((_M)->HwSuppDashVer > 0)
CHECK:MACRO_ARG_REUSE: Macro argument reuse '_M' - possible side-effects?
#289: FILE: drivers/net/r8169/r8169_dash.h:23:
+#define HW_DASH_SUPPORT_GET_FIRMWARE_VERSION(_M) (HW_DASH_SUPPORT_TYPE_2(_M) || \
+ HW_DASH_SUPPORT_TYPE_3(_M) || \
+ HW_DASH_SUPPORT_TYPE_4(_M))
ERROR:CODE_INDENT: code indent should use tabs where possible
#290: FILE: drivers/net/r8169/r8169_dash.h:24:
+ HW_DASH_SUPPORT_TYPE_3(_M) || \$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#290: FILE: drivers/net/r8169/r8169_dash.h:24:
+ HW_DASH_SUPPORT_TYPE_3(_M) || \$
ERROR:CODE_INDENT: code indent should use tabs where possible
#291: FILE: drivers/net/r8169/r8169_dash.h:25:
+ HW_DASH_SUPPORT_TYPE_4(_M))$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#291: FILE: drivers/net/r8169/r8169_dash.h:25:
+ HW_DASH_SUPPORT_TYPE_4(_M))$
CHECK:CAMELCASE: Avoid CamelCase: <HwIcVerUnknown>
#417: FILE: drivers/net/r8169/r8169_ethdev.h:42:
+ u8 HwIcVerUnknown;
CHECK:CAMELCASE: Avoid CamelCase: <HwSuppNowIsOobVer>
#438: FILE: drivers/net/r8169/r8169_ethdev.h:69:
+ u8 HwSuppNowIsOobVer;
CHECK:CAMELCASE: Avoid CamelCase: <HwSuppTxNoCloseVer>
#444: FILE: drivers/net/r8169/r8169_ethdev.h:74:
+ u8 HwSuppTxNoCloseVer;
CHECK:CAMELCASE: Avoid CamelCase: <EnableTxNoClose>
#445: FILE: drivers/net/r8169/r8169_ethdev.h:75:
+ u8 EnableTxNoClose;
CHECK:CAMELCASE: Avoid CamelCase: <MaxTxDescPtrMask>
#448: FILE: drivers/net/r8169/r8169_ethdev.h:78:
+ u32 MaxTxDescPtrMask;
ERROR:CODE_INDENT: code indent should use tabs where possible
#509: FILE: drivers/net/r8169/r8169_hw.c:965:
+ enum rtl_fc_mode fc)$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#509: FILE: drivers/net/r8169/r8169_hw.c:965:
+ enum rtl_fc_mode fc)$
CHECK:CAMELCASE: Avoid CamelCase: <HwSuppMaxPhyLinkSpeed>
#522: FILE: drivers/net/r8169/r8169_hw.c:978:
+ speed = RTE_MIN(speed, hw->HwSuppMaxPhyLinkSpeed);
ERROR:CODE_INDENT: code indent should use tabs where possible
#534: FILE: drivers/net/r8169/r8169_hw.c:990:
+^I^I ADVERTISE_100_HALF | ADVERTISE_100_FULL |$
ERROR:CODE_INDENT: code indent should use tabs where possible
#535: FILE: drivers/net/r8169/r8169_hw.c:991:
+^I^I ADVERTISE_1000_HALF | ADVERTISE_1000_FULL);$
CHECK:CAMELCASE: Avoid CamelCase: <HwSuppOcpChannelVer>
#575: FILE: drivers/net/r8169/r8169_hw.c:1031:
+ hw->HwSuppOcpChannelVer = 2;
CHECK:CAMELCASE: Avoid CamelCase: <HwSuppCheckPhyDisableModeVer>
#631: FILE: drivers/net/r8169/r8169_hw.c:1087:
+ hw->HwSuppCheckPhyDisableModeVer = 3;
CHECK:CAMELCASE: Avoid CamelCase: <NotWrRamCodeToMicroP>
#737: FILE: drivers/net/r8169/r8169_hw.c:1193:
+ hw->NotWrRamCodeToMicroP = TRUE;
CHECK:CAMELCASE: Avoid CamelCase: <NotWrMcuPatchCode>
#738: FILE: drivers/net/r8169/r8169_hw.c:1194:
+ hw->NotWrMcuPatchCode = TRUE;
CHECK:CAMELCASE: Avoid CamelCase: <HwSuppMacMcuVer>
#744: FILE: drivers/net/r8169/r8169_hw.c:1200:
+ hw->HwSuppMacMcuVer = 2;
CHECK:CAMELCASE: Avoid CamelCase: <MacMcuPageSize>
#751: FILE: drivers/net/r8169/r8169_hw.c:1207:
+ hw->MacMcuPageSize = RTL_MAC_MCU_PAGE_SIZE;
CHECK:CAMELCASE: Avoid CamelCase: <RequirePhyMdiSwapPatch>
#760: FILE: drivers/net/r8169/r8169_hw.c:1216:
+ hw->RequirePhyMdiSwapPatch = TRUE;
CHECK:CAMELCASE: Avoid CamelCase: <HwSuppIntMitiVer>
#768: FILE: drivers/net/r8169/r8169_hw.c:1224:
+ hw->HwSuppIntMitiVer = 3;
CHECK:CAMELCASE: Avoid CamelCase: <MCUCmd_reg>
#813: FILE: drivers/net/r8169/r8169_hw.c:1269:
+ RTL_W8(hw, MCUCmd_reg, RTL_R8(hw, MCUCmd_reg) & ~Now_is_oob);
CHECK:CAMELCASE: Avoid CamelCase: <Now_is_oob>
#813: FILE: drivers/net/r8169/r8169_hw.c:1269:
+ RTL_W8(hw, MCUCmd_reg, RTL_R8(hw, MCUCmd_reg) & ~Now_is_oob);
CHECK:USLEEP_RANGE: usleep_range is preferred over udelay; see Documentation/timers/timers-howto.rst
#822: FILE: drivers/net/r8169/r8169_hw.c:1278:
+ udelay(100);
CHECK:CAMELCASE: Avoid CamelCase: <TxConfig>
#924: FILE: drivers/net/r8169/r8169_hw.c:1380:
+ val32 = RTL_R32(hw, TxConfig);
CHECK:BRACES: braces {} should be used on all arms of this statement
#930: FILE: drivers/net/r8169/r8169_hw.c:1386:
+ if (ic_version_id == 0x00000000)
[...]
+ else if (ic_version_id == 0x100000)
[...]
+ else {
[...]
CHECK:BRACES: Unbalanced braces around else statement
#936: FILE: drivers/net/r8169/r8169_hw.c:1392:
+ else {
CHECK:BRACES: braces {} should be used on all arms of this statement
#944: FILE: drivers/net/r8169/r8169_hw.c:1400:
+ if (ic_version_id == 0x00000000)
[...]
+ else if (ic_version_id == 0x100000)
[...]
+ else {
[...]
CHECK:BRACES: Unbalanced braces around else statement
#950: FILE: drivers/net/r8169/r8169_hw.c:1406:
+ else {
CHECK:BRACES: braces {} should be used on all arms of this statement
#958: FILE: drivers/net/r8169/r8169_hw.c:1414:
+ if (ic_version_id == 0x00000000)
[...]
+ else if (ic_version_id == 0x100000)
[...]
+ else {
[...]
CHECK:BRACES: Unbalanced braces around else statement
#962: FILE: drivers/net/r8169/r8169_hw.c:1418:
+ else {
CHECK:BRACES: braces {} should be used on all arms of this statement
#970: FILE: drivers/net/r8169/r8169_hw.c:1426:
+ if (ic_version_id == 0x00000000)
[...]
+ else if (ic_version_id == 0x100000)
[...]
+ else {
[...]
CHECK:BRACES: Unbalanced braces around else statement
#974: FILE: drivers/net/r8169/r8169_hw.c:1430:
+ else {
CHECK:BRACES: braces {} should be used on all arms of this statement
#982: FILE: drivers/net/r8169/r8169_hw.c:1438:
+ if (ic_version_id == 0x00000000)
[...]
+ else if (ic_version_id == 0x100000)
[...]
+ else if (ic_version_id == 0x200000)
[...]
+ else {
[...]
CHECK:BRACES: Unbalanced braces around else statement
#988: FILE: drivers/net/r8169/r8169_hw.c:1444:
+ else {
ERROR:CODE_INDENT: code indent should use tabs where possible
#1038: FILE: drivers/net/r8169/r8169_hw.c:1494:
+^I ((uint32_t)addr[2] << 16) | ((uint32_t)addr[3] << 24));$
total: 8 errors, 8 warnings, 32 checks, 1018 lines checked
parent reply other threads:[~2024-10-15 3:14 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20241015030928.70642-10-howard_wang@realsil.com.cn>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241015031421.D0C8C120757@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=howard_wang@realsil.com.cn \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).