From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3AD4645CF3 for ; Wed, 13 Nov 2024 10:33:56 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 360FD4042E; Wed, 13 Nov 2024 10:33:56 +0100 (CET) Received: from dpdk.org (dpdk.org [92.243.24.197]) by mails.dpdk.org (Postfix) with ESMTP id 0C18440290 for ; Wed, 13 Nov 2024 10:33:55 +0100 (CET) Received: by dpdk.org (Postfix, from userid 65534) id 09DA112314F; Wed, 13 Nov 2024 10:33:55 +0100 (CET) Subject: |WARNING| pw148402 [PATCH v8 11/17] net/r8169: implement Rx path In-Reply-To: <20241113092854.91445-12-howard_wang@realsil.com.cn> References: <20241113092854.91445-12-howard_wang@realsil.com.cn> To: test-report@dpdk.org From: checkpatch@dpdk.org Cc: Howard Wang Message-Id: <20241113093355.09DA112314F@dpdk.org> Date: Wed, 13 Nov 2024 10:33:55 +0100 (CET) X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/148402 _coding style issues_ CHECK:MACRO_ARG_REUSE: Macro argument reuse 'n' - possible side-effects? #143: FILE: drivers/net/r8169/r8169_compat.h:575: +#define DMA_BIT_MASK(n) (((n) == 64) ? ~0ULL : ((1ULL << (n)) - 1)) CHECK:CAMELCASE: Avoid CamelCase: <_DescStatusBit> #389: FILE: drivers/net/r8169/r8169_rxtx.c:58: +enum _DescStatusBit { CHECK:CAMELCASE: Avoid CamelCase: #390: FILE: drivers/net/r8169/r8169_rxtx.c:59: + DescOwn = (1 << 31), /* Descriptor is owned by NIC. */ CHECK:CAMELCASE: Avoid CamelCase: #391: FILE: drivers/net/r8169/r8169_rxtx.c:60: + RingEnd = (1 << 30), /* End of descriptor ring */ CHECK:CAMELCASE: Avoid CamelCase: #392: FILE: drivers/net/r8169/r8169_rxtx.c:61: + FirstFrag = (1 << 29), /* First segment of a packet */ CHECK:CAMELCASE: Avoid CamelCase: #393: FILE: drivers/net/r8169/r8169_rxtx.c:62: + LastFrag = (1 << 28), /* Final segment of a packet */ CHECK:CAMELCASE: Avoid CamelCase: #395: FILE: drivers/net/r8169/r8169_rxtx.c:64: + DescOwn_V3 = DescOwn, /* Descriptor is owned by NIC. */ CHECK:CAMELCASE: Avoid CamelCase: #396: FILE: drivers/net/r8169/r8169_rxtx.c:65: + RingEnd_V3 = RingEnd, /* End of descriptor ring */ CHECK:CAMELCASE: Avoid CamelCase: #397: FILE: drivers/net/r8169/r8169_rxtx.c:66: + FirstFrag_V3 = (1 << 25), /* First segment of a packet */ CHECK:CAMELCASE: Avoid CamelCase: #398: FILE: drivers/net/r8169/r8169_rxtx.c:67: + LastFrag_V3 = (1 << 24), /* Final segment of a packet */ CHECK:CAMELCASE: Avoid CamelCase: #402: FILE: drivers/net/r8169/r8169_rxtx.c:71: + LargeSend = (1 << 27), /* TCP Large Send Offload (TSO) */ CHECK:CAMELCASE: Avoid CamelCase: #403: FILE: drivers/net/r8169/r8169_rxtx.c:72: + GiantSendv4 = (1 << 26), /* TCP Giant Send Offload V4 (GSOv4) */ CHECK:CAMELCASE: Avoid CamelCase: #404: FILE: drivers/net/r8169/r8169_rxtx.c:73: + GiantSendv6 = (1 << 25), /* TCP Giant Send Offload V6 (GSOv6) */ CHECK:CAMELCASE: Avoid CamelCase: #405: FILE: drivers/net/r8169/r8169_rxtx.c:74: + LargeSend_DP = (1 << 16), /* TCP Large Send Offload (TSO) */ CHECK:CAMELCASE: Avoid CamelCase: #406: FILE: drivers/net/r8169/r8169_rxtx.c:75: + MSSShift = 16, /* MSS value position */ CHECK:CAMELCASE: Avoid CamelCase: #407: FILE: drivers/net/r8169/r8169_rxtx.c:76: + MSSMask = 0x7FFU, /* MSS value 11 bits */ CHECK:CAMELCASE: Avoid CamelCase: #408: FILE: drivers/net/r8169/r8169_rxtx.c:77: + TxIPCS = (1 << 18), /* Calculate IP checksum */ CHECK:CAMELCASE: Avoid CamelCase: #409: FILE: drivers/net/r8169/r8169_rxtx.c:78: + TxUDPCS = (1 << 17), /* Calculate UDP/IP checksum */ CHECK:CAMELCASE: Avoid CamelCase: #410: FILE: drivers/net/r8169/r8169_rxtx.c:79: + TxTCPCS = (1 << 16), /* Calculate TCP/IP checksum */ CHECK:CAMELCASE: Avoid CamelCase: #411: FILE: drivers/net/r8169/r8169_rxtx.c:80: + TxVlanTag = (1 << 17), /* Add VLAN tag */ CHECK:CAMELCASE: Avoid CamelCase: #414: FILE: drivers/net/r8169/r8169_rxtx.c:83: + TxUDPCS_C = (1 << 31), /* Calculate UDP/IP checksum */ CHECK:CAMELCASE: Avoid CamelCase: #415: FILE: drivers/net/r8169/r8169_rxtx.c:84: + TxTCPCS_C = (1 << 30), /* Calculate TCP/IP checksum */ CHECK:CAMELCASE: Avoid CamelCase: #416: FILE: drivers/net/r8169/r8169_rxtx.c:85: + TxIPCS_C = (1 << 29), /* Calculate IP checksum */ CHECK:CAMELCASE: Avoid CamelCase: #417: FILE: drivers/net/r8169/r8169_rxtx.c:86: + TxIPV6F_C = (1 << 28), /* Indicate it is an IPv6 packet */ CHECK:CAMELCASE: Avoid CamelCase: #425: FILE: drivers/net/r8169/r8169_rxtx.c:94: +#define RxProtoUDP PID1 CHECK:CAMELCASE: Avoid CamelCase: #426: FILE: drivers/net/r8169/r8169_rxtx.c:95: +#define RxProtoTCP PID0 CHECK:CAMELCASE: Avoid CamelCase: #427: FILE: drivers/net/r8169/r8169_rxtx.c:96: +#define RxProtoIP (PID1 | PID0) CHECK:CAMELCASE: Avoid CamelCase: #428: FILE: drivers/net/r8169/r8169_rxtx.c:97: +#define RxProtoMask RxProtoIP CHECK:CAMELCASE: Avoid CamelCase: #430: FILE: drivers/net/r8169/r8169_rxtx.c:99: + RxIPF = (1 << 16), /* IP checksum failed */ CHECK:CAMELCASE: Avoid CamelCase: #431: FILE: drivers/net/r8169/r8169_rxtx.c:100: + RxUDPF = (1 << 15), /* UDP/IP checksum failed */ CHECK:CAMELCASE: Avoid CamelCase: #432: FILE: drivers/net/r8169/r8169_rxtx.c:101: + RxTCPF = (1 << 14), /* TCP/IP checksum failed */ CHECK:CAMELCASE: Avoid CamelCase: #433: FILE: drivers/net/r8169/r8169_rxtx.c:102: + RxVlanTag = (1 << 16), /* VLAN tag available */ CHECK:CAMELCASE: Avoid CamelCase: #436: FILE: drivers/net/r8169/r8169_rxtx.c:105: + RxUDPT = (1 << 18), CHECK:CAMELCASE: Avoid CamelCase: #437: FILE: drivers/net/r8169/r8169_rxtx.c:106: + RxTCPT = (1 << 17), CHECK:CAMELCASE: Avoid CamelCase: #441: FILE: drivers/net/r8169/r8169_rxtx.c:110: + RxV6F = (1 << 31), CHECK:CAMELCASE: Avoid CamelCase: #442: FILE: drivers/net/r8169/r8169_rxtx.c:111: + RxV4F = (1 << 30), CHECK:CAMELCASE: Avoid CamelCase: #448: FILE: drivers/net/r8169/r8169_rxtx.c:117: +#define RxProtoUDP_v3 PID1_v3 CHECK:CAMELCASE: Avoid CamelCase: #449: FILE: drivers/net/r8169/r8169_rxtx.c:118: +#define RxProtoTCP_v3 PID0_v3 CHECK:CAMELCASE: Avoid CamelCase: #450: FILE: drivers/net/r8169/r8169_rxtx.c:119: +#define RxProtoIP_v3 (PID1_v3 | PID0_v3) CHECK:CAMELCASE: Avoid CamelCase: #451: FILE: drivers/net/r8169/r8169_rxtx.c:120: +#define RxProtoMask_v3 RxProtoIP_v3 CHECK:CAMELCASE: Avoid CamelCase: #453: FILE: drivers/net/r8169/r8169_rxtx.c:122: + RxIPF_v3 = (1 << 26), /* IP checksum failed */ CHECK:CAMELCASE: Avoid CamelCase: #454: FILE: drivers/net/r8169/r8169_rxtx.c:123: + RxUDPF_v3 = (1 << 25), /* UDP/IP checksum failed */ CHECK:CAMELCASE: Avoid CamelCase: #455: FILE: drivers/net/r8169/r8169_rxtx.c:124: + RxTCPF_v3 = (1 << 24), /* TCP/IP checksum failed */ CHECK:CAMELCASE: Avoid CamelCase: #456: FILE: drivers/net/r8169/r8169_rxtx.c:125: + RxSCTPF_v3 = (1 << 23), /* TCP/IP checksum failed */ CHECK:CAMELCASE: Avoid CamelCase: #457: FILE: drivers/net/r8169/r8169_rxtx.c:126: + RxVlanTag_v3 = (RxVlanTag), /* VLAN tag available */ CHECK:CAMELCASE: Avoid CamelCase: #460: FILE: drivers/net/r8169/r8169_rxtx.c:129: + RxUDPT_v3 = (1 << 29), CHECK:CAMELCASE: Avoid CamelCase: #461: FILE: drivers/net/r8169/r8169_rxtx.c:130: + RxTCPT_v3 = (1 << 28), CHECK:CAMELCASE: Avoid CamelCase: #462: FILE: drivers/net/r8169/r8169_rxtx.c:131: + RxSCTP_v3 = (1 << 27), CHECK:CAMELCASE: Avoid CamelCase: #466: FILE: drivers/net/r8169/r8169_rxtx.c:135: + RxV6F_v3 = RxV6F, CHECK:CAMELCASE: Avoid CamelCase: #467: FILE: drivers/net/r8169/r8169_rxtx.c:136: + RxV4F_v3 = RxV4F, CHECK:CAMELCASE: Avoid CamelCase: #677: FILE: drivers/net/r8169/r8169_rxtx.c:342: + rx_config = RTL_R32(hw, RxConfig); CHECK:CAMELCASE: Avoid CamelCase: #679: FILE: drivers/net/r8169/r8169_rxtx.c:344: + rx_config |= (EnableInnerVlan | EnableOuterVlan); CHECK:CAMELCASE: Avoid CamelCase: #679: FILE: drivers/net/r8169/r8169_rxtx.c:344: + rx_config |= (EnableInnerVlan | EnableOuterVlan); CHECK:CAMELCASE: Avoid CamelCase: #685: FILE: drivers/net/r8169/r8169_rxtx.c:350: + cp_cmd = RTL_R16(hw, CPlusCmd); CHECK:CAMELCASE: Avoid CamelCase: #688: FILE: drivers/net/r8169/r8169_rxtx.c:353: + cp_cmd |= RxChkSum; CHECK:CAMELCASE: Avoid CamelCase: #704: FILE: drivers/net/r8169/r8169_rxtx.c:369: + rx_mode = AcceptBroadcast | AcceptMyPhys; CHECK:CAMELCASE: Avoid CamelCase: #704: FILE: drivers/net/r8169/r8169_rxtx.c:369: + rx_mode = AcceptBroadcast | AcceptMyPhys; CHECK:CAMELCASE: Avoid CamelCase: #724: FILE: drivers/net/r8169/r8169_rxtx.c:389: + RTL_W32(hw, RxDescAddrLow, ((u64)rxq->hw_ring_phys_addr & DMA_BIT_MASK(32))); CHECK:CAMELCASE: Avoid CamelCase: #725: FILE: drivers/net/r8169/r8169_rxtx.c:390: + RTL_W32(hw, RxDescAddrHigh, ((u64)rxq->hw_ring_phys_addr >> 32)); CHECK:CAMELCASE: Avoid CamelCase: #740: FILE: drivers/net/r8169/r8169_rxtx.c:405: + RTL_W16(hw, RxMaxSize, max_rx_pkt_size); CHECK:CAMELCASE: Avoid CamelCase: #760: FILE: drivers/net/r8169/r8169_rxtx.c:425: + RTL_W8(hw, ChipCmd, RTL_R8(hw, ChipCmd) | CmdRxEnb); CHECK:CAMELCASE: Avoid CamelCase: #760: FILE: drivers/net/r8169/r8169_rxtx.c:425: + RTL_W8(hw, ChipCmd, RTL_R8(hw, ChipCmd) | CmdRxEnb); CHECK:CAMELCASE: Avoid CamelCase: #838: FILE: drivers/net/r8169/r8169_rxtx.c:503: + if (unlikely(opts1 & RxRES)) { CHECK:CAMELCASE: Avoid CamelCase: #919: FILE: drivers/net/r8169/r8169_rxtx.c:584: + RTL_W32(hw, ISR0_8125, (RxOK | RxErr | RxDescUnavail)); CHECK:CAMELCASE: Avoid CamelCase: #919: FILE: drivers/net/r8169/r8169_rxtx.c:584: + RTL_W32(hw, ISR0_8125, (RxOK | RxErr | RxDescUnavail)); CHECK:CAMELCASE: Avoid CamelCase: #919: FILE: drivers/net/r8169/r8169_rxtx.c:584: + RTL_W32(hw, ISR0_8125, (RxOK | RxErr | RxDescUnavail)); total: 0 errors, 0 warnings, 66 checks, 1038 lines checked