automatic DPDK test reports
 help / color / mirror / Atom feed
From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Howard Wang <howard_wang@realsil.com.cn>
Subject: |WARNING| pw148401 [PATCH v8 10/17] net/r8169: add link status and interrupt management
Date: Wed, 13 Nov 2024 10:34:02 +0100 (CET)	[thread overview]
Message-ID: <20241113093402.CD38E12314F@dpdk.org> (raw)
In-Reply-To: <20241113092854.91445-11-howard_wang@realsil.com.cn>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/148401

_coding style issues_


WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one

CHECK:CAMELCASE: Avoid CamelCase: <LinkChg>
#151: FILE: drivers/net/r8169/r8169_ethdev.c:78:
+	RTL_W32(hw, IMR0_8125, LinkChg);

CHECK:CAMELCASE: Avoid CamelCase: <PHYstatus>
#236: FILE: drivers/net/r8169/r8169_ethdev.c:163:
+		if (!(RTL_R16(hw, PHYstatus) & LinkStatus)) {

CHECK:CAMELCASE: Avoid CamelCase: <LinkStatus>
#236: FILE: drivers/net/r8169/r8169_ethdev.c:163:
+		if (!(RTL_R16(hw, PHYstatus) & LinkStatus)) {

CHECK:CAMELCASE: Avoid CamelCase: <FullDup>
#360: FILE: drivers/net/r8169/r8169_ethdev.c:313:
+		if (status & FullDup) {

CHECK:CAMELCASE: Avoid CamelCase: <TxConfig>
#363: FILE: drivers/net/r8169/r8169_ethdev.c:316:
+				RTL_W32(hw, TxConfig, (RTL_R32(hw, TxConfig) |

CHECK:CAMELCASE: Avoid CamelCase: <HwSuppMaxPhyLinkSpeed>
#514: FILE: drivers/net/r8169/r8169_hw.c:1091:
+		hw->HwSuppMaxPhyLinkSpeed = SPEED_2500;

WARNING:TYPO_SPELLING: 'lite' may be misspelled - perhaps 'light'?
#590: FILE: drivers/net/r8169/r8169_phy.c:821:
+	/* Disable giga lite */

total: 0 errors, 2 warnings, 6 checks, 548 lines checked

           reply	other threads:[~2024-11-13  9:34 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <20241113092854.91445-11-howard_wang@realsil.com.cn>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241113093402.CD38E12314F@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=howard_wang@realsil.com.cn \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).