* |WARNING| pw148969 [PATCH v1 17/21] net/iavf: use common Tx queue mbuf cleanup fn
[not found] <20241202112444.1517416-18-bruce.richardson@intel.com>
@ 2024-12-02 11:29 ` checkpatch
0 siblings, 0 replies; only message in thread
From: checkpatch @ 2024-12-02 11:29 UTC (permalink / raw)
To: test-report; +Cc: Bruce Richardson
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/148969
_coding style issues_
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'swr' - possible side-effects?
#102: FILE: drivers/net/_common_intel/tx.h:275:
+#define IETH_FREE_BUFS_LOOP(swr, nb_desc, start, end) do { \
uint16_t i = start; \
+ if (end < i) { \
+ for (; i < nb_desc; i++) { \
rte_pktmbuf_free_seg(swr[i].mbuf); \
swr[i].mbuf = NULL; \
} \
i = 0; \
} \
+ for (; i < end; i++) { \
rte_pktmbuf_free_seg(swr[i].mbuf); \
swr[i].mbuf = NULL; \
} \
} while (0)
CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'nb_desc' may be better as '(nb_desc)' to avoid precedence issues
#102: FILE: drivers/net/_common_intel/tx.h:275:
+#define IETH_FREE_BUFS_LOOP(swr, nb_desc, start, end) do { \
uint16_t i = start; \
+ if (end < i) { \
+ for (; i < nb_desc; i++) { \
rte_pktmbuf_free_seg(swr[i].mbuf); \
swr[i].mbuf = NULL; \
} \
i = 0; \
} \
+ for (; i < end; i++) { \
rte_pktmbuf_free_seg(swr[i].mbuf); \
swr[i].mbuf = NULL; \
} \
} while (0)
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'end' - possible side-effects?
#102: FILE: drivers/net/_common_intel/tx.h:275:
+#define IETH_FREE_BUFS_LOOP(swr, nb_desc, start, end) do { \
uint16_t i = start; \
+ if (end < i) { \
+ for (; i < nb_desc; i++) { \
rte_pktmbuf_free_seg(swr[i].mbuf); \
swr[i].mbuf = NULL; \
} \
i = 0; \
} \
+ for (; i < end; i++) { \
rte_pktmbuf_free_seg(swr[i].mbuf); \
swr[i].mbuf = NULL; \
} \
} while (0)
CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'end' may be better as '(end)' to avoid precedence issues
#102: FILE: drivers/net/_common_intel/tx.h:275:
+#define IETH_FREE_BUFS_LOOP(swr, nb_desc, start, end) do { \
uint16_t i = start; \
+ if (end < i) { \
+ for (; i < nb_desc; i++) { \
rte_pktmbuf_free_seg(swr[i].mbuf); \
swr[i].mbuf = NULL; \
} \
i = 0; \
} \
+ for (; i < end; i++) { \
rte_pktmbuf_free_seg(swr[i].mbuf); \
swr[i].mbuf = NULL; \
} \
} while (0)
total: 0 errors, 0 warnings, 4 checks, 287 lines checked
^ permalink raw reply [flat|nested] only message in thread