From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1BCEF45E2D for ; Wed, 4 Dec 2024 10:51:26 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 09E3D40E49; Wed, 4 Dec 2024 10:51:26 +0100 (CET) Received: from dpdk.org (dpdk.org [92.243.24.197]) by mails.dpdk.org (Postfix) with ESMTP id 9040440E48 for ; Wed, 4 Dec 2024 10:51:24 +0100 (CET) Received: by dpdk.org (Postfix, from userid 65534) id 731B41234FA; Wed, 4 Dec 2024 10:51:24 +0100 (CET) Subject: |WARNING| pw149015 [PATCH] lib/gso: rte_gso_segment function increases the processing of ipv6 tcp packets In-Reply-To: <20241204024430.2749-1-18859237562@163.com> References: <20241204024430.2749-1-18859237562@163.com> To: test-report@dpdk.org From: checkpatch@dpdk.org Cc: liaocaiqiang <18859237562@163.com> Message-Id: <20241204095124.731B41234FA@dpdk.org> Date: Wed, 4 Dec 2024 10:51:24 +0100 (CET) X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/149015 _coding style issues_ WARNING:LEADING_SPACE: please, no spaces at the start of a line #122: FILE: lib/gso/gso_common.h:144: + struct rte_ipv6_hdr *ipv6_hdr;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #124: FILE: lib/gso/gso_common.h:146: + ipv6_hdr = (struct rte_ipv6_hdr *)(rte_pktmbuf_mtod(pkt, char *) +$ ERROR:CODE_INDENT: code indent should use tabs where possible #125: FILE: lib/gso/gso_common.h:147: + l3_offset);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #125: FILE: lib/gso/gso_common.h:147: + l3_offset);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #126: FILE: lib/gso/gso_common.h:148: + ipv6_hdr->payload_len = htons(pkt->pkt_len - l3_offset - sizeof(struct rte_ipv6_hdr));$ ERROR:CODE_INDENT: code indent should use tabs where possible #148: FILE: lib/gso/gso_tcp6.c:10: + uint16_t nb_segs)$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #148: FILE: lib/gso/gso_tcp6.c:10: + uint16_t nb_segs)$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #150: FILE: lib/gso/gso_tcp6.c:12: + struct rte_ipv6_hdr *ipv6_hdr;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #151: FILE: lib/gso/gso_tcp6.c:13: + struct rte_tcp_hdr *tcp_hdr;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #152: FILE: lib/gso/gso_tcp6.c:14: + uint32_t sent_seq;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #153: FILE: lib/gso/gso_tcp6.c:15: + uint16_t tail_idx, i;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #154: FILE: lib/gso/gso_tcp6.c:16: + uint16_t l3_offset = pkt->l2_len;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #155: FILE: lib/gso/gso_tcp6.c:17: + uint16_t l4_offset = l3_offset + pkt->l3_len;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #157: FILE: lib/gso/gso_tcp6.c:19: + ipv6_hdr = (struct rte_ipv6_hdr *)(rte_pktmbuf_mtod(pkt, char*) +$ ERROR:CODE_INDENT: code indent should use tabs where possible #158: FILE: lib/gso/gso_tcp6.c:20: + l3_offset);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #158: FILE: lib/gso/gso_tcp6.c:20: + l3_offset);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #159: FILE: lib/gso/gso_tcp6.c:21: + tcp_hdr = (struct rte_tcp_hdr *)((char *)ipv6_hdr + pkt->l3_len);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #160: FILE: lib/gso/gso_tcp6.c:22: + sent_seq = ntohl(tcp_hdr->sent_seq);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #161: FILE: lib/gso/gso_tcp6.c:23: + tail_idx = nb_segs - 1;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #163: FILE: lib/gso/gso_tcp6.c:25: + for (i = 0; i < nb_segs; i++) {$ ERROR:CODE_INDENT: code indent should use tabs where possible #164: FILE: lib/gso/gso_tcp6.c:26: + update_ipv6_header(segs[i], l3_offset);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #164: FILE: lib/gso/gso_tcp6.c:26: + update_ipv6_header(segs[i], l3_offset);$ ERROR:CODE_INDENT: code indent should use tabs where possible #165: FILE: lib/gso/gso_tcp6.c:27: + update_tcp_header(segs[i], l4_offset, sent_seq, i < tail_idx);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #165: FILE: lib/gso/gso_tcp6.c:27: + update_tcp_header(segs[i], l4_offset, sent_seq, i < tail_idx);$ ERROR:CODE_INDENT: code indent should use tabs where possible #166: FILE: lib/gso/gso_tcp6.c:28: + sent_seq += (segs[i]->pkt_len - segs[i]->data_len);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #166: FILE: lib/gso/gso_tcp6.c:28: + sent_seq += (segs[i]->pkt_len - segs[i]->data_len);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #167: FILE: lib/gso/gso_tcp6.c:29: + }$ WARNING:BRACES: braces {} are not necessary for single statement blocks #184: FILE: lib/gso/gso_tcp6.c:46: + if (hdr_offset >= pkt->pkt_len) { + return 0; + } WARNING:BRACES: braces {} are not necessary for single statement blocks #323: FILE: lib/gso/gso_tunnel_tcp6.c:68: + if (hdr_offset >= pkt->pkt_len) { + return 0; + } WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 32) #436: FILE: lib/gso/rte_gso.c:92: + } else if ((IS_IPV6_TCP(pkt->ol_flags) && [...] + pkt->ol_flags &= (~RTE_MBUF_F_TX_TCP_SEG); ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s) total: 7 errors, 24 warnings, 329 lines checked