* |WARNING| pw149344 [PATCH v4 14/24] net/ice: move Tx queue mbuf cleanup fn to common
[not found] <20241220143925.609044-15-bruce.richardson@intel.com>
@ 2024-12-20 14:42 ` checkpatch
0 siblings, 0 replies; only message in thread
From: checkpatch @ 2024-12-20 14:42 UTC (permalink / raw)
To: test-report; +Cc: Bruce Richardson
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/149344
_coding style issues_
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'txq' - possible side-effects?
#117: FILE: drivers/net/_common_intel/tx.h:274:
+#define IETH_FREE_BUFS_LOOP(txq, swr, start) do { \
+ uint16_t i = start; \
+ if (txq->tx_tail < i) { \
+ for (; i < txq->nb_tx_desc; i++) { \
+ rte_pktmbuf_free_seg(swr[i].mbuf); \
+ swr[i].mbuf = NULL; \
+ } \
+ i = 0; \
+ } \
+ for (; i < txq->tx_tail; i++) { \
+ rte_pktmbuf_free_seg(swr[i].mbuf); \
+ swr[i].mbuf = NULL; \
+ } \
+} while (0)
CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'txq' may be better as '(txq)' to avoid precedence issues
#117: FILE: drivers/net/_common_intel/tx.h:274:
+#define IETH_FREE_BUFS_LOOP(txq, swr, start) do { \
+ uint16_t i = start; \
+ if (txq->tx_tail < i) { \
+ for (; i < txq->nb_tx_desc; i++) { \
+ rte_pktmbuf_free_seg(swr[i].mbuf); \
+ swr[i].mbuf = NULL; \
+ } \
+ i = 0; \
+ } \
+ for (; i < txq->tx_tail; i++) { \
+ rte_pktmbuf_free_seg(swr[i].mbuf); \
+ swr[i].mbuf = NULL; \
+ } \
+} while (0)
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'swr' - possible side-effects?
#117: FILE: drivers/net/_common_intel/tx.h:274:
+#define IETH_FREE_BUFS_LOOP(txq, swr, start) do { \
+ uint16_t i = start; \
+ if (txq->tx_tail < i) { \
+ for (; i < txq->nb_tx_desc; i++) { \
+ rte_pktmbuf_free_seg(swr[i].mbuf); \
+ swr[i].mbuf = NULL; \
+ } \
+ i = 0; \
+ } \
+ for (; i < txq->tx_tail; i++) { \
+ rte_pktmbuf_free_seg(swr[i].mbuf); \
+ swr[i].mbuf = NULL; \
+ } \
+} while (0)
total: 0 errors, 0 warnings, 3 checks, 250 lines checked
^ permalink raw reply [flat|nested] only message in thread