From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Sunyang Wu <sunyang.wu@jaguarmicro.com>
Subject: |WARNING| pw149383 [PATCH] app/test-flow-perf: support testing the flow table query rate
Date: Mon, 23 Dec 2024 09:37:34 +0100 (CET) [thread overview]
Message-ID: <20241223083734.2EDD5121F15@dpdk.org> (raw)
In-Reply-To: <20241223083554.37784-1-sunyang.wu@jaguarmicro.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/149383
_coding style issues_
ERROR:CODE_INDENT: code indent should use tabs where possible
#155: FILE: app/test-flow-perf/main.c:892:
+ ^I^I^I^Iquery_flag = true;$
WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#155: FILE: app/test-flow-perf/main.c:892:
+ ^I^I^I^Iquery_flag = true;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#155: FILE: app/test-flow-perf/main.c:892:
+ ^I^I^I^Iquery_flag = true;$
WARNING:TABSTOP: Statements should start on a tabstop
#181: FILE: app/test-flow-perf/main.c:1403:
+ {
WARNING:TABSTOP: Statements should start on a tabstop
#185: FILE: app/test-flow-perf/main.c:1407:
+ {
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 17)
#192: FILE: app/test-flow-perf/main.c:1414:
+ if (flow_group > 0 && core_id == 0)
+ rules_count_per_core++;
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 17)
#197: FILE: app/test-flow-perf/main.c:1419:
+ for (i = 0; i < (uint32_t)rules_count_per_core; i++) {
+ if (flows_list[i] == 0)
WARNING:TABSTOP: Statements should start on a tabstop
#198: FILE: app/test-flow-perf/main.c:1420:
+ if (flows_list[i] == 0)
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (17, 26)
#198: FILE: app/test-flow-perf/main.c:1420:
+ if (flows_list[i] == 0)
+ break;
WARNING:TABSTOP: Statements should start on a tabstop
#199: FILE: app/test-flow-perf/main.c:1421:
+ break;
WARNING:TABSTOP: Statements should start on a tabstop
#202: FILE: app/test-flow-perf/main.c:1424:
+ if (rte_flow_query(port_id, flows_list[i],
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (17, 26)
#202: FILE: app/test-flow-perf/main.c:1424:
+ if (rte_flow_query(port_id, flows_list[i],
[...]
+ print_flow_error(error);
WARNING:TABSTOP: Statements should start on a tabstop
#206: FILE: app/test-flow-perf/main.c:1428:
+ }
WARNING:TABSTOP: Statements should start on a tabstop
#214: FILE: app/test-flow-perf/main.c:1436:
+ if (!((i + 1) % rules_batch)) {
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (17, 26)
#214: FILE: app/test-flow-perf/main.c:1436:
+ if (!((i + 1) % rules_batch)) {
+ end_batch = rte_get_timer_cycles();
WARNING:TABSTOP: Statements should start on a tabstop
#221: FILE: app/test-flow-perf/main.c:1443:
+ }
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 17)
#225: FILE: app/test-flow-perf/main.c:1447:
+ if (dump_iterations)
+ print_rules_batches(cpu_time_per_batch);
total: 1 errors, 16 warnings, 210 lines checked
next prev parent reply other threads:[~2024-12-23 8:37 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20241223083554.37784-1-sunyang.wu@jaguarmicro.com>
2024-12-23 8:05 ` |SUCCESS| " qemudev
2024-12-23 8:09 ` qemudev
2024-12-23 8:37 ` checkpatch [this message]
2024-12-23 9:12 ` |PENDING| pw149383 [PATCH] app/test-flow-perf: support testing the f dpdklab
2024-12-23 9:12 ` dpdklab
2024-12-23 9:16 ` |SUCCESS| " dpdklab
2024-12-23 9:16 ` dpdklab
2024-12-23 9:17 ` dpdklab
2024-12-23 9:21 ` dpdklab
2024-12-23 9:31 ` dpdklab
2024-12-23 9:36 ` dpdklab
2024-12-23 9:38 ` dpdklab
2024-12-23 9:46 ` dpdklab
2024-12-23 10:03 ` dpdklab
2024-12-23 10:09 ` |WARNING| " dpdklab
2024-12-23 10:15 ` |SUCCESS| " dpdklab
2024-12-23 10:24 ` dpdklab
2024-12-23 11:45 ` dpdklab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241223083734.2EDD5121F15@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=sunyang.wu@jaguarmicro.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).