From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0D40245F89 for ; Mon, 30 Dec 2024 17:01:48 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E648340272; Mon, 30 Dec 2024 17:01:47 +0100 (CET) Received: from dpdk.org (dpdk.org [92.243.24.197]) by mails.dpdk.org (Postfix) with ESMTP id 8E32340263 for ; Mon, 30 Dec 2024 17:01:46 +0100 (CET) Received: by dpdk.org (Postfix, from userid 65534) id BFC5C126FB8; Mon, 30 Dec 2024 17:01:19 +0100 (CET) Subject: |WARNING| pw149514 [PATCH v4 3/3] drivers/net: add diagnostics macros to make code portable In-Reply-To: <1735574370-22090-4-git-send-email-andremue@linux.microsoft.com> References: <1735574370-22090-4-git-send-email-andremue@linux.microsoft.com> To: test-report@dpdk.org From: checkpatch@dpdk.org Cc: Andre Muezerie Message-Id: <20241230160119.BFC5C126FB8@dpdk.org> Date: Mon, 30 Dec 2024 17:01:19 +0100 (CET) X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/149514 _coding style issues_ WARNING:AVOID_EXTERNS: externs should be avoided in .c files #224: FILE: drivers/net/fm10k/fm10k_rxtx_vec.c:473: +__rte_diagnostic_pop WARNING:AVOID_EXTERNS: externs should be avoided in .c files #399: FILE: drivers/net/i40e/i40e_rxtx_vec_altivec.c:296: +__rte_diagnostic_pop WARNING:AVOID_EXTERNS: externs should be avoided in .c files #708: FILE: drivers/net/i40e/i40e_rxtx_vec_sse.c:473: +__rte_diagnostic_pop WARNING:AVOID_EXTERNS: externs should be avoided in .c files #1040: FILE: drivers/net/iavf/iavf_rxtx_vec_sse.c:586: +__rte_diagnostic_pop WARNING:AVOID_EXTERNS: externs should be avoided in .c files #1075: FILE: drivers/net/iavf/iavf_rxtx_vec_sse.c:878: +__rte_diagnostic_pop WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (24, 0) #1218: FILE: drivers/net/ice/ice_rxtx_vec_avx2.c:443: if (rxq->vsi->adapter->pf.dev_data->dev_conf.rxmode.offloads & [...] +__rte_diagnostic_push WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (24, 0) #1290: FILE: drivers/net/ice/ice_rxtx_vec_avx512.c:473: if (rxq->vsi->adapter->pf.dev_data->dev_conf.rxmode.offloads & [...] +__rte_diagnostic_push WARNING:AVOID_EXTERNS: externs should be avoided in .c files #1389: FILE: drivers/net/ice/ice_rxtx_vec_sse.c:433: +__rte_diagnostic_pop WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (16, 0) #1409: FILE: drivers/net/ice/ice_rxtx_vec_sse.c:497: if (rxq->vsi->adapter->pf.dev_data->dev_conf.rxmode.offloads & [...] +__rte_diagnostic_push WARNING:AVOID_EXTERNS: externs should be avoided in .c files #1523: FILE: drivers/net/ixgbe/ixgbe_rxtx_vec_sse.c:474: +__rte_diagnostic_pop ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line #1633: FILE: drivers/net/mlx5/mlx5_rxtx_vec_sse.h:133: +__rte_diagnostic_pop for (pos = 0; pos < mcqe_n; ) { WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (24, 0) #1657: FILE: drivers/net/mlx5/mlx5_rxtx_vec_sse.h:359: if (!(pos & 0x7) && pos < mcqe_n) { +__rte_diagnostic_push total: 1 errors, 11 warnings, 0 checks, 1367 lines checked