From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CFABB46010 for ; Tue, 7 Jan 2025 19:13:15 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BECE840150; Tue, 7 Jan 2025 19:13:15 +0100 (CET) Received: from mail.loongson.cn (mail.loongson.cn [114.242.206.163]) by mails.dpdk.org (Postfix) with ESMTP id 313594014F for ; Tue, 7 Jan 2025 19:13:13 +0100 (CET) Received: from loongson.cn (unknown [10.40.64.71]) by gateway (Coremail) with SMTP id _____8Bx33O3bn1nonFfAA--.2076S3; Wed, 08 Jan 2025 02:13:11 +0800 (CST) Received: from localhost.localdomain (unknown [10.40.64.71]) by front1 (Coremail) with SMTP id qMiowMBxTMW2bn1n7YAYAA--.38947S3; Wed, 08 Jan 2025 02:13:10 +0800 (CST) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by localhost.localdomain (8.15.2/8.15.2) with ESMTPS id 507HdifI3167455 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 8 Jan 2025 01:39:44 +0800 Received: (from root@localhost) by localhost.localdomain (8.15.2/8.15.2/Submit) id 507Hdh6B3167454; Wed, 8 Jan 2025 01:39:43 +0800 Date: Wed, 8 Jan 2025 01:39:43 +0800 From: qemudev@loongson.cn Message-Id: <202501071739.507Hdh6B3167454@localhost.localdomain> Content-Type: text/plain; charset="utf-8" Subject: |WARNING| pw149670-149671 [v2 1/2] crypto/virtio: refactor queue operations In-Reply-To: <4c5700d4acaff81d7f17ab9ceb7637d5c22bd009.1736270226.git.gmuthukrishn@marvell.com> References: <4c5700d4acaff81d7f17ab9ceb7637d5c22bd009.1736270226.git.gmuthukrishn@marvell.com> To: test-report@dpdk.org Cc: Gowrishankar Muthukrishnan , zhoumin@loongson.cn X-CM-TRANSID: qMiowMBxTMW2bn1n7YAYAA--.38947S3 X-CM-SenderInfo: pthp3vthy6z05rqj20fqof0/1tbiAQEPD2d8XMQZ5AAAs+ X-Coremail-Antispam: 1Uk129KBj93XoW3Xw4rGF4rKFW5XrWkAryfZrc_yoW7tr1rpr W5GrZ3XrWrJrW2ga4rJF1fWryFyasxuFZxKFyrX345Wa1a9F1xtF17ArWj9ay3Xr1DCwnr AF4xW3yjganruFXCm3ZEXasCq-sJn29KB7ZKAUJUUUUU529EdanIXcx71UUUUU7KY7ZEXa sCq-sGcSsGvfJ3Ic02F40EFcxC0VAKzVAqx4xG6I80ebIjqfuFe4nvWSU5nxnvy29KBjDU 0xBIdaVrnRJUUUk0b4IE77IF4wAFF20E14v26r1j6r4UM7CY07I20VC2zVCF04k26cxKx2 IYs7xG6rWj6s0DM7CIcVAFz4kK6r106r15M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48v e4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_Xr0_Ar1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI 0_Gr0_Cr1l84ACjcxK6I8E87Iv67AKxVW8Jr0_Cr1UM28EF7xvwVC2z280aVCY1x0267AK xVW8Jr0_Cr1UM2AIxVAIcxkEcVAq07x20xvEncxIr21l57IF6xkI12xvs2x26I8E6xACxx 1l5I8CrVACY4xI64kE6c02F40Ex7xfMcIj6xIIjxv20xvE14v26r1Y6r17McIj6I8E87Iv 67AKxVWUJVW8JwAm72CE4IkC6x0Yz7v_Jr0_Gr1lw4CEc2x0rVAKj4xxMxAIw28IcxkI7V AKI48JMxC20s026xCaFVCjc4AY6r1j6r4UMI8I3I0E5I8CrVAFwI0_Jr0_Jr4lx2IqxVCj r7xvwVAFwI0_JrI_JrWlx4CE17CEb7AF67AKxVWUXVWUAwCIc40Y0x0EwIxGrwCI42IY6x IIjxv20xvE14v26r1j6r1xMIIF0xvE2Ix0cI8IcVCY1x0267AKxVWUJVW8JwCI42IY6xAI w20EY4v20xvaj40_Jr0_JF4lIxAIcVC2z280aVAFwI0_Jr0_Gr1lIxAIcVC2z280aVCY1x 0267AKxVWUJVW8JbIYCTnIWIevJa73UjIFyTuYvjxU2FksDUUUU X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Test-Label: loongarch-compilation Test-Status: WARNING http://dpdk.org/patch/149670 _apply patch failure_ Submitter: Gowrishankar Muthukrishnan Date: Tue, 7 Jan 2025 23:38:28 +0530 DPDK git baseline: Repo:dpdk-next-crypto Branch: for-main CommitID: 7df61db6c387703a36306c1aea92225921e2eeb2 Apply patch set 149670-149671 failed: Checking patch drivers/crypto/virtio/meson.build... Checking patch drivers/crypto/virtio/virtio_crypto_algs.h... Checking patch drivers/crypto/virtio/virtio_cryptodev.c... error: while searching for: uint8_t cryptodev_virtio_driver_id; #define NUM_ENTRY_SYM_CREATE_SESSION 4 static int virtio_crypto_send_command(struct virtqueue *vq, struct virtio_crypto_op_ctrl_req *ctrl, uint8_t *cipher_key, uint8_t *auth_key, struct virtio_crypto_session *session) { uint8_t idx = 0; uint8_t needed = 1; uint32_t head = 0; uint32_t len_cipher_key = 0; uint32_t len_auth_key = 0; uint32_t len_ctrl_req = sizeof(struct virtio_crypto_op_ctrl_req); uint32_t len_session_input = sizeof(struct virtio_crypto_session_input); uint32_t len_total = 0; uint32_t input_offset = 0; void *virt_addr_started = NULL; phys_addr_t phys_addr_started; struct vring_desc *desc; uint32_t desc_offset; struct virtio_crypto_session_input *input; int ret; PMD_INIT_FUNC_TRACE(); if (session == NULL) { VIRTIO_CRYPTO_SESSION_LOG_ERR("session is NULL."); return -EINVAL; } /* cipher only is supported, it is available if auth_key is NULL */ if (session->ctrl.header.algo == VIRTIO_CRYPTO_SERVICE_CIPHER && !cipher_key) { VIRTIO_CRYPTO_SESSION_LOG_ERR("cipher key is NULL."); return -EINVAL; } head = vq->vq_desc_head_idx; VIRTIO_CRYPTO_INIT_LOG_DBG("vq->vq_desc_head_idx = %d, vq = %p", head, vq); if (vq->vq_free_cnt < needed) { VIRTIO_CRYPTO_SESSION_LOG_ERR("Not enough entry"); return -ENOSPC; } /* calculate the length of cipher key */ if (cipher_key) { if (session->ctrl.header.algo == VIRTIO_CRYPTO_SERVICE_CIPHER) { switch (ctrl->u.sym_create_session.op_type) { case VIRTIO_CRYPTO_SYM_OP_CIPHER: len_cipher_key = ctrl->u.sym_create_session.u.cipher.para.keylen; break; case VIRTIO_CRYPTO_SYM_OP_ALGORITHM_CHAINING: len_cipher_key = ctrl->u.sym_create_session.u.chain.para.cipher_param.keylen; break; default: VIRTIO_CRYPTO_SESSION_LOG_ERR("invalid op type"); return -EINVAL; } } else if (session->ctrl.header.algo == VIRTIO_CRYPTO_AKCIPHER_RSA) { len_cipher_key = ctrl->u.akcipher_create_session.para.keylen; } else { VIRTIO_CRYPTO_SESSION_LOG_ERR("Invalid crypto service for cipher key"); return -EINVAL; } } /* calculate the length of auth key */ if (auth_key) { len_auth_key = ctrl->u.sym_create_session.u.chain.para.u.mac_param .auth_key_len; } /* * malloc memory to store indirect vring_desc entries, including * ctrl request, cipher key, auth key, session input and desc vring */ desc_offset = len_ctrl_req + len_cipher_key + len_auth_key + len_session_input; virt_addr_started = rte_malloc(NULL, desc_offset + NUM_ENTRY_SYM_CREATE_SESSION * sizeof(struct vring_desc), RTE_CACHE_LINE_SIZE); if (virt_addr_started == NULL) { VIRTIO_CRYPTO_SESSION_LOG_ERR("not enough heap memory"); return -ENOSPC; } phys_addr_started = rte_malloc_virt2iova(virt_addr_started); /* address to store indirect vring desc entries */ desc = (struct vring_desc *) ((uint8_t *)virt_addr_started + desc_offset); /* ctrl req part */ memcpy(virt_addr_started, ctrl, len_ctrl_req); desc[idx].addr = phys_addr_started; desc[idx].len = len_ctrl_req; desc[idx].flags = VRING_DESC_F_NEXT; desc[idx].next = idx + 1; idx++; len_total += len_ctrl_req; input_offset += len_ctrl_req; /* cipher key part */ if (len_cipher_key > 0) { memcpy((uint8_t *)virt_addr_started + len_total, cipher_key, len_cipher_key); desc[idx].addr = phys_addr_started + len_total; desc[idx].len = len_cipher_key; desc[idx].flags = VRING_DESC_F_NEXT; desc[idx].next = idx + 1; idx++; len_total += len_cipher_key; input_offset += len_cipher_key; } /* auth key part */ if (len_auth_key > 0) { memcpy((uint8_t *)virt_addr_started + len_total, auth_key, len_auth_key); desc[idx].addr = phys_addr_started + len_total; desc[idx].len = len_auth_key; desc[idx].flags = VRING_DESC_F_NEXT; desc[idx].next = idx + 1; idx++; len_total += len_auth_key; input_offset += len_auth_key; } /* input part */ input = (struct virtio_crypto_session_input *) ((uint8_t *)virt_addr_started + input_offset); input->status = VIRTIO_CRYPTO_ERR; input->ses error: patch failed: drivers/crypto/virtio/virtio_cryptodev.c:64 error: drivers/crypto/virtio/virtio_cryptodev.c: patch does not apply Checking patch drivers/crypto/virtio/virtio_cvq.c... Checking patch drivers/crypto/virtio/virtio_cvq.h... Checking patch drivers/crypto/virtio/virtio_pci.h... Checking patch drivers/crypto/virtio/virtio_ring.h... Checking patch drivers/crypto/virtio/virtio_rxtx.c... error: while searching for: { struct rte_crypto_asym_op *asym_op = cop->asym; struct virtio_crypto_op_data_req *req_data = data; struct virtio_crypto_op_ctrl_req *ctrl = &session->ctrl; req_data->header.session_id = session->session_id; error: patch failed: drivers/crypto/virtio/virtio_rxtx.c:351 error: drivers/crypto/virtio/virtio_rxtx.c: patch does not apply Checking patch drivers/crypto/virtio/virtio_rxtx.h... Checking patch drivers/crypto/virtio/virtqueue.c... Checking patch drivers/crypto/virtio/virtqueue.h...