From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 79F8046054
	for <public@inbox.dpdk.org>; Mon, 13 Jan 2025 13:18:33 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 7230A40B9F;
	Mon, 13 Jan 2025 13:18:33 +0100 (CET)
Received: from dpdk.org (dpdk.org [92.243.24.197])
 by mails.dpdk.org (Postfix) with ESMTP id A919F402A7
 for <test-report@dpdk.org>; Mon, 13 Jan 2025 13:18:31 +0100 (CET)
Received: by dpdk.org (Postfix, from userid 65534)
 id 8BD6D126FBC; Mon, 13 Jan 2025 13:17:48 +0100 (CET)
Subject: |WARNING| pw149933 [RFC v4 1/1] eventdev: add atomic queue to
 test-eventdev app
In-Reply-To: <20250113121733.2384990-1-luka.jankovic@ericsson.com>
References: <20250113121733.2384990-1-luka.jankovic@ericsson.com>
To: test-report@dpdk.org
From: checkpatch@dpdk.org
Cc: Luka Jankovic <luka.jankovic@ericsson.com>
Message-Id: <20250113121748.8BD6D126FBC@dpdk.org>
Date: Mon, 13 Jan 2025 13:17:48 +0100 (CET)
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/149933

_coding style issues_


WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#110: 
Add an atomic queue test based on the order queue test that exclusively uses atomic queues.

WARNING:TYPO_SPELLING: 'stdio' may be misspelled - perhaps 'studio'?
#183: FILE: app/test-eventdev/test_atomic_queue.c:1:
+#include <stdio.h>

ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#337: FILE: app/test-eventdev/test_atomic_queue.c:155:
+		RTE_ATOMIC(uint64_t) *const outstand_pkts,
 		                     ^

WARNING:BRACES: braces {} are not necessary for single statement blocks
#381: FILE: app/test-eventdev/test_atomic_queue.c:199:
+			if (!flow_id_cap) {
+				ev[i].flow_id = event_data_get_flow(&ev[i]);
+			}

WARNING:BRACES: braces {} are not necessary for single statement blocks
#549: FILE: app/test-eventdev/test_atomic_queue.c:367:
+	for (uint32_t i = 0; i < num_locks; i++) {
+		rte_spinlock_init(&atomic_locks[i]);
+	}

total: 1 errors, 4 warnings, 434 lines checked