|WARNING| pw150716 [PATCH v1 05/42] net/e1000/base: add NVM/EEPROM support for i225

[checkpatch@dpdk.org]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/150716

_coding style issues_


ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#109: FILE: drivers/net/intel/e1000/base/e1000_defines.h:1496:
+#define INVM_DWORD_TO_RECORD_TYPE(invm_dword) \
+	(u8)((invm_dword) & 0x7)

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#111: FILE: drivers/net/intel/e1000/base/e1000_defines.h:1498:
+#define INVM_DWORD_TO_WORD_ADDRESS(invm_dword) \
+	(u8)(((invm_dword) & 0x0000FE00) >> 9)

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#113: FILE: drivers/net/intel/e1000/base/e1000_defines.h:1500:
+#define INVM_DWORD_TO_WORD_DATA(invm_dword) \
+	(u16)(((invm_dword) & 0xFFFF0000) >> 16)

WARNING:TYPO_SPELLING: 'unitialized' may be misspelled - perhaps 'uninitialized'?
#150: FILE: drivers/net/intel/e1000/base/e1000_hw.h:385:
+	e1000_invm_unitialized_structure		= 0x00,

WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#198: FILE: drivers/net/intel/e1000/base/e1000_i225.c:11:
+STATIC s32 e1000_acquire_nvm_i225(struct e1000_hw *hw);

WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#199: FILE: drivers/net/intel/e1000/base/e1000_i225.c:12:
+STATIC void e1000_release_nvm_i225(struct e1000_hw *hw);

WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#200: FILE: drivers/net/intel/e1000/base/e1000_i225.c:13:
+STATIC s32 e1000_get_hw_semaphore_i225(struct e1000_hw *hw);

WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#201: FILE: drivers/net/intel/e1000/base/e1000_i225.c:14:
+STATIC s32 __e1000_write_nvm_srwr(struct e1000_hw *hw, u16 offset, u16 words,

WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#203: FILE: drivers/net/intel/e1000/base/e1000_i225.c:16:
+STATIC s32 e1000_pool_flash_update_done_i225(struct e1000_hw *hw);

WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#204: FILE: drivers/net/intel/e1000/base/e1000_i225.c:17:
+STATIC s32 e1000_valid_led_default_i225(struct e1000_hw *hw, u16 *data);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'offset >= nvm->word_size'
#597: FILE: drivers/net/intel/e1000/base/e1000_i225.c:573:
+	if ((offset >= nvm->word_size) || (words > (nvm->word_size - offset)) ||
+	    (words == 0)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'words == 0'
#597: FILE: drivers/net/intel/e1000/base/e1000_i225.c:573:
+	if ((offset >= nvm->word_size) || (words > (nvm->word_size - offset)) ||
+	    (words == 0)) {

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct e1000_hw *' should also have an identifier name
#640: FILE: drivers/net/intel/e1000/base/e1000_i225.c:616:
+	s32 (*read_op_ptr)(struct e1000_hw *, u16, u16, u16 *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16' should also have an identifier name
#640: FILE: drivers/net/intel/e1000/base/e1000_i225.c:616:
+	s32 (*read_op_ptr)(struct e1000_hw *, u16, u16, u16 *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16' should also have an identifier name
#640: FILE: drivers/net/intel/e1000/base/e1000_i225.c:616:
+	s32 (*read_op_ptr)(struct e1000_hw *, u16, u16, u16 *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16 *' should also have an identifier name
#640: FILE: drivers/net/intel/e1000/base/e1000_i225.c:616:
+	s32 (*read_op_ptr)(struct e1000_hw *, u16, u16, u16 *);

total: 3 errors, 11 warnings, 2 checks, 1038 lines checked