From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DC7D646156 for ; Fri, 31 Jan 2025 14:02:22 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D08F242D90; Fri, 31 Jan 2025 14:02:22 +0100 (CET) Received: from dpdk.org (dpdk.org [92.243.24.197]) by mails.dpdk.org (Postfix) with ESMTP id 0E3E5427AC for ; Fri, 31 Jan 2025 14:02:22 +0100 (CET) Received: by dpdk.org (Postfix, from userid 65534) id DD657127003; Fri, 31 Jan 2025 14:01:17 +0100 (CET) Subject: |WARNING| pw150716 [PATCH v1 05/42] net/e1000/base: add NVM/EEPROM support for i225 In-Reply-To: <26e5f01f2f55270f3ec04dd8f452aae0cadb1462.1738328107.git.anatoly.burakov@intel.com> References: <26e5f01f2f55270f3ec04dd8f452aae0cadb1462.1738328107.git.anatoly.burakov@intel.com> To: test-report@dpdk.org From: checkpatch@dpdk.org Cc: Anatoly Burakov Message-Id: <20250131130117.DD657127003@dpdk.org> Date: Fri, 31 Jan 2025 14:01:17 +0100 (CET) X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/150716 _coding style issues_ ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #109: FILE: drivers/net/intel/e1000/base/e1000_defines.h:1496: +#define INVM_DWORD_TO_RECORD_TYPE(invm_dword) \ + (u8)((invm_dword) & 0x7) ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #111: FILE: drivers/net/intel/e1000/base/e1000_defines.h:1498: +#define INVM_DWORD_TO_WORD_ADDRESS(invm_dword) \ + (u8)(((invm_dword) & 0x0000FE00) >> 9) ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #113: FILE: drivers/net/intel/e1000/base/e1000_defines.h:1500: +#define INVM_DWORD_TO_WORD_DATA(invm_dword) \ + (u16)(((invm_dword) & 0xFFFF0000) >> 16) WARNING:TYPO_SPELLING: 'unitialized' may be misspelled - perhaps 'uninitialized'? #150: FILE: drivers/net/intel/e1000/base/e1000_hw.h:385: + e1000_invm_unitialized_structure = 0x00, WARNING:AVOID_EXTERNS: externs should be avoided in .c files #198: FILE: drivers/net/intel/e1000/base/e1000_i225.c:11: +STATIC s32 e1000_acquire_nvm_i225(struct e1000_hw *hw); WARNING:AVOID_EXTERNS: externs should be avoided in .c files #199: FILE: drivers/net/intel/e1000/base/e1000_i225.c:12: +STATIC void e1000_release_nvm_i225(struct e1000_hw *hw); WARNING:AVOID_EXTERNS: externs should be avoided in .c files #200: FILE: drivers/net/intel/e1000/base/e1000_i225.c:13: +STATIC s32 e1000_get_hw_semaphore_i225(struct e1000_hw *hw); WARNING:AVOID_EXTERNS: externs should be avoided in .c files #201: FILE: drivers/net/intel/e1000/base/e1000_i225.c:14: +STATIC s32 __e1000_write_nvm_srwr(struct e1000_hw *hw, u16 offset, u16 words, WARNING:AVOID_EXTERNS: externs should be avoided in .c files #203: FILE: drivers/net/intel/e1000/base/e1000_i225.c:16: +STATIC s32 e1000_pool_flash_update_done_i225(struct e1000_hw *hw); WARNING:AVOID_EXTERNS: externs should be avoided in .c files #204: FILE: drivers/net/intel/e1000/base/e1000_i225.c:17: +STATIC s32 e1000_valid_led_default_i225(struct e1000_hw *hw, u16 *data); CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'offset >= nvm->word_size' #597: FILE: drivers/net/intel/e1000/base/e1000_i225.c:573: + if ((offset >= nvm->word_size) || (words > (nvm->word_size - offset)) || + (words == 0)) { CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'words == 0' #597: FILE: drivers/net/intel/e1000/base/e1000_i225.c:573: + if ((offset >= nvm->word_size) || (words > (nvm->word_size - offset)) || + (words == 0)) { WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct e1000_hw *' should also have an identifier name #640: FILE: drivers/net/intel/e1000/base/e1000_i225.c:616: + s32 (*read_op_ptr)(struct e1000_hw *, u16, u16, u16 *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16' should also have an identifier name #640: FILE: drivers/net/intel/e1000/base/e1000_i225.c:616: + s32 (*read_op_ptr)(struct e1000_hw *, u16, u16, u16 *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16' should also have an identifier name #640: FILE: drivers/net/intel/e1000/base/e1000_i225.c:616: + s32 (*read_op_ptr)(struct e1000_hw *, u16, u16, u16 *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16 *' should also have an identifier name #640: FILE: drivers/net/intel/e1000/base/e1000_i225.c:616: + s32 (*read_op_ptr)(struct e1000_hw *, u16, u16, u16 *); total: 3 errors, 11 warnings, 2 checks, 1038 lines checked