From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Anatoly Burakov <anatoly.burakov@intel.com>
Subject: |WARNING| pw150714 [PATCH v1 03/42] net/e1000/base: add link bringup support for i225
Date: Fri, 31 Jan 2025 14:01:30 +0100 (CET) [thread overview]
Message-ID: <20250131130130.CDE98127003@dpdk.org> (raw)
In-Reply-To: <2eaccb279bf94195d4973ee3cad81d8c5ea33e55.1738328107.git.anatoly.burakov@intel.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/150714
_coding style issues_
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'hw->mac.type == e1000_i225'
#330: FILE: drivers/net/intel/e1000/base/e1000_mac.c:1648:
+ if ((hw->mac.type == e1000_i225) &&
+ (status & E1000_STATUS_SPEED_2500)) {
WARNING:BRACES: braces {} are not necessary for single statement blocks
#476: FILE: drivers/net/intel/e1000/base/e1000_phy.c:2921:
+ if (hw->mac.type == e1000_i225) {
+ E1000_READ_REG(hw, E1000_I225_PHPM);
+ }
total: 0 errors, 1 warnings, 1 checks, 400 lines checked
parent reply other threads:[~2025-01-31 13:02 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <2eaccb279bf94195d4973ee3cad81d8c5ea33e55.1738328107.git.anatoly.burakov@intel.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250131130130.CDE98127003@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=anatoly.burakov@intel.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).