From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Anatoly Burakov <anatoly.burakov@intel.com>
Subject: |WARNING| pw150713 [PATCH v1 02/42] net/e1000/base: add initial support for i225
Date: Fri, 31 Jan 2025 14:01:38 +0100 (CET) [thread overview]
Message-ID: <20250131130138.2527E127003@dpdk.org> (raw)
In-Reply-To: <41add229fd9b1c85fbc5c4451309110094b9626d.1738328107.git.anatoly.burakov@intel.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/150713
_coding style issues_
CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files
#132: FILE: drivers/net/intel/e1000/base/e1000_api.h:22:
+extern void e1000_init_function_pointers_i225(struct e1000_hw *hw);
WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#213: FILE: drivers/net/intel/e1000/base/e1000_i225.c:8:
+STATIC s32 e1000_init_phy_params_i225(struct e1000_hw *hw);
WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#214: FILE: drivers/net/intel/e1000/base/e1000_i225.c:9:
+STATIC s32 e1000_reset_hw_i225(struct e1000_hw *hw);
WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#323: FILE: drivers/net/intel/e1000/base/e1000_i225.c:118:
+ ret_val = e1000_disable_pcie_master_generic(hw);
WARNING:TYPO_SPELLING: 'Master' may be misspelled - perhaps 'Primary'?
#325: FILE: drivers/net/intel/e1000/base/e1000_i225.c:120:
+ DEBUGOUT("PCI-E Master disable polling has failed.
");
total: 0 errors, 4 warnings, 1 checks, 335 lines checked
parent reply other threads:[~2025-01-31 13:02 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <41add229fd9b1c85fbc5c4451309110094b9626d.1738328107.git.anatoly.burakov@intel.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250131130138.2527E127003@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=anatoly.burakov@intel.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).