From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 1C98946156
	for <public@inbox.dpdk.org>; Fri, 31 Jan 2025 14:02:43 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 0E15242D80;
	Fri, 31 Jan 2025 14:02:43 +0100 (CET)
Received: from dpdk.org (dpdk.org [92.243.24.197])
 by mails.dpdk.org (Postfix) with ESMTP id 4817C42D80
 for <test-report@dpdk.org>; Fri, 31 Jan 2025 14:02:42 +0100 (CET)
Received: by dpdk.org (Postfix, from userid 65534)
 id 2527E127003; Fri, 31 Jan 2025 14:01:38 +0100 (CET)
Subject: |WARNING| pw150713 [PATCH v1 02/42] net/e1000/base: add initial
 support for i225
In-Reply-To: <41add229fd9b1c85fbc5c4451309110094b9626d.1738328107.git.anatoly.burakov@intel.com>
References: <41add229fd9b1c85fbc5c4451309110094b9626d.1738328107.git.anatoly.burakov@intel.com>
To: test-report@dpdk.org
From: checkpatch@dpdk.org
Cc: Anatoly Burakov <anatoly.burakov@intel.com>
Message-Id: <20250131130138.2527E127003@dpdk.org>
Date: Fri, 31 Jan 2025 14:01:38 +0100 (CET)
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/150713

_coding style issues_


CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files
#132: FILE: drivers/net/intel/e1000/base/e1000_api.h:22:
+extern void e1000_init_function_pointers_i225(struct e1000_hw *hw);

WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#213: FILE: drivers/net/intel/e1000/base/e1000_i225.c:8:
+STATIC s32 e1000_init_phy_params_i225(struct e1000_hw *hw);

WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#214: FILE: drivers/net/intel/e1000/base/e1000_i225.c:9:
+STATIC s32 e1000_reset_hw_i225(struct e1000_hw *hw);

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#323: FILE: drivers/net/intel/e1000/base/e1000_i225.c:118:
+	ret_val = e1000_disable_pcie_master_generic(hw);

WARNING:TYPO_SPELLING: 'Master' may be misspelled - perhaps 'Primary'?
#325: FILE: drivers/net/intel/e1000/base/e1000_i225.c:120:
+		DEBUGOUT("PCI-E Master disable polling has failed.
");

total: 0 errors, 4 warnings, 1 checks, 335 lines checked