From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Anatoly Burakov <anatoly.burakov@intel.com>
Subject: |WARNING| pw150810 [PATCH v2 01/54] net/e1000/base: copy i225 code into e1000
Date: Tue, 4 Feb 2025 16:11:06 +0100 (CET) [thread overview]
Message-ID: <20250204151106.958E0127003@dpdk.org> (raw)
In-Reply-To: <13c09445b09e188bb7b20787fb296018d834a83c.1738681725.git.anatoly.burakov@intel.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/150810
_coding style issues_
CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files
#137: FILE: drivers/net/intel/e1000/base/e1000_api.h:22:
+extern void e1000_init_function_pointers_i225(struct e1000_hw *hw);
WARNING:TYPO_SPELLING: 'Aserted' may be misspelled - perhaps 'Asserted'?
#208: FILE: drivers/net/intel/e1000/base/e1000_defines.h:640:
+#define E1000_ICS_DRSTA E1000_ICR_DRSTA /* Device Reset Aserted */
ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#381: FILE: drivers/net/intel/e1000/base/e1000_defines.h:1594:
+#define INVM_DWORD_TO_RECORD_TYPE(invm_dword) \
+ (u8)((invm_dword) & 0x7)
ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#383: FILE: drivers/net/intel/e1000/base/e1000_defines.h:1596:
+#define INVM_DWORD_TO_WORD_ADDRESS(invm_dword) \
+ (u8)(((invm_dword) & 0x0000FE00) >> 9)
ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#385: FILE: drivers/net/intel/e1000/base/e1000_defines.h:1598:
+#define INVM_DWORD_TO_WORD_DATA(invm_dword) \
+ (u16)(((invm_dword) & 0xFFFF0000) >> 16)
WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#820: FILE: drivers/net/intel/e1000/base/e1000_i225.c:203:
+ ret_val = e1000_disable_pcie_master_generic(hw);
total: 3 errors, 2 warnings, 1 checks, 2596 lines checked
parent reply other threads:[~2025-02-04 15:12 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <13c09445b09e188bb7b20787fb296018d834a83c.1738681725.git.anatoly.burakov@intel.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250204151106.958E0127003@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=anatoly.burakov@intel.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).