From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 854464618E
	for <public@inbox.dpdk.org>; Tue,  4 Feb 2025 16:12:34 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 8AA9642DFA;
	Tue,  4 Feb 2025 16:12:29 +0100 (CET)
Received: from dpdk.org (dpdk.org [92.243.24.197])
 by mails.dpdk.org (Postfix) with ESMTP id 94FCD42D27
 for <test-report@dpdk.org>; Tue,  4 Feb 2025 16:12:15 +0100 (CET)
Received: by dpdk.org (Postfix, from userid 65534)
 id 958E0127003; Tue,  4 Feb 2025 16:11:06 +0100 (CET)
Subject: |WARNING| pw150810 [PATCH v2 01/54] net/e1000/base: copy i225 code
 into e1000
In-Reply-To: <13c09445b09e188bb7b20787fb296018d834a83c.1738681725.git.anatoly.burakov@intel.com>
References: <13c09445b09e188bb7b20787fb296018d834a83c.1738681725.git.anatoly.burakov@intel.com>
To: test-report@dpdk.org
From: checkpatch@dpdk.org
Cc: Anatoly Burakov <anatoly.burakov@intel.com>
Message-Id: <20250204151106.958E0127003@dpdk.org>
Date: Tue,  4 Feb 2025 16:11:06 +0100 (CET)
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/150810

_coding style issues_


CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files
#137: FILE: drivers/net/intel/e1000/base/e1000_api.h:22:
+extern void e1000_init_function_pointers_i225(struct e1000_hw *hw);

WARNING:TYPO_SPELLING: 'Aserted' may be misspelled - perhaps 'Asserted'?
#208: FILE: drivers/net/intel/e1000/base/e1000_defines.h:640:
+#define E1000_ICS_DRSTA		E1000_ICR_DRSTA     /* Device Reset Aserted */

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#381: FILE: drivers/net/intel/e1000/base/e1000_defines.h:1594:
+#define INVM_DWORD_TO_RECORD_TYPE(invm_dword) \
+	(u8)((invm_dword) & 0x7)

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#383: FILE: drivers/net/intel/e1000/base/e1000_defines.h:1596:
+#define INVM_DWORD_TO_WORD_ADDRESS(invm_dword) \
+	(u8)(((invm_dword) & 0x0000FE00) >> 9)

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#385: FILE: drivers/net/intel/e1000/base/e1000_defines.h:1598:
+#define INVM_DWORD_TO_WORD_DATA(invm_dword) \
+	(u16)(((invm_dword) & 0xFFFF0000) >> 16)

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#820: FILE: drivers/net/intel/e1000/base/e1000_i225.c:203:
+	ret_val = e1000_disable_pcie_master_generic(hw);

total: 3 errors, 2 warnings, 1 checks, 2596 lines checked