From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 43F484618E for ; Tue, 4 Feb 2025 16:14:36 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C96D24111B; Tue, 4 Feb 2025 16:14:29 +0100 (CET) Received: from dpdk.org (dpdk.org [92.243.24.197]) by mails.dpdk.org (Postfix) with ESMTP id 5C2CF410FB for ; Tue, 4 Feb 2025 16:14:28 +0100 (CET) Received: by dpdk.org (Postfix, from userid 65534) id 6D699127003; Tue, 4 Feb 2025 16:13:19 +0100 (CET) Subject: |WARNING| pw150817 [PATCH v2 08/54] net/e1000/base: correct formatting differences In-Reply-To: References: To: test-report@dpdk.org From: checkpatch@dpdk.org Cc: Anatoly Burakov Message-Id: <20250204151319.6D699127003@dpdk.org> Date: Tue, 4 Feb 2025 16:13:19 +0100 (CET) X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/150817 _coding style issues_ CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'offset >= nvm->word_size' #325: FILE: drivers/net/intel/e1000/base/e1000_i225.c:553: + if ((offset >= nvm->word_size) || (words > (nvm->word_size - offset)) || + (words == 0)) { CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'words == 0' #325: FILE: drivers/net/intel/e1000/base/e1000_i225.c:553: + if ((offset >= nvm->word_size) || (words > (nvm->word_size - offset)) || + (words == 0)) { WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct e1000_hw *' should also have an identifier name #336: FILE: drivers/net/intel/e1000/base/e1000_i225.c:691: + s32 (*read_op_ptr)(struct e1000_hw *, u16, u16, u16 *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16' should also have an identifier name #336: FILE: drivers/net/intel/e1000/base/e1000_i225.c:691: + s32 (*read_op_ptr)(struct e1000_hw *, u16, u16, u16 *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16' should also have an identifier name #336: FILE: drivers/net/intel/e1000/base/e1000_i225.c:691: + s32 (*read_op_ptr)(struct e1000_hw *, u16, u16, u16 *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16 *' should also have an identifier name #336: FILE: drivers/net/intel/e1000/base/e1000_i225.c:691: + s32 (*read_op_ptr)(struct e1000_hw *, u16, u16, u16 *); CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'hw->phy.media_type == e1000_media_type_copper' #347: FILE: drivers/net/intel/e1000/base/e1000_i225.c:1007: + if ((hw->phy.media_type == e1000_media_type_copper) && + !(hw->dev_spec._i225.eee_disable) && + (speed != SPEED_10)) { CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'speed != SPEED_10' #347: FILE: drivers/net/intel/e1000/base/e1000_i225.c:1007: + if ((hw->phy.media_type == e1000_media_type_copper) && + !(hw->dev_spec._i225.eee_disable) && + (speed != SPEED_10)) { CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'hw->mac.type == e1000_i225' #381: FILE: drivers/net/intel/e1000/base/e1000_mac.c:1648: + if ((hw->mac.type == e1000_i225) && (status & E1000_STATUS_SPEED_2500)) { total: 0 errors, 4 warnings, 5 checks, 375 lines checked