From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 80EED4618E
	for <public@inbox.dpdk.org>; Tue,  4 Feb 2025 17:56:30 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 7D300400EF;
	Tue,  4 Feb 2025 17:56:30 +0100 (CET)
Received: from dpdk.org (dpdk.org [92.243.24.197])
 by mails.dpdk.org (Postfix) with ESMTP id 92512400D7
 for <test-report@dpdk.org>; Tue,  4 Feb 2025 17:56:28 +0100 (CET)
Received: by dpdk.org (Postfix, from userid 65534)
 id 77218127003; Tue,  4 Feb 2025 17:55:19 +0100 (CET)
Subject: |WARNING| pw150894 [PATCH] eal: force evaluation of RTE_ASSERT
 expression
In-Reply-To: <20250204165516.168106-1-stephen@networkplumber.org>
References: <20250204165516.168106-1-stephen@networkplumber.org>
To: test-report@dpdk.org
From: checkpatch@dpdk.org
Cc: Stephen Hemminger <stephen@networkplumber.org>
Message-Id: <20250204165519.77218127003@dpdk.org>
Date: Tue,  4 Feb 2025 17:55:19 +0100 (CET)
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/150894

_coding style issues_


WARNING:TYPO_SPELLING: 'evaluted' may be misspelled - perhaps 'evaluated'?
#105: FILE: lib/eal/include/rte_debug.h:46:
+/* RTE_ASSERT is optional checks that only get evaluted if RTE_ENABLE_ASSERT is enabled. */

WARNING:SINGLE_STATEMENT_DO_WHILE_MACRO: Single statement macros should not use a do {} while (0) loop
#110: FILE: lib/eal/include/rte_debug.h:50:
+#define RTE_ASSERT(exp)					\
+	/* Evaluate expression to trigger warnings */	\
+	do {						\
+		(void)sizeof((exp) ? 1 : 0);		\
+	} while (0)

total: 0 errors, 2 warnings, 18 lines checked