From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Wenbo Cao <caowenbo@mucse.com>
Subject: |WARNING| pw151147 [PATCH v7 05/28] net/rnp: add device init and uninit
Date: Sat, 8 Feb 2025 03:44:55 +0100 (CET) [thread overview]
Message-ID: <20250208024455.9CE4B127003@dpdk.org> (raw)
In-Reply-To: <1738982645-34550-6-git-send-email-caowenbo@mucse.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/151147
_coding style issues_
WARNING:TYPO_SPELLING: 'availble' may be misspelled - perhaps 'available'?
#425: FILE: drivers/net/rnp/base/rnp_fw_cmd.h:108:
+ u32 rpu_availble : 1; /* 11 */
WARNING:TYPO_SPELLING: 'alloced' may be misspelled - perhaps 'allocated'?
#564: FILE: drivers/net/rnp/base/rnp_hw.h:73:
+ bool msg_alloced;
CHECK:UNCOMMENTED_DEFINITION: spinlock_t definition without comment
#567: FILE: drivers/net/rnp/base/rnp_hw.h:76:
+ spinlock_t fw_lock;
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'func' - possible side-effects?
#570: FILE: drivers/net/rnp/base/rnp_hw.h:79:
+#define rnp_call_hwif_impl(port, func, arg...) \
+ (((func) != NULL) ? ((func) (port, arg)) : (-ENODEV))
CHECK:SPACING: No space is necessary after a cast
#1113: FILE: drivers/net/rnp/base/rnp_osdep.h:92:
+ static RTE_ATOMIC(uint64_t) rnp_dma_memzone_id;
CHECK:CAMELCASE: Avoid CamelCase: <PRIu64>
#1125: FILE: drivers/net/rnp/base/rnp_osdep.h:104:
+ snprintf(z_name, sizeof(z_name), "rnp_dma_%" PRIu64,
CHECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements
#1139: FILE: drivers/net/rnp/base/rnp_osdep.h:118:
+ "%"PRIu64, mz->name, mem->pa);
CHECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements
#1149: FILE: drivers/net/rnp/base/rnp_osdep.h:128:
+ "%"PRIu64, ((const struct rte_memzone *)mem->mz)->name,
WARNING:TYPO_SPELLING: 'registed' may be misspelled - perhaps 'registered'?
#1217: FILE: drivers/net/rnp/rnp.h:48:
+ bool intr_registed;
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'id' - possible side-effects?
#1231: FILE: drivers/net/rnp/rnp.h:62:
+#define RNP_PF_OWN_PORTS(id) (((id) == 0) ? 1 : (((id) == 1) ? 2 : 4))
WARNING:TYPO_SPELLING: 'registed' may be misspelled - perhaps 'registered'?
#1319: FILE: drivers/net/rnp/rnp_ethdev.c:75:
+ if (adapter->intr_registed) {
WARNING:TYPO_SPELLING: 'registed' may be misspelled - perhaps 'registered'?
#1325: FILE: drivers/net/rnp/rnp_ethdev.c:81:
+ adapter->intr_registed = false;
WARNING:TYPO_SPELLING: 'plaform' may be misspelled - perhaps 'platform'?
#1515: FILE: drivers/net/rnp/rnp_ethdev.c:269:
+ /* port 0 will be probe by plaform */
WARNING:TYPO_SPELLING: 'registed' may be misspelled - perhaps 'registered'?
#1523: FILE: drivers/net/rnp/rnp_ethdev.c:277:
+ adapter->intr_registed = true;
WARNING:TYPO_SPELLING: 'alloced' may be misspelled - perhaps 'allocated'?
#1535: FILE: drivers/net/rnp/rnp_ethdev.c:289:
+ /* just release eth_dev alloced by myself */
total: 0 errors, 8 warnings, 7 checks, 1423 lines checked
Warning in drivers/net/rnp/base/rnp_osdep.h:
Using compiler attribute directly
Warning in drivers/net/rnp/base/rnp_hw.h:
Do not use variadic argument pack in macros
parent reply other threads:[~2025-02-08 2:46 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1738982645-34550-6-git-send-email-caowenbo@mucse.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250208024455.9CE4B127003@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=caowenbo@mucse.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).