automatic DPDK test reports
 help / color / mirror / Atom feed
From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Wenbo Cao <caowenbo@mucse.com>
Subject: |WARNING| pw151248 [PATCH v8 04/28] net/rnp: support mailbox basic operate
Date: Mon, 10 Feb 2025 08:29:25 +0100 (CET)	[thread overview]
Message-ID: <20250210072925.376DD124126@dpdk.org> (raw)
In-Reply-To: <1739172415-48507-5-git-send-email-caowenbo@mucse.com>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/151248

_coding style issues_


WARNING:MEMORY_BARRIER: memory barrier without comment
#202: FILE: drivers/net/rnp/base/rnp_mbx.c:21:
+	mb();

WARNING:MEMORY_BARRIER: memory barrier without comment
#217: FILE: drivers/net/rnp/base/rnp_mbx.c:36:
+	mb();

WARNING:MEMORY_BARRIER: memory barrier without comment
#246: FILE: drivers/net/rnp/base/rnp_mbx.c:65:
+	mb();

WARNING:MEMORY_BARRIER: memory barrier without comment
#272: FILE: drivers/net/rnp/base/rnp_mbx.c:91:
+	mb();

WARNING:MEMORY_BARRIER: memory barrier without comment
#306: FILE: drivers/net/rnp/base/rnp_mbx.c:125:
+	mb();

WARNING:MEMORY_BARRIER: memory barrier without comment
#413: FILE: drivers/net/rnp/base/rnp_mbx.c:232:
+		wmb();

CHECK:USLEEP_RANGE: usleep_range is preferred over udelay; see Documentation/timers/timers-howto.rst
#417: FILE: drivers/net/rnp/base/rnp_mbx.c:236:
+		udelay(100);

WARNING:MEMORY_BARRIER: memory barrier without comment
#483: FILE: drivers/net/rnp/base/rnp_mbx.c:302:
+	mb();

CHECK:USLEEP_RANGE: usleep_range is preferred over udelay; see Documentation/timers/timers-howto.rst
#526: FILE: drivers/net/rnp/base/rnp_mbx.c:345:
+	udelay(300);

WARNING:MEMORY_BARRIER: memory barrier without comment
#527: FILE: drivers/net/rnp/base/rnp_mbx.c:346:
+	mb();

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#719: FILE: drivers/net/rnp/base/rnp_mbx.h:20:
+ *|------master-req-----|-------master-ack------|

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#719: FILE: drivers/net/rnp/base/rnp_mbx.h:20:
+ *|------master-req-----|-------master-ack------|

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#720: FILE: drivers/net/rnp/base/rnp_mbx.h:21:
+ *|------slave-req------|-------slave-ack-------|

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#720: FILE: drivers/net/rnp/base/rnp_mbx.h:21:
+ *|------slave-req------|-------slave-ack-------|

WARNING:MEMORY_BARRIER: memory barrier without comment
#785: FILE: drivers/net/rnp/base/rnp_osdep.h:22:
+#define mb()	rte_mb()

WARNING:MEMORY_BARRIER: memory barrier without comment
#786: FILE: drivers/net/rnp/base/rnp_osdep.h:23:
+#define wmb()	rte_wmb()

total: 0 errors, 14 warnings, 2 checks, 761 lines checked

           reply	other threads:[~2025-02-10  7:30 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <1739172415-48507-5-git-send-email-caowenbo@mucse.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250210072925.376DD124126@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=caowenbo@mucse.com \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).