From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 4A264462A0
	for <public@inbox.dpdk.org>; Sun, 23 Feb 2025 22:54:36 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 41BDB402D1;
	Sun, 23 Feb 2025 22:54:36 +0100 (CET)
Received: from dpdk.org (dpdk.org [92.243.24.197])
 by mails.dpdk.org (Postfix) with ESMTP id 8C2D5402CF
 for <test-report@dpdk.org>; Sun, 23 Feb 2025 22:54:34 +0100 (CET)
Received: by dpdk.org (Postfix, from userid 65534)
 id 3C847127813; Sun, 23 Feb 2025 22:54:20 +0100 (CET)
Subject: |WARNING| pw151872 [PATCH v10 2/2] net/af_xdp: Refactor af_xdp_tx_zc
In-Reply-To: <20250223215259.448723-3-ariel.otilibili@6wind.com>
References: <20250223215259.448723-3-ariel.otilibili@6wind.com>
To: test-report@dpdk.org
From: checkpatch@dpdk.org
Cc: Ariel Otilibili <ariel.otilibili@6wind.com>
Message-Id: <20250223215420.3C847127813@dpdk.org>
Date: Sun, 23 Feb 2025 22:54:20 +0100 (CET)
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/151872

_coding style issues_


WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (16, 18)
#169: FILE: drivers/net/af_xdp/rte_eth_af_xdp.c:589:
 		if (mbuf->pool == umem->mb_pool) {
+		  if (!(desc = reserve_and_fill(txq, mbuf, umem, NULL))) {

WARNING:TABSTOP: Statements should start on a tabstop
#171: FILE: drivers/net/af_xdp/rte_eth_af_xdp.c:590:
+		  if (!(desc = reserve_and_fill(txq, mbuf, umem, NULL))) {

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (18, 32)
#171: FILE: drivers/net/af_xdp/rte_eth_af_xdp.c:590:
+		  if (!(desc = reserve_and_fill(txq, mbuf, umem, NULL))) {
 				kick_tx(txq, cq);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#171: FILE: drivers/net/af_xdp/rte_eth_af_xdp.c:590:
+		  if (!(desc = reserve_and_fill(txq, mbuf, umem, NULL))) {

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#197: FILE: drivers/net/af_xdp/rte_eth_af_xdp.c:600:
+			if (!(local_mbuf = rte_pktmbuf_alloc(umem->mb_pool)))

total: 2 errors, 3 warnings, 0 checks, 112 lines checked