From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C64AA462B7 for ; Tue, 25 Feb 2025 09:42:36 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C35EE42DE9; Tue, 25 Feb 2025 09:42:34 +0100 (CET) Received: from dpdk.org (dpdk.org [92.243.24.197]) by mails.dpdk.org (Postfix) with ESMTP id 4C45F42D78 for ; Tue, 25 Feb 2025 09:42:33 +0100 (CET) Received: by dpdk.org (Postfix, from userid 65534) id 4667E127817; Tue, 25 Feb 2025 09:42:17 +0100 (CET) Subject: |WARNING| pw151992 [PATCH v15 04/29] net/rnp: support mailbox basic operate In-Reply-To: <1740472886-30411-5-git-send-email-caowenbo@mucse.com> References: <1740472886-30411-5-git-send-email-caowenbo@mucse.com> To: test-report@dpdk.org From: checkpatch@dpdk.org Cc: Wenbo Cao Message-Id: <20250225084217.4667E127817@dpdk.org> Date: Tue, 25 Feb 2025 09:42:17 +0100 (CET) X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/151992 _coding style issues_ WARNING:MEMORY_BARRIER: memory barrier without comment #194: FILE: drivers/net/rnp/base/rnp_mbx.c:21: + mb(); WARNING:MEMORY_BARRIER: memory barrier without comment #209: FILE: drivers/net/rnp/base/rnp_mbx.c:36: + mb(); WARNING:MEMORY_BARRIER: memory barrier without comment #238: FILE: drivers/net/rnp/base/rnp_mbx.c:65: + mb(); WARNING:MEMORY_BARRIER: memory barrier without comment #264: FILE: drivers/net/rnp/base/rnp_mbx.c:91: + mb(); WARNING:MEMORY_BARRIER: memory barrier without comment #298: FILE: drivers/net/rnp/base/rnp_mbx.c:125: + mb(); WARNING:MEMORY_BARRIER: memory barrier without comment #405: FILE: drivers/net/rnp/base/rnp_mbx.c:232: + wmb(); CHECK:USLEEP_RANGE: usleep_range is preferred over udelay; see Documentation/timers/timers-howto.rst #409: FILE: drivers/net/rnp/base/rnp_mbx.c:236: + udelay(100); WARNING:MEMORY_BARRIER: memory barrier without comment #475: FILE: drivers/net/rnp/base/rnp_mbx.c:302: + mb(); CHECK:USLEEP_RANGE: usleep_range is preferred over udelay; see Documentation/timers/timers-howto.rst #518: FILE: drivers/net/rnp/base/rnp_mbx.c:345: + udelay(300); WARNING:MEMORY_BARRIER: memory barrier without comment #519: FILE: drivers/net/rnp/base/rnp_mbx.c:346: + mb(); WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'? #707: FILE: drivers/net/rnp/base/rnp_mbx.h:21: + *|------master-req-----|-------master-ack------| WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'? #707: FILE: drivers/net/rnp/base/rnp_mbx.h:21: + *|------master-req-----|-------master-ack------| WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'? #708: FILE: drivers/net/rnp/base/rnp_mbx.h:22: + *|------slave-req------|-------slave-ack-------| WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'? #708: FILE: drivers/net/rnp/base/rnp_mbx.h:22: + *|------slave-req------|-------slave-ack-------| WARNING:MEMORY_BARRIER: memory barrier without comment #773: FILE: drivers/net/rnp/base/rnp_osdep.h:22: +#define mb() rte_mb() WARNING:MEMORY_BARRIER: memory barrier without comment #774: FILE: drivers/net/rnp/base/rnp_osdep.h:23: +#define wmb() rte_wmb() CHECK:CAMELCASE: Avoid CamelCase: #786: FILE: drivers/net/rnp/base/rnp_osdep.h:35: + RNP_PMD_REG_LOG(DEBUG, "offset=%p val=%#"PRIx32"", offset, v); CHECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements #786: FILE: drivers/net/rnp/base/rnp_osdep.h:35: + RNP_PMD_REG_LOG(DEBUG, "offset=%p val=%#"PRIx32"", offset, v); CHECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements #793: FILE: drivers/net/rnp/base/rnp_osdep.h:42: + RNP_PMD_REG_LOG(DEBUG, "offset=%p val=%#"PRIx32"", offset, val); CHECK:MACRO_ARG_REUSE: Macro argument reuse 'hw' - possible side-effects? #801: FILE: drivers/net/rnp/base/rnp_osdep.h:50: +#define RNP_C_REG_WR(hw, off, value) \ + rnp_reg_write32((hw)->c_ctrl, ((off) & ((hw)->c_blen - 1)), (value)) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'hw' - possible side-effects? #803: FILE: drivers/net/rnp/base/rnp_osdep.h:52: +#define RNP_C_REG_RD(hw, off) \ + rnp_reg_read32((hw)->c_ctrl, ((off) & ((hw)->c_blen - 1))) total: 0 errors, 14 warnings, 7 checks, 752 lines checked