From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 3005046480
	for <public@inbox.dpdk.org>; Wed, 26 Mar 2025 17:06:53 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 2BE7540672;
	Wed, 26 Mar 2025 17:06:53 +0100 (CET)
Received: from dpdk.org (dpdk.org [92.243.24.197])
 by mails.dpdk.org (Postfix) with ESMTP id 5472740665
 for <test-report@dpdk.org>; Wed, 26 Mar 2025 17:06:52 +0100 (CET)
Received: by dpdk.org (Postfix, from userid 65534)
 id 96CD5123E76; Wed, 26 Mar 2025 17:06:30 +0100 (CET)
Subject: |WARNING| pw152576 [PATCH v2 3/8] net/ixgbe/base: correct definition
 of macro
In-Reply-To: <20250326160539.1316499-4-bruce.richardson@intel.com>
References: <20250326160539.1316499-4-bruce.richardson@intel.com>
To: test-report@dpdk.org
From: checkpatch@dpdk.org
Cc: Bruce Richardson <bruce.richardson@intel.com>
Message-Id: <20250326160630.96CD5123E76@dpdk.org>
Date: Wed, 26 Mar 2025 17:06:30 +0100 (CET)
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/152576

_coding style issues_


ERROR:SPACING: space required before the open parenthesis '('
#116: FILE: drivers/net/intel/ixgbe/base/ixgbe_osdep.h:86:
+#define IXGBE_LE32_TO_CPUS(_i) do { *_i = rte_le_to_cpu_32(*_i); } while(0)

CHECK:MACRO_ARG_REUSE: Macro argument reuse '_i' - possible side-effects?
#116: FILE: drivers/net/intel/ixgbe/base/ixgbe_osdep.h:86:
+#define IXGBE_LE32_TO_CPUS(_i) do { *_i = rte_le_to_cpu_32(*_i); } while(0)

CHECK:MACRO_ARG_PRECEDENCE: Macro argument '_i' may be better as '(_i)' to avoid precedence issues
#116: FILE: drivers/net/intel/ixgbe/base/ixgbe_osdep.h:86:
+#define IXGBE_LE32_TO_CPUS(_i) do { *_i = rte_le_to_cpu_32(*_i); } while(0)

WARNING:SINGLE_STATEMENT_DO_WHILE_MACRO: Single statement macros should not use a do {} while (0) loop
#116: FILE: drivers/net/intel/ixgbe/base/ixgbe_osdep.h:86:
+#define IXGBE_LE32_TO_CPUS(_i) do { *_i = rte_le_to_cpu_32(*_i); } while(0)

total: 1 errors, 1 warnings, 2 checks, 32 lines checked