|WARNING| pw152638 [PATCH v17 08/29] net/rnp: add queue setup and release operations

automatic DPDK test reports
 help / color / mirror / Atom feed

From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Wenbo Cao <caowenbo@mucse.com>
Subject: |WARNING| pw152638 [PATCH v17 08/29] net/rnp: add queue setup and release operations
Date: Fri, 28 Mar 2025 06:16:15 +0100 (CET)	[thread overview]
Message-ID: <20250328051615.C5CB4123E9B@dpdk.org> (raw)
In-Reply-To: <20250328051444.1019208-9-caowenbo@mucse.com>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/152638

_coding style issues_


WARNING:MEMORY_BARRIER: memory barrier without comment
#168: FILE: drivers/net/rnp/base/rnp_bdq_if.c:35:
+	wmb();

WARNING:MEMORY_BARRIER: memory barrier without comment
#183: FILE: drivers/net/rnp/base/rnp_bdq_if.c:50:
+	wmb();

WARNING:MEMORY_BARRIER: memory barrier without comment
#186: FILE: drivers/net/rnp/base/rnp_bdq_if.c:53:
+	wmb();

WARNING:MEMORY_BARRIER: memory barrier without comment
#199: FILE: drivers/net/rnp/base/rnp_bdq_if.c:66:
+	wmb();

WARNING:MEMORY_BARRIER: memory barrier without comment
#222: FILE: drivers/net/rnp/base/rnp_bdq_if.c:89:
+	wmb();

WARNING:MEMORY_BARRIER: memory barrier without comment
#225: FILE: drivers/net/rnp/base/rnp_bdq_if.c:92:
+	wmb();

CHECK:USLEEP_RANGE: usleep_range is preferred over udelay; see Documentation/timers/timers-howto.rst
#234: FILE: drivers/net/rnp/base/rnp_bdq_if.c:101:
+		udelay(10);

WARNING:MEMORY_BARRIER: memory barrier without comment
#280: FILE: drivers/net/rnp/base/rnp_bdq_if.c:147:
+	wmb();

CHECK:USLEEP_RANGE: usleep_range is preferred over udelay; see Documentation/timers/timers-howto.rst
#292: FILE: drivers/net/rnp/base/rnp_bdq_if.c:159:
+		udelay(10);

WARNING:MEMORY_BARRIER: memory barrier without comment
#300: FILE: drivers/net/rnp/base/rnp_bdq_if.c:167:
+	wmb();

CHECK:USLEEP_RANGE: usleep_range is preferred over udelay; see Documentation/timers/timers-howto.rst
#311: FILE: drivers/net/rnp/base/rnp_bdq_if.c:178:
+		udelay(10);

CHECK:USLEEP_RANGE: usleep_range is preferred over udelay; see Documentation/timers/timers-howto.rst
#323: FILE: drivers/net/rnp/base/rnp_bdq_if.c:190:
+		udelay(10);

WARNING:MEMORY_BARRIER: memory barrier without comment
#432: FILE: drivers/net/rnp/base/rnp_bdq_if.c:299:
+		wmb();

WARNING:MEMORY_BARRIER: memory barrier without comment
#443: FILE: drivers/net/rnp/base/rnp_bdq_if.c:310:
+		wmb();

WARNING:MEMORY_BARRIER: memory barrier without comment
#467: FILE: drivers/net/rnp/base/rnp_bdq_if.c:334:
+	wmb();

WARNING:MEMORY_BARRIER: memory barrier without comment
#469: FILE: drivers/net/rnp/base/rnp_bdq_if.c:336:
+	wmb();

CHECK:USLEEP_RANGE: usleep_range is preferred over udelay; see Documentation/timers/timers-howto.rst
#481: FILE: drivers/net/rnp/base/rnp_bdq_if.c:348:
+		udelay(10);

WARNING:MEMORY_BARRIER: memory barrier without comment
#500: FILE: drivers/net/rnp/base/rnp_bdq_if.c:367:
+	rmb();

CHECK:USLEEP_RANGE: usleep_range is preferred over udelay; see Documentation/timers/timers-howto.rst
#514: FILE: drivers/net/rnp/base/rnp_bdq_if.c:381:
+		udelay(10);

WARNING:MEMORY_BARRIER: memory barrier without comment
#516: FILE: drivers/net/rnp/base/rnp_bdq_if.c:383:
+	rmb();

WARNING:MEMORY_BARRIER: memory barrier without comment
#521: FILE: drivers/net/rnp/base/rnp_bdq_if.c:388:
+	wmb();

WARNING:MEMORY_BARRIER: memory barrier without comment
#524: FILE: drivers/net/rnp/base/rnp_bdq_if.c:391:
+	wmb();

WARNING:MEMORY_BARRIER: memory barrier without comment
#527: FILE: drivers/net/rnp/base/rnp_bdq_if.c:394:
+	rmb();

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'macaddr' - possible side-effects?
#695: FILE: drivers/net/rnp/base/rnp_common.h:9:
+#define RNP_GET_MAC_HI(macaddr) (((macaddr[0]) << 8) | (macaddr[1]))

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'macaddr' - possible side-effects?
#696: FILE: drivers/net/rnp/base/rnp_common.h:10:
+#define RNP_GET_MAC_LO(macaddr) \
+	((macaddr[2] << 24) | (macaddr[3] << 16) | \
+	 ((macaddr[4] << 8)) | (macaddr[5]))

WARNING:TYPO_SPELLING: 'CLER' may be misspelled - perhaps 'CLEAR'?
#722: FILE: drivers/net/rnp/base/rnp_dma_regs.h:24:
+#define RNP_RXTX_IRQ_CLER(qid)	_RING_(0x0028 + 0x100 * (qid))

WARNING:MEMORY_BARRIER: memory barrier without comment
#795: FILE: drivers/net/rnp/base/rnp_osdep.h:38:
+#define rmb()	rte_rmb()

total: 0 errors, 19 warnings, 8 checks, 1356 lines checked

          parent reply	other threads:[~2025-03-28  5:16 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <20250328051444.1019208-9-caowenbo@mucse.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250328051615.C5CB4123E9B@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=caowenbo@mucse.com \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).