From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Wenbo Cao <caowenbo@mucse.com>
Subject: |WARNING| pw152635 [PATCH v17 04/29] net/rnp: support mailbox basic operate
Date: Fri, 28 Mar 2025 06:17:14 +0100 (CET) [thread overview]
Message-ID: <20250328051714.0D8A2123E9B@dpdk.org> (raw)
In-Reply-To: <20250328051444.1019208-5-caowenbo@mucse.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/152635
_coding style issues_
WARNING:MEMORY_BARRIER: memory barrier without comment
#220: FILE: drivers/net/rnp/base/rnp_mbx.c:21:
+ mb();
WARNING:MEMORY_BARRIER: memory barrier without comment
#235: FILE: drivers/net/rnp/base/rnp_mbx.c:36:
+ mb();
WARNING:MEMORY_BARRIER: memory barrier without comment
#264: FILE: drivers/net/rnp/base/rnp_mbx.c:65:
+ mb();
WARNING:MEMORY_BARRIER: memory barrier without comment
#290: FILE: drivers/net/rnp/base/rnp_mbx.c:91:
+ mb();
WARNING:MEMORY_BARRIER: memory barrier without comment
#324: FILE: drivers/net/rnp/base/rnp_mbx.c:125:
+ mb();
WARNING:MEMORY_BARRIER: memory barrier without comment
#431: FILE: drivers/net/rnp/base/rnp_mbx.c:232:
+ wmb();
CHECK:USLEEP_RANGE: usleep_range is preferred over udelay; see Documentation/timers/timers-howto.rst
#435: FILE: drivers/net/rnp/base/rnp_mbx.c:236:
+ udelay(100);
WARNING:MEMORY_BARRIER: memory barrier without comment
#501: FILE: drivers/net/rnp/base/rnp_mbx.c:302:
+ mb();
CHECK:USLEEP_RANGE: usleep_range is preferred over udelay; see Documentation/timers/timers-howto.rst
#544: FILE: drivers/net/rnp/base/rnp_mbx.c:345:
+ udelay(300);
WARNING:MEMORY_BARRIER: memory barrier without comment
#545: FILE: drivers/net/rnp/base/rnp_mbx.c:346:
+ mb();
WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#733: FILE: drivers/net/rnp/base/rnp_mbx.h:21:
+ *|------master-req-----|-------master-ack------|
WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#733: FILE: drivers/net/rnp/base/rnp_mbx.h:21:
+ *|------master-req-----|-------master-ack------|
WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#734: FILE: drivers/net/rnp/base/rnp_mbx.h:22:
+ *|------slave-req------|-------slave-ack-------|
WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#734: FILE: drivers/net/rnp/base/rnp_mbx.h:22:
+ *|------slave-req------|-------slave-ack-------|
WARNING:MEMORY_BARRIER: memory barrier without comment
#799: FILE: drivers/net/rnp/base/rnp_osdep.h:22:
+#define mb() rte_mb()
WARNING:MEMORY_BARRIER: memory barrier without comment
#800: FILE: drivers/net/rnp/base/rnp_osdep.h:23:
+#define wmb() rte_wmb()
CHECK:CAMELCASE: Avoid CamelCase: <PRIx32>
#812: FILE: drivers/net/rnp/base/rnp_osdep.h:35:
+ RNP_PMD_REG_LOG(DEBUG, "offset=%p val=%#"PRIx32"", offset, v);
CHECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements
#812: FILE: drivers/net/rnp/base/rnp_osdep.h:35:
+ RNP_PMD_REG_LOG(DEBUG, "offset=%p val=%#"PRIx32"", offset, v);
CHECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements
#819: FILE: drivers/net/rnp/base/rnp_osdep.h:42:
+ RNP_PMD_REG_LOG(DEBUG, "offset=%p val=%#"PRIx32"", offset, val);
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'hw' - possible side-effects?
#827: FILE: drivers/net/rnp/base/rnp_osdep.h:50:
+#define RNP_C_REG_WR(hw, off, value) \
+ rnp_reg_write32((hw)->c_ctrl, ((off) & ((hw)->c_blen - 1)), (value))
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'hw' - possible side-effects?
#829: FILE: drivers/net/rnp/base/rnp_osdep.h:52:
+#define RNP_C_REG_RD(hw, off) \
+ rnp_reg_read32((hw)->c_ctrl, ((off) & ((hw)->c_blen - 1)))
total: 0 errors, 14 warnings, 7 checks, 752 lines checked
parent reply other threads:[~2025-03-28 5:17 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20250328051444.1019208-5-caowenbo@mucse.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250328051714.0D8A2123E9B@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=caowenbo@mucse.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).