From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 9BF35464F7
	for <public@inbox.dpdk.org>; Thu,  3 Apr 2025 20:11:49 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 9169340E16;
	Thu,  3 Apr 2025 20:11:49 +0200 (CEST)
Received: from dpdk.org (dpdk.org [92.243.24.197])
 by mails.dpdk.org (Postfix) with ESMTP id 6C674406B6
 for <test-report@dpdk.org>; Thu,  3 Apr 2025 20:11:47 +0200 (CEST)
Received: by dpdk.org (Postfix, from userid 65534)
 id 777061251A5; Thu,  3 Apr 2025 20:11:42 +0200 (CEST)
Subject: |WARNING| pw152769 [PATCH v7 8/8] eal: rework function versioning
 macros
In-Reply-To: <20250403165845.1315380-9-david.marchand@redhat.com>
References: <20250403165845.1315380-9-david.marchand@redhat.com>
To: test-report@dpdk.org
From: checkpatch@dpdk.org
Cc: David Marchand <david.marchand@redhat.com>
Message-Id: <20250403181142.777061251A5@dpdk.org>
Date: Thu,  3 Apr 2025 20:11:42 +0200 (CEST)
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/152769

_coding style issues_


ERROR:SPACING: spaces required around that '?' (ctx:VxB)
#535: FILE: lib/eal/common/eal_export.h:20:
+	Is "use_function_versioning=true" in meson.build?)
 	                                                ^

ERROR:MULTISTATEMENT_MACRO_USE_DO_WHILE: Macros with multiple statements should be enclosed in a do - while loop
#556: FILE: lib/eal/common/eal_export.h:41:
+#define RTE_VERSION_SYMBOL(ver, type, name, args) VERSIONING_WARN \
+__asm__(".symver " RTE_STR(name) "_v" RTE_STR(ver) ", " RTE_STR(name) "@DPDK_" RTE_STR(ver)); \
+__rte_used type name ## _v ## ver args; \
+type name ## _v ## ver args

ERROR:MULTISTATEMENT_MACRO_USE_DO_WHILE: Macros with multiple statements should be enclosed in a do - while loop
#565: FILE: lib/eal/common/eal_export.h:50:
+#define RTE_VERSION_EXPERIMENTAL_SYMBOL(type, name, args) VERSIONING_WARN \
+__asm__(".symver " RTE_STR(name) "_exp, " RTE_STR(name) "@EXPERIMENTAL") \
+__rte_used type name ## _exp args; \
+type name ## _exp args

ERROR:MULTISTATEMENT_MACRO_USE_DO_WHILE: Macros with multiple statements should be enclosed in a do - while loop
#574: FILE: lib/eal/common/eal_export.h:59:
+#define RTE_DEFAULT_SYMBOL(ver, type, name, args) VERSIONING_WARN \
+__asm__(".symver " RTE_STR(name) "_v" RTE_STR(ver) ", " RTE_STR(name) "@@DPDK_" RTE_STR(ver)); \
+__rte_used type name ## _v ## ver args; \
+type name ## _v ## ver args

ERROR:MULTISTATEMENT_MACRO_USE_DO_WHILE: Macros with multiple statements should be enclosed in a do - while loop
#581: FILE: lib/eal/common/eal_export.h:66:
+#define RTE_VERSION_SYMBOL(ver, type, name, args) VERSIONING_WARN \
+type name ## _v ## ver args; \
+type name ## _v ## ver args

ERROR:MULTISTATEMENT_MACRO_USE_DO_WHILE: Macros with multiple statements should be enclosed in a do - while loop
#585: FILE: lib/eal/common/eal_export.h:70:
+#define RTE_VERSION_EXPERIMENTAL_SYMBOL(type, name, args) VERSIONING_WARN \
+type name ## _exp args; \
+type name ## _exp args

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#589: FILE: lib/eal/common/eal_export.h:74:
+#define RTE_DEFAULT_SYMBOL(ver, type, name, args) VERSIONING_WARN \
+type name args

total: 7 errors, 0 warnings, 516 lines checked