From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Ivan Malov <ivan.malov@arknetworks.am>
Subject: |WARNING| pw152982 [PATCH 35/46] common/sfc_efx/base: support MAC statistics on Medford4 NICs
Date: Wed, 16 Apr 2025 16:08:03 +0200 (CEST) [thread overview]
Message-ID: <20250416140803.AD306123F9E@dpdk.org> (raw)
In-Reply-To: <20250416140016.36127-36-ivan.malov@arknetworks.am>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/152982
_coding style issues_
WARNING:SPACING: space prohibited between function name and open parenthesis '('
#222: FILE: drivers/common/sfc_efx/base/efx_np.c:1344:
+ sz = encp->enc_mac_stats_nstats * sizeof (efx_qword_t);
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#258: FILE: drivers/common/sfc_efx/base/efx_np.c:1380:
+ return (rc);
WARNING:TYPO_SPELLING: 'inout' may be misspelled - perhaps 'input'?
#294: FILE: drivers/common/sfc_efx/base/medford4_impl.h:91:
+ __inout_ecount(EFX_MAC_NSTATS) efsys_stat_t *stats,
WARNING:TYPO_SPELLING: 'inout' may be misspelled - perhaps 'input'?
#295: FILE: drivers/common/sfc_efx/base/medford4_impl.h:92:
+ __inout_opt uint32_t *generationp);
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#319: FILE: drivers/common/sfc_efx/base/medford4_mac.c:128:
+ return (0);
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#323: FILE: drivers/common/sfc_efx/base/medford4_mac.c:132:
+ return (rc);
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#339: FILE: drivers/common/sfc_efx/base/medford4_mac.c:148:
+ return (0);
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#343: FILE: drivers/common/sfc_efx/base/medford4_mac.c:152:
+ return (rc);
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#370: FILE: drivers/common/sfc_efx/base/medford4_mac.c:179:
+ return (0);
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#374: FILE: drivers/common/sfc_efx/base/medford4_mac.c:183:
+ return (rc);
WARNING:SPACING: space prohibited between function name and open parenthesis '('
#378: FILE: drivers/common/sfc_efx/base/medford4_mac.c:187:
+ EFSYS_MEM_READQ((_esmp), (_field) * sizeof (efx_qword_t), _eqp)
WARNING:TYPO_SPELLING: 'inout' may be misspelled - perhaps 'input'?
#384: FILE: drivers/common/sfc_efx/base/medford4_mac.c:193:
+ __inout_ecount(EFX_MAC_NSTATS) efsys_stat_t *stats,
WARNING:TYPO_SPELLING: 'inout' may be misspelled - perhaps 'input'?
#385: FILE: drivers/common/sfc_efx/base/medford4_mac.c:194:
+ __inout_opt uint32_t *generationp)
WARNING:SPACING: space prohibited between function name and open parenthesis '('
#396: FILE: drivers/common/sfc_efx/base/medford4_mac.c:205:
+ (encp->enc_mac_stats_nstats * sizeof (efx_qword_t))) {
WARNING:SPACING: space prohibited between function name and open parenthesis '('
#431: FILE: drivers/common/sfc_efx/base/medford4_mac.c:240:
+ sizeof (generation_start)) != 0)
WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -EAGAIN)
#432: FILE: drivers/common/sfc_efx/base/medford4_mac.c:241:
+ return (EAGAIN);
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#437: FILE: drivers/common/sfc_efx/base/medford4_mac.c:246:
+ return (0);
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#441: FILE: drivers/common/sfc_efx/base/medford4_mac.c:250:
+ return (rc);
total: 9 errors, 9 warnings, 329 lines checked
parent reply other threads:[~2025-04-16 14:08 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20250416140016.36127-36-ivan.malov@arknetworks.am>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250416140803.AD306123F9E@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=ivan.malov@arknetworks.am \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).