automatic DPDK test reports
 help / color / mirror / Atom feed
From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Harry van Haaren <harry.van.haaren@intel.com>
Subject: |WARNING| pw153011 [PATCH] rust: RFC/demo of safe API for Dpdk Eal, Eth and Rxq
Date: Thu, 17 Apr 2025 17:12:09 +0200 (CEST)	[thread overview]
Message-ID: <20250417151209.60E1E123FA4@dpdk.org> (raw)
In-Reply-To: <20250417151039.186448-1-harry.van.haaren@intel.com>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/153011

_coding style issues_


WARNING:TYPO_SPELLING: 'crate' may be misspelled - perhaps 'create'?
#126: FILE: rust_api_example/src/main.rs:20:
+            pub(crate) fn new(port: u16, queue: u16) -> Self {

WARNING:TYPO_SPELLING: 'recieve' may be misspelled - perhaps 'receive'?
#136: FILE: rust_api_example/src/main.rs:30:
+            // and the Rxq has the rx_burst() function: this allows the application to recieve packets.

WARNING:TYPO_SPELLING: 'mut' may be misspelled - perhaps 'must'?
#157: FILE: rust_api_example/src/main.rs:51:
+            pub fn rx_burst(&mut self, _mbufs: &mut [u8]) -> Result<usize, ()> {

WARNING:TYPO_SPELLING: 'mut' may be misspelled - perhaps 'must'?
#157: FILE: rust_api_example/src/main.rs:51:
+            pub fn rx_burst(&mut self, _mbufs: &mut [u8]) -> Result<usize, ()> {

WARNING:TYPO_SPELLING: 'crate' may be misspelled - perhaps 'create'?
#159: FILE: rust_api_example/src/main.rs:53:
+                //  e.g.: investigate "ArrayVec" crate for safe & fixed sized, stack allocated arrays

WARNING:TYPO_SPELLING: 'crate' may be misspelled - perhaps 'create'?
#183: FILE: rust_api_example/src/main.rs:77:
+            // pub(crate) here ensures outside this crate users cannot call this function

WARNING:TYPO_SPELLING: 'crate' may be misspelled - perhaps 'create'?
#183: FILE: rust_api_example/src/main.rs:77:
+            // pub(crate) here ensures outside this crate users cannot call this function

WARNING:TYPO_SPELLING: 'crate' may be misspelled - perhaps 'create'?
#184: FILE: rust_api_example/src/main.rs:78:
+            pub(crate) fn from_u16(id: u16) -> Self {

WARNING:TYPO_SPELLING: 'mut' may be misspelled - perhaps 'must'?
#192: FILE: rust_api_example/src/main.rs:86:
+            pub fn rxqs(&mut self, rxq_count: u16, _mempool: Mempool) -> Result<(), String> {

WARNING:TYPO_SPELLING: 'mut' may be misspelled - perhaps 'must'?
#200: FILE: rust_api_example/src/main.rs:94:
+            pub fn start(&mut self) -> (Vec<RxqHandle>, Vec<TxqHandle>) {

WARNING:TYPO_SPELLING: 'mut' may be misspelled - perhaps 'must'?
#203: FILE: rust_api_example/src/main.rs:97:
+                    std::mem::take(&mut self.rxqs),

WARNING:TYPO_SPELLING: 'mut' may be misspelled - perhaps 'must'?
#204: FILE: rust_api_example/src/main.rs:98:
+                    std::mem::take(&mut self.txqs),

WARNING:TYPO_SPELLING: 'mut' may be misspelled - perhaps 'must'?
#242: FILE: rust_api_example/src/main.rs:136:
+        pub fn take_eth_ports(&mut self) -> Option<Vec<eth::Port>> {

WARNING:TYPO_SPELLING: 'mut' may be misspelled - perhaps 'must'?
#248: FILE: rust_api_example/src/main.rs:142:
+        fn drop(&mut self) {

WARNING:TYPO_SPELLING: 'mut' may be misspelled - perhaps 'must'?
#255: FILE: rust_api_example/src/main.rs:149:
+    let mut dpdk = dpdk::Eal::init().expect("dpdk must init ok");

WARNING:TYPO_SPELLING: 'mut' may be misspelled - perhaps 'must'?
#258: FILE: rust_api_example/src/main.rs:152:
+    let mut ports = dpdk.take_eth_ports().expect("take eth ports ok");

WARNING:TYPO_SPELLING: 'mut' may be misspelled - perhaps 'must'?
#259: FILE: rust_api_example/src/main.rs:153:
+    let mut p = ports.pop().unwrap();

WARNING:TYPO_SPELLING: 'mut' may be misspelled - perhaps 'must'?
#264: FILE: rust_api_example/src/main.rs:158:
+    let (mut rxqs, _txqs) = p.start();

WARNING:TYPO_SPELLING: 'mut' may be misspelled - perhaps 'must'?
#278: FILE: rust_api_example/src/main.rs:172:
+        // let mut rxq = rxq2.enable_polling();

WARNING:TYPO_SPELLING: 'mut' may be misspelled - perhaps 'must'?
#282: FILE: rust_api_example/src/main.rs:176:
+        let mut rxq = rxq1.enable_polling();

WARNING:TYPO_SPELLING: 'mut' may be misspelled - perhaps 'must'?
#284: FILE: rust_api_example/src/main.rs:178:
+            let _nb_mbufs = rxq.rx_burst(&mut [0; 32]);

WARNING:TYPO_SPELLING: 'mut' may be misspelled - perhaps 'must'?
#290: FILE: rust_api_example/src/main.rs:184:
+    let mut rxq = rxq2.enable_polling();

WARNING:TYPO_SPELLING: 'mut' may be misspelled - perhaps 'must'?
#292: FILE: rust_api_example/src/main.rs:186:
+        let _nb_mbufs = rxq.rx_burst(&mut [0; 32]);

total: 0 errors, 23 warnings, 195 lines checked

  parent reply	other threads:[~2025-04-17 15:12 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20250417151039.186448-1-harry.van.haaren@intel.com>
2025-04-17 14:37 ` |SUCCESS| " qemudev
2025-04-17 14:42 ` qemudev
2025-04-17 15:12 ` checkpatch [this message]
2025-04-17 15:43 ` |SUCCESS| pw153011 [PATCH] rust: RFC/demo of safe API for Dpdk Eal, dpdklab
2025-04-17 15:50 ` |PENDING| " dpdklab
2025-04-17 15:50 ` |SUCCESS| " dpdklab
2025-04-17 15:51 ` dpdklab
2025-04-17 15:58 ` dpdklab
2025-04-17 15:59 ` |PENDING| " dpdklab
2025-04-17 16:00 ` dpdklab
2025-04-17 16:03 ` |SUCCESS| " dpdklab
2025-04-17 16:05 ` dpdklab
2025-04-17 16:06 ` dpdklab
2025-04-17 16:17 ` dpdklab
2025-04-17 16:30 ` dpdklab
2025-04-17 16:58 ` dpdklab
2025-04-17 17:03 ` dpdklab
2025-04-17 17:11 ` dpdklab
2025-04-17 17:26 ` dpdklab
2025-04-17 17:27 ` dpdklab
2025-04-17 17:54 ` dpdklab
2025-04-17 18:15 ` dpdklab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250417151209.60E1E123FA4@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=harry.van.haaren@intel.com \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).