From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DCC84465B7 for ; Thu, 17 Apr 2025 17:12:31 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D7FFB400D6; Thu, 17 Apr 2025 17:12:31 +0200 (CEST) Received: from dpdk.org (dpdk.org [92.243.24.197]) by mails.dpdk.org (Postfix) with ESMTP id B7BF0400D5 for ; Thu, 17 Apr 2025 17:12:30 +0200 (CEST) Received: by dpdk.org (Postfix, from userid 65534) id 60E1E123FA4; Thu, 17 Apr 2025 17:12:09 +0200 (CEST) Subject: |WARNING| pw153011 [PATCH] rust: RFC/demo of safe API for Dpdk Eal, Eth and Rxq In-Reply-To: <20250417151039.186448-1-harry.van.haaren@intel.com> References: <20250417151039.186448-1-harry.van.haaren@intel.com> To: test-report@dpdk.org From: checkpatch@dpdk.org Cc: Harry van Haaren Message-Id: <20250417151209.60E1E123FA4@dpdk.org> Date: Thu, 17 Apr 2025 17:12:09 +0200 (CEST) X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/153011 _coding style issues_ WARNING:TYPO_SPELLING: 'crate' may be misspelled - perhaps 'create'? #126: FILE: rust_api_example/src/main.rs:20: + pub(crate) fn new(port: u16, queue: u16) -> Self { WARNING:TYPO_SPELLING: 'recieve' may be misspelled - perhaps 'receive'? #136: FILE: rust_api_example/src/main.rs:30: + // and the Rxq has the rx_burst() function: this allows the application to recieve packets. WARNING:TYPO_SPELLING: 'mut' may be misspelled - perhaps 'must'? #157: FILE: rust_api_example/src/main.rs:51: + pub fn rx_burst(&mut self, _mbufs: &mut [u8]) -> Result { WARNING:TYPO_SPELLING: 'mut' may be misspelled - perhaps 'must'? #157: FILE: rust_api_example/src/main.rs:51: + pub fn rx_burst(&mut self, _mbufs: &mut [u8]) -> Result { WARNING:TYPO_SPELLING: 'crate' may be misspelled - perhaps 'create'? #159: FILE: rust_api_example/src/main.rs:53: + // e.g.: investigate "ArrayVec" crate for safe & fixed sized, stack allocated arrays WARNING:TYPO_SPELLING: 'crate' may be misspelled - perhaps 'create'? #183: FILE: rust_api_example/src/main.rs:77: + // pub(crate) here ensures outside this crate users cannot call this function WARNING:TYPO_SPELLING: 'crate' may be misspelled - perhaps 'create'? #183: FILE: rust_api_example/src/main.rs:77: + // pub(crate) here ensures outside this crate users cannot call this function WARNING:TYPO_SPELLING: 'crate' may be misspelled - perhaps 'create'? #184: FILE: rust_api_example/src/main.rs:78: + pub(crate) fn from_u16(id: u16) -> Self { WARNING:TYPO_SPELLING: 'mut' may be misspelled - perhaps 'must'? #192: FILE: rust_api_example/src/main.rs:86: + pub fn rxqs(&mut self, rxq_count: u16, _mempool: Mempool) -> Result<(), String> { WARNING:TYPO_SPELLING: 'mut' may be misspelled - perhaps 'must'? #200: FILE: rust_api_example/src/main.rs:94: + pub fn start(&mut self) -> (Vec, Vec) { WARNING:TYPO_SPELLING: 'mut' may be misspelled - perhaps 'must'? #203: FILE: rust_api_example/src/main.rs:97: + std::mem::take(&mut self.rxqs), WARNING:TYPO_SPELLING: 'mut' may be misspelled - perhaps 'must'? #204: FILE: rust_api_example/src/main.rs:98: + std::mem::take(&mut self.txqs), WARNING:TYPO_SPELLING: 'mut' may be misspelled - perhaps 'must'? #242: FILE: rust_api_example/src/main.rs:136: + pub fn take_eth_ports(&mut self) -> Option> { WARNING:TYPO_SPELLING: 'mut' may be misspelled - perhaps 'must'? #248: FILE: rust_api_example/src/main.rs:142: + fn drop(&mut self) { WARNING:TYPO_SPELLING: 'mut' may be misspelled - perhaps 'must'? #255: FILE: rust_api_example/src/main.rs:149: + let mut dpdk = dpdk::Eal::init().expect("dpdk must init ok"); WARNING:TYPO_SPELLING: 'mut' may be misspelled - perhaps 'must'? #258: FILE: rust_api_example/src/main.rs:152: + let mut ports = dpdk.take_eth_ports().expect("take eth ports ok"); WARNING:TYPO_SPELLING: 'mut' may be misspelled - perhaps 'must'? #259: FILE: rust_api_example/src/main.rs:153: + let mut p = ports.pop().unwrap(); WARNING:TYPO_SPELLING: 'mut' may be misspelled - perhaps 'must'? #264: FILE: rust_api_example/src/main.rs:158: + let (mut rxqs, _txqs) = p.start(); WARNING:TYPO_SPELLING: 'mut' may be misspelled - perhaps 'must'? #278: FILE: rust_api_example/src/main.rs:172: + // let mut rxq = rxq2.enable_polling(); WARNING:TYPO_SPELLING: 'mut' may be misspelled - perhaps 'must'? #282: FILE: rust_api_example/src/main.rs:176: + let mut rxq = rxq1.enable_polling(); WARNING:TYPO_SPELLING: 'mut' may be misspelled - perhaps 'must'? #284: FILE: rust_api_example/src/main.rs:178: + let _nb_mbufs = rxq.rx_burst(&mut [0; 32]); WARNING:TYPO_SPELLING: 'mut' may be misspelled - perhaps 'must'? #290: FILE: rust_api_example/src/main.rs:184: + let mut rxq = rxq2.enable_polling(); WARNING:TYPO_SPELLING: 'mut' may be misspelled - perhaps 'must'? #292: FILE: rust_api_example/src/main.rs:186: + let _nb_mbufs = rxq.rx_burst(&mut [0; 32]); total: 0 errors, 23 warnings, 195 lines checked