|WARNING| pw153039 [PATCH 1/3] rust: RFC/demo of safe API for Dpdk Eal, Eth and Rxq

|WARNING| pw153039 [PATCH 1/3] rust: RFC/demo of safe API for Dpdk Eal, Eth and Rxq

[checkpatch]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/153039

_coding style issues_


WARNING:TYPO_SPELLING: 'crate' may be misspelled - perhaps 'create'?
#128: FILE: rust_api_example/src/main.rs:20:
+            pub(crate) fn new(port: u16, queue: u16) -> Self {

WARNING:TYPO_SPELLING: 'recieve' may be misspelled - perhaps 'receive'?
#138: FILE: rust_api_example/src/main.rs:30:
+            // and the Rxq has the rx_burst() function: this allows the application to recieve packets.

WARNING:TYPO_SPELLING: 'mut' may be misspelled - perhaps 'must'?
#159: FILE: rust_api_example/src/main.rs:51:
+            pub fn rx_burst(&mut self, _mbufs: &mut [u8]) -> Result<usize, ()> {

WARNING:TYPO_SPELLING: 'mut' may be misspelled - perhaps 'must'?
#159: FILE: rust_api_example/src/main.rs:51:
+            pub fn rx_burst(&mut self, _mbufs: &mut [u8]) -> Result<usize, ()> {

WARNING:TYPO_SPELLING: 'crate' may be misspelled - perhaps 'create'?
#161: FILE: rust_api_example/src/main.rs:53:
+                //  e.g.: investigate "ArrayVec" crate for safe & fixed sized, stack allocated arrays

WARNING:TYPO_SPELLING: 'crate' may be misspelled - perhaps 'create'?
#185: FILE: rust_api_example/src/main.rs:77:
+            // pub(crate) here ensures outside this crate users cannot call this function

WARNING:TYPO_SPELLING: 'crate' may be misspelled - perhaps 'create'?
#185: FILE: rust_api_example/src/main.rs:77:
+            // pub(crate) here ensures outside this crate users cannot call this function

WARNING:TYPO_SPELLING: 'crate' may be misspelled - perhaps 'create'?
#186: FILE: rust_api_example/src/main.rs:78:
+            pub(crate) fn from_u16(id: u16) -> Self {

WARNING:TYPO_SPELLING: 'mut' may be misspelled - perhaps 'must'?
#194: FILE: rust_api_example/src/main.rs:86:
+            pub fn rxqs(&mut self, rxq_count: u16, _mempool: Mempool) -> Result<(), String> {

WARNING:TYPO_SPELLING: 'mut' may be misspelled - perhaps 'must'?
#202: FILE: rust_api_example/src/main.rs:94:
+            pub fn start(&mut self) -> (Vec<RxqHandle>, Vec<TxqHandle>) {

WARNING:TYPO_SPELLING: 'mut' may be misspelled - perhaps 'must'?
#205: FILE: rust_api_example/src/main.rs:97:
+                    std::mem::take(&mut self.rxqs),

WARNING:TYPO_SPELLING: 'mut' may be misspelled - perhaps 'must'?
#206: FILE: rust_api_example/src/main.rs:98:
+                    std::mem::take(&mut self.txqs),

WARNING:TYPO_SPELLING: 'mut' may be misspelled - perhaps 'must'?
#244: FILE: rust_api_example/src/main.rs:136:
+        pub fn take_eth_ports(&mut self) -> Option<Vec<eth::Port>> {

WARNING:TYPO_SPELLING: 'mut' may be misspelled - perhaps 'must'?
#250: FILE: rust_api_example/src/main.rs:142:
+        fn drop(&mut self) {

WARNING:TYPO_SPELLING: 'mut' may be misspelled - perhaps 'must'?
#257: FILE: rust_api_example/src/main.rs:149:
+    let mut dpdk = dpdk::Eal::init().expect("dpdk must init ok");

WARNING:TYPO_SPELLING: 'mut' may be misspelled - perhaps 'must'?
#260: FILE: rust_api_example/src/main.rs:152:
+    let mut ports = dpdk.take_eth_ports().expect("take eth ports ok");

WARNING:TYPO_SPELLING: 'mut' may be misspelled - perhaps 'must'?
#261: FILE: rust_api_example/src/main.rs:153:
+    let mut p = ports.pop().unwrap();

WARNING:TYPO_SPELLING: 'mut' may be misspelled - perhaps 'must'?
#266: FILE: rust_api_example/src/main.rs:158:
+    let (mut rxqs, _txqs) = p.start();

WARNING:TYPO_SPELLING: 'mut' may be misspelled - perhaps 'must'?
#280: FILE: rust_api_example/src/main.rs:172:
+        // let mut rxq = rxq2.enable_polling();

WARNING:TYPO_SPELLING: 'mut' may be misspelled - perhaps 'must'?
#284: FILE: rust_api_example/src/main.rs:176:
+        let mut rxq = rxq1.enable_polling();

WARNING:TYPO_SPELLING: 'mut' may be misspelled - perhaps 'must'?
#286: FILE: rust_api_example/src/main.rs:178:
+            let _nb_mbufs = rxq.rx_burst(&mut [0; 32]);

WARNING:TYPO_SPELLING: 'mut' may be misspelled - perhaps 'must'?
#292: FILE: rust_api_example/src/main.rs:184:
+    let mut rxq = rxq2.enable_polling();

WARNING:TYPO_SPELLING: 'mut' may be misspelled - perhaps 'must'?
#294: FILE: rust_api_example/src/main.rs:186:
+        let _nb_mbufs = rxq.rx_burst(&mut [0; 32]);

total: 0 errors, 23 warnings, 195 lines checked